Desdroid commented on PR #65006:
URL: https://github.com/apache/airflow/pull/65006#issuecomment-4225343202

   > I think it was just missed before the release that it can, potentially, 
break some stuff. Sorry for the inconvenience and thanks for the PR!
   
   Sure 😃 I think that also `useStandardNaming: true` is a prerequisite for 
this bug. I found in the values.yaml that there was a Note that 
fernet-key,redis-password and broker-url secrets deliberately did not use the 
`airflow-fullname` helper as it might break existing installations (see 
https://github.com/apache/airflow/blob/main/chart/values.yaml#L38-L40)
   I removed that note, as it is outdated since #52953 
   
   > I think some extension to the `extending-the-chart.rst` would be good to 
add, and maybe a newsfragment to make this bugfix more visible during the next 
release, as it changes the behaviour, and I would not be surprised if some 
people are depending on the current behaviour even if they do not know about it.
   
   I added a newsfragment and also included a possible workaround, though I'm 
not 100% sure that the workaround is correct. I'll try to test with our 
installation.
   I don't know what should be worded differently / added in 
`extending-the-chart.rst` - If you want a change there please tell me what you 
think of.  (This bug is not a general rule on how to do something differently 
when extending the chart, is it?)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to