Desdroid commented on code in PR #65006: URL: https://github.com/apache/airflow/pull/65006#discussion_r3071467422
########## chart/newsfragments/65006.significant.rst: ########## @@ -0,0 +1,3 @@ +``fernet-key``, ``redis-password`` and ``broker-url`` secrets migrated to use standard naming as well as some other K8s resources. + +This likely breaks existing installations with ``useStandardNaming=True`` that have a ``fullnameOverride != Release.Name``, ``nameOverride != Release.Name`` or use the airflow helm chart as a dependency. Review Comment: I somewhat agree with this. My change is only a bugfix not a breaking change. If we include this newsfragment now, it looks like the change is only in there since the next release, which simply is wrong and misleading for users. But in fact it's been changed since v.1.19 - so imo the release notes there should be adapted and the newsfragment here be removed. @Miretpl @jscheffl What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
