On Thu, 12 Mar 2026 09:19:27 GMT, Ivan Walulya <[email protected]> wrote:
>> Stefan Karlsson has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> lworld_array_klass_cleanups >> - faKlass => fak >> - Stray whitespaces >> - Restore jniCheck.cpp >> - Array cleanups >> - Retype _objectArrayKlass >> - allocate_instance >> - Small cleanups >> - More type checks >> - Constify and move around ArrayKlass::_properties >> - ... and 2 more: >> https://git.openjdk.org/valhalla/compare/f81526ca...74a24ba4 > > LGTM! > > The "inline" PR comments were very helpful. Thanks. Thanks @walulyai for reviewing! > src/hotspot/share/oops/arrayKlass.cpp line 171: > >> 169: if (higher_dimension() == nullptr) { >> 170: // Create multi-dim klass object and link them together >> 171: ObjArrayKlass* ak = > > might be good to use the `oak` as used elsewhere. I agree. This function now look exactly like the one in openjdk/jdk. It would probably be better to make that change there instead. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2207#issuecomment-4045477955 PR Review Comment: https://git.openjdk.org/valhalla/pull/2207#discussion_r2923541815
