On Wed, 11 Mar 2026 14:37:25 GMT, Stefan Karlsson <[email protected]> wrote:
>> I've been looking over the current state of ArrayKlass and the sub-classes >> and made various cleanups and simplifications that I'd like to get >> integrated: >> >> * Type Universe::_objectArrayKlass as RefArrayKlass >> * Remove dead flat array code in code in javaClasses.cpp >> * Used is_refined_objArray_klass where appropriate >> * Introduce is_unrefined_objArray for asserts and checks >> * Restore code and whitespace changes compared to upstream >> * Renamed faklass to fak in oops/ and GC code (I didn't touch other areas >> that used that name) >> * Devirtualized ObjArrayKlass::allocate_instance and simplified related code >> * Moved ArrayKlass::_properties to after the variables for array dimensions. >> * Made ArrayKlass::_properties const and non-settable >> * Unified oop_iterate_elements_range implementations >> * Added ShouldNotReachHere implementation of ObjArrayKlass::copy_array >> * Removed redundant check in jniCheck.cpp and restored the file > > Stefan Karlsson has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 12 commits: > > - Merge remote-tracking branch 'valhalla/lworld' into > lworld_array_klass_cleanups > - faKlass => fak > - Stray whitespaces > - Restore jniCheck.cpp > - Array cleanups > - Retype _objectArrayKlass > - allocate_instance > - Small cleanups > - More type checks > - Constify and move around ArrayKlass::_properties > - ... and 2 more: > https://git.openjdk.org/valhalla/compare/f81526ca...74a24ba4 LGTM! The "inline" PR comments were very helpful. Thanks. src/hotspot/share/oops/arrayKlass.cpp line 171: > 169: if (higher_dimension() == nullptr) { > 170: // Create multi-dim klass object and link them together > 171: ObjArrayKlass* ak = might be good to use the `oak` as used elsewhere. ------------- Marked as reviewed by iwalulya (no project role). PR Review: https://git.openjdk.org/valhalla/pull/2207#pullrequestreview-3934980146 PR Review Comment: https://git.openjdk.org/valhalla/pull/2207#discussion_r2923229065
