On Fri, 13 Mar 2026 08:12:18 GMT, Axel Boldt-Christmas <[email protected]>
wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> THREAD to CHECK
>
> src/hotspot/share/oops/flatArrayOop.inline.hpp line 123:
>
>> 121: faklass->oop_oop_iterate_elements_range<narrowOop>(this, blk,
>> start, end);
>> 122: } else {
>> 123: faklass->oop_oop_iterate_elements_range<oop>(this, blk, start, end);
>
> Potential follow-up:
>
> Would be nice to add covariant return types for `klass()` in our oopDesc
> hierarchy. So we would have `flatArrayKlass* flatArrayOopDesc::klass() const`
> here and could just write `klass()->oop_oop_iterate_elements_range<...>(...)`
WDYT:
https://github.com/openjdk/valhalla/compare/lworld...stefank:valhalla:lworld_typed_klass
I can open a PR if this seems OK.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2207#discussion_r2930645519
