On Mon, 9 Mar 2026 12:47:45 GMT, Stefan Karlsson <[email protected]> wrote:

>> Stefan Karlsson has updated the pull request with a new target base due to a 
>> merge or a rebase. The pull request now contains 12 commits:
>> 
>>  - Merge remote-tracking branch 'valhalla/lworld' into 
>> lworld_array_klass_cleanups
>>  - faKlass => fak
>>  - Stray whitespaces
>>  - Restore jniCheck.cpp
>>  - Array cleanups
>>  - Retype _objectArrayKlass
>>  - allocate_instance
>>  - Small cleanups
>>  - More type checks
>>  - Constify and move around ArrayKlass::_properties
>>  - ... and 2 more: 
>> https://git.openjdk.org/valhalla/compare/f81526ca...74a24ba4
>
> src/hotspot/share/oops/objArrayOop.inline.hpp line 48:
> 
>> 46:   assert(is_within_bounds(index), "index %d out of bounds %d", index, 
>> length());
>> 47:   assert(is_refArray(), "Should only be called with ref arrays");  
>> 48:   return ((const refArrayOopDesc*)this)->obj_at(index);
> 
> We really should not be calling this version for flat arrays. One more step 
> towards removing that version of flatArrayOopDec::obj_at.

This got deleted with Axel's recent change.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2207#discussion_r2923609192

Reply via email to