On Mon, 9 Mar 2026 12:35:32 GMT, Stefan Karlsson <[email protected]> wrote:
>> Stefan Karlsson has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> lworld_array_klass_cleanups >> - faKlass => fak >> - Stray whitespaces >> - Restore jniCheck.cpp >> - Array cleanups >> - Retype _objectArrayKlass >> - allocate_instance >> - Small cleanups >> - More type checks >> - Constify and move around ArrayKlass::_properties >> - ... and 2 more: >> https://git.openjdk.org/valhalla/compare/f81526ca...74a24ba4 > > src/hotspot/share/gc/shared/collectedHeap.inline.hpp line 42: > >> 40: >> 41: inline oop CollectedHeap::array_allocate(Klass* klass, size_t size, int >> length, bool do_zero, TRAPS) { >> 42: assert(klass->is_typeArray_klass() || >> klass->is_refined_objArray_klass(), "ObjArrayKlass must never be used to >> allocate array instances directly"); > > Could probably also be changed to: > Suggestion: > > assert(!klass->is_unrefined_objArray_klass(), "ObjArrayKlass must never be > used to allocate array instances directly"); I prefer the `!klass->is_unrefined_objArray_klass()` version ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2207#discussion_r2923284349
