Hi Stefan,
2013/7/31 Stefan Dösinger
> Hi,
>
> Am 31.07.2013 um 09:10 schrieb Christian Costa :
>
> +if (!(strstr(line_out, "warning X3206:") &&
> strstr(line_out, "implicit truncation of vector type")))
> +l
Le 26/06/2013 09:10, Henri Verbeet a écrit :
On 25 June 2013 18:26, Stefan Dösinger wrote:
While I agree with Henri's statement to some extend - patch reviewing
is a terribly exhausting task - I think the statement was a bit harsh
to say to someone who donates his personal time to the project.
t;fonction" is the french word for "function". Probably a wrong locale.
;)
2013/6/25 Stefan Dösinger
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Am 2013-06-25 18:08, schrieb Christian Costa:
> > Are we really discussing about a typo in the subject line?
2013/6/25 Henri Verbeet
> On 25 June 2013 11:05, Christian Costa wrote:
> > 2013/6/25 Henri Verbeet
> >> At least try to pretend you put
> >> some effort into making sure the patch is as good as it can be before
> >> submitting it.
> >
> >
>
2013/6/25 Henri Verbeet
> On 24 June 2013 16:44, Matteo Bruni wrote:
> > @@ -1673,6 +1673,8 @@ struct texture_stage_op
> > unsignedaarg2 : 8;
> > unsignedaarg0 : 8;
> >
> > +DWORD constant;
> > +
> > struct color_fixup_desc col
I'm not Henri but I can mention a number of issues (which might or
might not match with Henri's).
+for (stage = 0; stage < MAX_TEXTURES && settings->op[stage].cop
!= WINED3D_TOP_DISABLE; ++stage)
You probably want to generate this code only for texture stages
actually using constants.
Yes.
Le 24/06/2013 09:24, Henri Verbeet a écrit :
On 23 June 2013 21:57, Christian Costa wrote:
When D3DTA_CONSTANT is use in a texture stage, the generated shader uses
variables that are not defined making thus the compilation to fail.
This patch declare these variables with the value from the
Hi,
This patch http://source.winehq.org/patches/data/96965 is in the pending
state.
Is there anything wrong or missing.
Basically this patch only changes the test to check exactly the returned
value to show the difference in behaviour between A and Version of the
API. The rest is just to thin
Hi and welcome,
Patches should be sent included in the mail. Adding tests is recommended.
You can follow status at http://source.winehq.org/patches/. But currently
we're in code freeze so you may have to wait Wine 1.6.
Christian
2013/6/19 Bartosz
> My name is Bartosz and I would like to start
> >
> > if (sm > 2) handle instruction length
> > else if (comment or def instruction) special handling for them
> > else skip DWORD with bit 31 set
> >
> > Is this correct?
> >
>
> SM >= 2 for the instruction length case, but apart from that it should be
> good.
>
>
Oups. Tipo. It's what I meant.
> > +HRESULT WINAPI D3DXGetShaderInputSemantics(const DWORD *byte_code,
> D3DXSEMANTIC *semantics, UINT *count)
> > +{
> > +const DWORD *ptr = byte_code;
> > +UINT i = 0;
> > +
> > +TRACE("byte_code = %p, semantics = %p, count = %p\n", byte_code,
> semantics, count);
> > +
> > +if (
2013/6/11 Rico Schüller
> On 11.06.2013 22:08, Christian Costa wrote:
>
>> +TRACE("byte_code = %p, semantics = %p, count = %p\n", byte_code,
>> semantics, count);
>>
> The rest of the file seems to use the trace without the "=".
>
2013/6/11 Rico Schüller
> On 11.06.2013 22:08, Christian Costa wrote:
>
>> Fixes bug 26598.
>> ---
>> dlls/d3dx9_36/effect.c |4
>> dlls/d3dx9_36/tests/effect.c | 17 +
>> 2 files changed, 21 insertions(+)
>>
>
Hi,
Is there something wrong with this patch? The only feedback I got is a typo
(fixed).
http://source.winehq.org/patches/data/96712
Thanks
2013/6/5 Rico Schüller
> On 05.06.2013 08:48, Christian Costa wrote:
>
>> bone = &This->bones[bone_num];
>> +/* Decrement refcounts of vertices previously influenced */
>> +for (i = 0; i < bone->num_influences; i++)
>> +if (bone-&
2013/6/4 Bruno Jesus <00cp...@gmail.com>
> On Tue, Jun 4, 2013 at 12:38 PM, Christian Costa
> wrote:
> >
> > Hi,
> >
> > Minor but shouldn't it be "bug" instead "bugs"?
>
> At least in portuguese zero is plural.
Ta! Mas na
Hi,
Minor but shouldn't it be "bug" instead "bugs"?
Christian
2013/5/31 Detlef Riekenberg
> Christian wrote at Wednesday, 29. Mai 2013 at 23:12 Uhr
>
> > > + */
> > > +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD
> *pvalue)
> > > +{
> > >
> > > -SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR
> lpszValueName, LPDWORD pdwValue);
>
Le 30/05/2013 13:56, Dmitry Timoshkov a écrit :
Christian Costa wrote:
and no modern gcc/other compiler that I can find cares.
It was probably added because of a tool that warned of the unused
parameter ... So it all goes in circles. ;)
Ciao, Marcus
So what about action = NULL instead
Le 30/05/2013 10:59, Dmitry Timoshkov a écrit :
Christian Costa wrote:
and no modern gcc/other compiler that I can find cares.
It was probably added because of a tool that warned of the unused
parameter ... So it all goes in circles. ;)
Ciao, Marcus
So what about action = NULL instead
Le 30/05/2013 09:54, Marcus Meissner a écrit :
On Wed, May 29, 2013 at 10:23:29PM -0700, Austin English wrote:
This was added 12 years ago in 1db20bfd33f9c1486a1a662c2f78f45d00caf24b
but clang doesn't like it:
clang -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__
-D_MT -D_REENTRA
Le 29/05/2013 12:06, Detlef Riekenberg a écrit :
--
By by ... Detlef
---
dlls/slc/slc.c | 31 +++
include/slpublic.h |2 +-
2 files changed, 24 insertions(+), 9 deletions(-)
diff --git a/dlls/slc/slc.c b/dlls/slc/slc.c
index e7416f1..7fc9b93 100644
--- a
Hi,
You're right. This can be simplified. Will send a patch. Thanks.
Christian
2013/5/29 gurketsky
> Hi,
>
> just saw that a bit late. Is there a reason for the rewrite of hr?
>
> Could any call return anything other than D3D_OK and succeed (maybe
> S_FALSE)? It may be possible to drop "if (FA
2013/5/27 Henri Verbeet
> On 27 May 2013 13:19, Christian Costa wrote:
> > Original ddraw/d3d used
> > the same format as d3drm until you changed it (as well as methods names).
> This is perhaps slightly bad form, but since you're pressing the
> point: Yes, and those w
).
Since you're working on
it that's not a problem but there is no need to change other dlls if you're
not working on them.
If consistency in wine is something that matters, and I think it does,
discussion is a better way for that.
2013/5/27 Henri Verbeet
> On 27 May 2013 11:1
2013/5/27 Henri Verbeet
> On 27 May 2013 09:49, Christian Costa wrote:
> >> -FIXME("(%p/%p)->(%s,%p): stub\n", iface, This, filename, Texture);
> >> +FIXME("iface %p, filename %s, texture %p stub!\n", iface,
> >> debugstr_a(filename)
Le 27/05/2013 09:22, Henri Verbeet a écrit :
---
dlls/d3drm/d3drm.c | 20
dlls/d3drm/frame.c | 22 +++---
dlls/d3drm/meshbuilder.c | 14 +++---
dlls/d3drm/tests/d3drm.c | 16
include/d3drm.h | 4 ++--
inclu
Hi,
Is there any problem with these patches?
http://source.winehq.org/patches/data/96314
http://source.winehq.org/patches/data/96328
Christian
2013/5/22 Stefan Dösinger
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Am 2013-05-22 10:59, schrieb Christian Costa:
> > *"You are not allowed to analyze Windows files with the trace
> > functions of Wine"
> E.g. when you are working on Wine's
*Hi,
*
*I read on the GSoC page this:
*
*"You are not allowed to analyze Windows files with the trace functions of
Wine"
*
*What does that mean?
*
*Thanks
*
*Christian
*
That's ok with me.Thanks for the explanation. So Valgrind will report these
"intentional" memory leaks in addition to the "unintentional" ones. Correct?
2013/5/21 Dmitry Timoshkov
> Christian Costa wrote:
>
> > Out of curiosity. Not freeing these
Out of curiosity. Not freeing these memory allocations shouldn't disturb
Valgrind to report false memory leaks?
2013/5/21 Alexandre Julliard
> Dmitry Timoshkov writes:
>
> > Alexandre Julliard wrote:
> >
> >> >>case DLL_PROCESS_DETACH:
> >> >> -msvcrt_free_popen_data();
> >> >> m
2013/5/17 Austin English
> On Thu, May 16, 2013 at 2:26 PM, Christian Costa
> wrote:
> > Also remove fixme in wined3d_device_get_software_vertex_processing since
> it does what it is supposed to do.
> > ---
> > dlls/wined3d/device.c | 12 ++--
> > 1
Le 10/05/2013 16:37, Alexandre Julliard a écrit :
Christian Costa writes:
-if (strlen(target) != 6 || target[1] != 's' || target[2] != '_' ||
target[4] != '_')
+for (i = 0; i < nb_targets; i++)
{
-FIXME("Unknown compil
Le 09/05/2013 23:01, Alexandre Julliard a écrit :
Christian Costa writes:
Le 09/05/2013 22:05, Alexandre Julliard a écrit :
Christian Costa writes:
@@ -677,6 +677,7 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile)
{
ID3DXFileImpl *object;
HRESULT ret;
+const
Hi,
Is there anything wrong with these patches?
http://source.winehq.org/patches/data/96113
http://source.winehq.org/patches/data/96114
Christian
Le 09/05/2013 22:15, Christian Costa a écrit :
Le 09/05/2013 22:05, Alexandre Julliard a écrit :
Christian Costa writes:
@@ -677,6 +677,7 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile)
{
ID3DXFileImpl *object;
HRESULT ret;
+const char expand_string
Le 09/05/2013 22:05, Alexandre Julliard a écrit :
Christian Costa writes:
@@ -677,6 +677,7 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile)
{
ID3DXFileImpl *object;
HRESULT ret;
+const char expand_string[] = "expand_string";
TRACE("(%
Le 08/05/2013 19:19, Dmitry Timoshkov a écrit :
Christian Costa wrote:
-if (!name || !size)
+if (!name && !size)
return E_POINTER;
dxfile_size = *size;
So, what happens if name is not NULL, but size is?
Indeed I missed this type conversion line and
Le 08/05/2013 11:45, Sam Edwards a écrit :
After feedback from Dmitry (thanks!), I redid this patch with the
following changes:
* I misunderstood before what the test did; I initially thought this
was just a workaround to get aveWidth to behave, but as it turns out,
Windows has the same "maxi
Le 08/05/2013 12:43, Alexandre Julliard a écrit :
Christian Costa writes:
{
-FIXME("%p %s %s %u %08x %08x\n", hWnd, debugstr_w(lpText),
debugstr_w(lpCaption),
- uType, wLanguageId, f);
-return MessageBoxExW(hWnd,lpText,lpCaption,uType,wLanguageId);
+FIXME(&q
2013/5/3 Matteo Bruni
> 2013/5/2 Christian Costa :
> >
> > ---
> > dlls/d3dcompiler_43/compiler.c| 101
> +++--
> > dlls/d3dcompiler_43/d3dcompiler_private.h |1
> > 2 files changed, 81 insertions(+), 21 de
2013/5/2 Francois Gouget
> ---
> dlls/msi/tests/install.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c
> index e5d996e..0c322be 100644
> --- a/dlls/msi/tests/install.c
> +++ b/dlls/msi/tests/install.c
> @@ -3110,7
Le 01/05/2013 14:34, Hans Leidekker a écrit :
On Wed, 2013-05-01 at 12:40 +0200, Christian Costa wrote:
diff --git a/dlls/msi/media.c b/dlls/msi/media.c
index 612624d..4145c76 100644
--- a/dlls/msi/media.c
+++ b/dlls/msi/media.c
@@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet
Le 30/04/2013 14:14, Matteo Bruni a écrit :
2013/4/29 Christian Costa :
---
dlls/d3dx9_36/tests/xfile.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/d3dx9_36/tests/xfile.c b/dlls/d3dx9_36/tests/xfile.c
index 1238bcd..e514a5f 100644
--- a/dlls/d3dx9_36/tests
Hi,
+ FIXME("(%s, %s, %p) stub!\n", debugstr_w(servername),
+ debugstr_w(domainname), bufptr);
+ return ERROR_NO_SUCH_DOMAIN;
+}
Please use 4 spaces indentation as the rest of the file.
Christian
Le 27/04/2013 14:05, Ruslan Kabatsayev a écrit :
Hello,
This patch adds a s
Le 24/04/2013 23:35, Christian Costa a écrit :
Le 24/04/2013 20:10, James Eder a écrit :
On Wed, Apr 24, 2013 at 6:58 AM, Christian Costa
mailto:titan.co...@gmail.com>> wrote:
Hi James,
That would be better to change the trace at the beginning by
FIXME( "(%p, %d):
Le 24/04/2013 20:10, James Eder a écrit :
On Wed, Apr 24, 2013 at 6:58 AM, Christian Costa
mailto:titan.co...@gmail.com>> wrote:
Hi James,
That would be better to change the trace at the beginning by
FIXME( "(%p, %d): semi-stub\n", info, size ); or
2013/4/24 James Eder
> This version should either pass or skip on W2KPROSP4.
> ---
> dlls/kernel32/cpu.c | 23 ++-
> dlls/psapi/tests/psapi_main.c | 36
> 2 files changed, 54 insertions(+), 5 deletions(-)
>
> diff --git a/dlls/ke
2013/4/23 Rico Schüller
> On 22.04.2013 23:08, Christian Costa wrote:
>
>> +typedef struct {
>> +DWORD bc2Size;
>> +DWORD bc2Width;
>> +DWORD bc2Height;
>> +WORD bc2Planes;
>> +WORD bc2BitCount;
>> +DWORD bc2Compression;
&
as BITMAPINFOHEADER.
Is there still anything wrong ?
Christian
2013/4/22 Alexandre Julliard
> Christian Costa writes:
>
> > +if (header_size == sizeof(BITMAPINFOHEADER))
> > +{
> > +BITMAPINFOHEADER *header = (BITMAPINFOHEADER*)*data;
> > +UL
Well, 'grep "if(" * -r | wc -l' and 'grep "if (" * -r | wc -l'. :)
2013/1/22 Bruno Jesus <00cp...@gmail.com>:
> Out of curiosity can you explain the shell wizardry you used to get the
> stats?
>
> Thanks,
> Bruno
>
>
> On Tu
2013/1/22 :
> Hi,
>
> Ken Thomases wrote:
>>> +if(success != kIOReturnSuccess)
>>Another style nitpick: please put a space between "if" and the condition.
>> That applies to the "if(count2)" above, too.
>
> I find this over the top. Where is the rule?
> Andrew Eikum's mmdevap
013/1/21 Dmitry Timoshkov :
> Christian Costa wrote:
>
>
>> cpp_quote("DEFINE_GUID(CLSID_WICBmpDecoder,
>> 0x6b462062,0x7cbf,0x400d,0x9f,0xdb,0x81,0x3d,0xd1,0x0f,0x27,0x78);")
>> +cpp_quote("DEFINE_GUID(CLSID_WICDibDecoder,
>> 0x6b462062,0x7cbf,0
2013/1/18 :
> Hi,
>
> Although I wouldn't mind inclusion of Christian's F0/F7 patch in upcoming Wine
> (barring decent formatting),
Well, it's not a formatting problem. It was intentional. The Wine
preferred style is 4 spaces indentation and no tab
but I didn't know that when I wrote the alsa mid
2013/1/15 :
> Christian costa wrote:
>>> But I don't know whether there's some harmless general SysEx that we
>>> can send out. Maybe some MIDI guru could suggest some?
>>What do you by harmless ? For what ? A midi HW device connected to the midi
>>
Hi,
2013/1/15 :
> Hi,
>
> Christian costa wrote:
>>+lpNewData[lpMidiHdr->dwBufferLength + len_add] = 0xF7;
> Here you're using spaces only, whereas the surrounding code uses TAB8.
It was not intended for submission. If I submit a patch, I will
removed all
Le 14/01/2013 19:04, Christian Costa a écrit :
2013/1/14 Christian Costa :
2013/1/14 :
Hi,
Christian Costa wrote:
I took a look at the
alsa code and this code simply does not do what it is supposed to.
I also looked at it today and noted those bogus lines you quote. Needs
a patch (+ fix
2013/1/14 Christian Costa :
> 2013/1/14 :
>> Hi,
>>
>> Christian Costa wrote:
>>>I took a look at the
>>>alsa code and this code simply does not do what it is supposed to.
>> I also looked at it today and noted those bogus lines you quote. Needs
>
2013/1/14 :
> Hi,
>
> Christian Costa wrote:
>>I took a look at the
>>alsa code and this code simply does not do what it is supposed to.
> I also looked at it today and noted those bogus lines you quote. Needs
> a patch (+ fix memory leak).
I will take a look at
> Still, I'm not persuaded that your patch is at the right place.
> I believe the midi* functions should be tiny wrappers around MODM_*
> messages, same for the wave* functions. Every time I see somebody
> attempt to violate this 1:1 mapping, I'm suspicious. Perhaps the
> logic that you're adding
2013/1/11 Rico Schüller
> On 11.01.2013 09:40, Christian Costa wrote:
>
>> static HRESULT WINAPI ID3DXFileDataImpl_Unlock(**ID3DXFileData *iface)
>> {
>> -FIXME("(%p)->(): stub\n", iface);
>> +TRACE("(%p)->()\n", iface
2013/1/10 Johannes Kroll
> On Thu, 10 Jan 2013 12:04:02 +0100
> Christian Costa wrote:
>
> > In your code you stop checking F7 just before the last byte (until
> > position lpMidiOutHdr->dwBufferLength-2);
> > You can check the last byte as well. This
2013/1/10 Johannes Kroll
> On Thu, 10 Jan 2013 01:05:28 +0100
> Johannes Kroll wrote:
>
> > On Thu, 10 Jan 2013 00:38:06 +0100
> > Christian Costa wrote:
> >
> >
> > > After a better look the changes seem correct.
> > > The condition i < l
Le 09/01/2013 19:32, Johannes Kroll a écrit :
On Wed, 9 Jan 2013 19:04:03 +0100
Christian Costa wrote:
I would say consistency would be 2 spaces or none.
You are, of course, entitled to your opinion.
If my opinion does not matter as well as code style practices we can
found in wine
that
2013/1/9 Johannes Kroll
> On Wed, 9 Jan 2013 16:10:18 +0100
> Christian Costa wrote:
>
> > 2013/1/9 Johannes Kroll
> >
> > > On Wed, 09 Jan 2013 10:19:54 +0100
> > > Christian Costa wrote:
> > >
> > > > Le 09/01/2013 04:26, Johannes
Le 09/01/2013 04:26, Johannes Kroll a écrit :
Hi,
On Wed, 09 Jan 2013 03:55:25 +0100
Christian Costa wrote:
Hi,
Please be consistent when using space. 1 space before and after
operators (<, ==, =, ...).
spaces inserted. HTH.
J.
That's better. You forgot some occurences in the
Le 09/01/2013 03:12, Johannes Kroll a écrit :
While using the KORG Kontrol Editor software [1] under Wine to configure
my nanoPAD2 MIDI controller, I noticed that uploading parameters to the
hardware doesn't work. The program displays a timeout message.
The program relies on the MIDI driver to r
Le 30/11/2012 23:38, Alexandre Julliard a écrit :
Christian Costa writes:
Ok. I will use WINE_TRACE instead. So that would be better to remove
-v
option and turn all printf
dependant of this option to WINE_TRACE, right ?
Of course not. Debug options are for debugging the app, -v is for
Le 30/11/2012 23:12, Alexandre Julliard a écrit :
Christian Costa writes:
Le 30/11/2012 11:58, Alexandre Julliard a écrit :
Christian Costa writes:
@@ -713,9 +716,16 @@ int wmain( int argc, WCHAR *argv[] )
argv[--argc] = NULL
Le 30/11/2012 11:58, Alexandre Julliard a écrit :
Christian Costa writes:
@@ -713,9 +716,16 @@ int wmain( int argc, WCHAR *argv[] )
argv[--argc] = NULL;
}
}
-return extract_cabinet( buffer );
+WINE_MESSAGE("Extracting file(s)
> -BOOL __cdecl FDIIsCabinet(
>> - HFDIhfdi,
>> - INT_PTR hf,
>> - PFDICABINETINFO pfdici)
>> +BOOL __cdecl FDIIsCabinet(HFDI hfdi, INT_PTR hf, PFDICABINETINFO pfdici)
>> {
>> BOOL rv;
>> FDI_Int *fdi = get_fdi_ptr( hfdi );
>> @@ -749,13 +746,13 @@ BO
+ * write_console_input
+ *
+ * Helper function for bare_console_fetch_input calling WriteConsoleInput
+ * The handle passed to ReadConsole etc may not have been opened for write,
+ * and hence the calls to WriteConsoleInput may fail. This routine handles such
+ * a failure, and retries the write
Le 16/11/2012 00:24, Michael Stefaniuc a écrit :
Hello Christian,
On 11/15/2012 09:43 AM, Christian Costa wrote:
Fixes bug 32185.
---
dlls/amstream/mediastreamfilter.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/dlls/amstream/mediastreamfilter.c
b/dlls/amstream
Le 13/11/2012 23:07, Marvin a écrit :
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDet
2012/11/9 Alexandre Julliard
> Christian Costa writes:
>
> > +SetLastError(0xdeadbeef);
> > +n = MapWindowPoints(wnd, NULL, NULL, 0);
> > +err = GetLastError();
> > +ok(n == ((window_rect.top << 16) | window_rect.left), "Got %x (%d,
>
> >
> >
> > Henri said the other. It seems there is no consensus. ;)
> Of course there is consensus. The consensus is:
> - "It depends on the situation"
> - "There are acceptable naming conventions"
> - "IDirectMusicLoaderImpl_IDirectMusicLoader_QueryInterface is not one
> of the acceptable solutio
> >>> I was just saying removing the interface name was not a good thing imo
> >>> or am I missing something?
> >> Right, the interface name needs to be there as it matches the COBJMACROS
> >> name. Basically the C macro with a prefix.
> > Why? If you really want to keep interface name the better w
>
>
>
>
>> I was just saying removing the interface name was not a good thing imo
>>> or am I missing something?
>>>
>> Right, the interface name needs to be there as it matches the COBJMACROS
>> name. Basically the C macro with a prefix.
>>
> Why? If you really want to keep interface name the bet
2012/11/8 Michael Stefaniuc
> On 11/08/2012 01:13 PM, Christian Costa wrote:
> >
> >
> > 2012/11/8 Henri Verbeet mailto:hverb...@gmail.com>>
> >
> > On 8 November 2012 00:22, Michael Stefaniuc > <mailto:mstef...@redhat.com>> wrote:
&g
2012/11/8 Henri Verbeet
> On 8 November 2012 00:22, Michael Stefaniuc wrote:
> > But using just the capitalized letters from the name of the COM class as
> > a prefix and skipping the "Impl" would be in hindsight the better
> > standard. There are still 170+ COM interfaces to clean up which is a
2012/11/8 Michael Stefaniuc
> On 11/07/2012 06:40 PM, Christian Costa wrote:
> > 2012/11/7 Michael Stefaniuc > <mailto:mstef...@redhat.com>>
> > On 11/07/2012 02:50 PM, Christian Costa wrote:
> > > I didn't write this code and I don
2012/11/7 Michael Stefaniuc
> On 11/07/2012 02:50 PM, Christian Costa wrote:
> >
> >
> > 2012/11/7 Nikolay Sivov bungleh...@gmail.com>>
> >
> > On 11/7/2012 01:05, Christian Costa wrote:
> >
> > Le 06/11/2012 22:38, Michael Stefaniu
2012/11/7 Nikolay Sivov
> On 11/7/2012 01:05, Christian Costa wrote:
>
>> Le 06/11/2012 22:38, Michael Stefaniuc a écrit :
>>
>>> On 11/06/2012 08:51 PM, Christian Costa wrote:
>>>
>>>> Le 06/11/2012 20:26, Nikolay Sivov a écrit :
>>>>
Le 06/11/2012 22:38, Michael Stefaniuc a écrit :
On 11/06/2012 08:51 PM, Christian Costa wrote:
Le 06/11/2012 20:26, Nikolay Sivov a écrit :
On 11/6/2012 20:47, Christian Costa wrote:
What I also meant is these names are redundant, something like
directmusicloader_AddRef() is enough, of course
Le 06/11/2012 20:26, Nikolay Sivov a écrit :
On 11/6/2012 20:47, Christian Costa wrote:
---
dlls/dmloader/dmloader_private.h | 16 +++---
dlls/dmloader/loader.c | 107
+++---
2 files changed, 73 insertions(+), 50 deletions(-)
diff --git a/dlls
Thanks for spotting. I will send an additional patch for that or do an
update.
2012/11/6 Nikolay Sivov
> On 11/6/2012 14:09, Alistair Leslie-Hughes wrote:
>
>> Hi,
>>
>> On 6/11/2012 7:05 PM, Christian Costa wrote:
>>
>>static HR
2012/10/31 Dmitry Timoshkov
> Christian Costa wrote:
>
> > Based ont a patch of Rico Schuller.
>
> I'd suggest to make sure that the test with appropriate todo_wine
> statements is accepted first,
It it can help the process, I'll do that.
> and only then s
2012/10/30 Hans Leidekker
> On Tue, 2012-10-30 at 09:50 +0100, Christian Costa wrote:
> > Just by curiosity. What the difference with strncmpW?
>
> strncmp tests the first string for null termination. You should really
> determine that by yourself though :-)
>
> >
Le 30/10/2012 09:18, Hans Leidekker a écrit :
On Tue, 2012-10-30 at 08:42 +0100, Christian Costa wrote:
This is almost the same as your first try. You're testing a trivial
case only - ASCII range.
I feel like it should behave more like memcmp for case insensitive
comparison,
that&#
Le 30/10/2012 08:21, Nikolay Sivov a écrit :
On 10/30/2012 01:43, Christian Costa wrote:
Try 2:
- Don't use CompareStringEx.
- Add tests
---
dlls/kernel32/kernel32.spec |1 +
dlls/kernel32/locale.c | 28
dlls/kernel32/tests/locale.c |
Le 29/10/2012 06:57, Nikolay Sivov a écrit :
On 10/29/2012 00:53, Christian Costa wrote:
---
dlls/kernel32/kernel32.spec |1 +
dlls/kernel32/locale.c |8
2 files changed, 9 insertions(+)
diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec
index
>
> pixel_format = get_format_info(src_desc.Format);
> -if (pixel_format->type != FORMAT_ARGB)
> -{
> -FIXME("Unsupported pixel format %#x\n", src_desc.Format);
> -return E_NOTIMPL;
> -}
> +if (pixel_format->type == FORMAT_UNKNOWN) return E_NOTIMPL;
>
>
Doesn'
2012/10/25 Nikolay Sivov
> On 10/25/2012 10:34, Christian Costa wrote:
>
>>
>> +
>> +static HRESULT WINAPI ID3DXFileDataImpl_Create(**IDirectXFileObject
>> *dxfile_object, ID3DXFileData **ret_iface)
>> +{
>> +ID3DXFileDataImpl *object;
>
My bad, I updated the wrong patch.
2012/10/25 Nikolay Sivov
> On 10/25/2012 10:34, Christian Costa wrote:
>
>> ---
>> dlls/d3dx9_36/xfile.c | 172 ++**
>> ++-
>> 1 file changed, 170 insertions(+), 2 deletions(-)
&g
2012/10/25 Nikolay Sivov
> On 10/25/2012 10:34, Christian Costa wrote:
>
>> ---
>> dlls/d3dx9_36/xfile.c | 14 --
>> 1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/dlls/d3dx9_36/xfile.c b/dlls/d3dx9_36/xfile.c
>> i
Le 24/10/2012 19:39, Nikolay Sivov a écrit :
On 10/24/2012 19:02, Rico Schüller wrote:
On 24.10.2012 16:33, Dmitry Timoshkov wrote:
Christian Costa wrote:
+static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile
*iface,
REFIID riid, void **ret_iface)
+{
+TRACE("(%p)->(%
Le 24/10/2012 17:53, Dmitry Timoshkov a écrit :
Christian Costa wrote:
Well, that would have been better to spot this *much* earlier.
More generally about coding style or rules, that would be *much* better to
write a wiki page about this and point to it
along with code style comments. I
2012/10/24 Dmitry Timoshkov
> Christian Costa wrote:
>
> > > > +static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
> > > REFIID riid, void **ret_iface)
> > > > +{
> > > > +TRACE("(%p)->(%s, %p)\n", ifa
2012/10/24 Nikolay Sivov
> On 10/24/2012 11:33, Christian Costa wrote:
>
>
>
> 2012/10/24 Dmitry Timoshkov
>
>> Christian Costa wrote:
>>
>> > BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt )
>> > {
>> > +
1 - 100 of 430 matches
Mail list logo
