Re: [PATCH wayland-protocols] Add the wl_drm protocol

2017-11-14 Thread Emil Velikov
On 14 November 2017 at 08:18, Pekka Paalanen wrote: > On Mon, 13 Nov 2017 16:27:24 + > Emil Velikov wrote: > >> On 13 November 2017 at 14:52, Emil Velikov wrote: >> > On 13 November 2017 at 14:21, Daniel Stone wrote: >> >> Hi Emil, >> >>

Re: [PATCH wayland-protocols] Add the wl_drm protocol

2017-11-15 Thread Emil Velikov
Hi all, On 2 November 2017 at 17:09, Emil Velikov wrote: > From: Emil Velikov > > Import latest version (v2) of the protocol from Mesa. > > From the README: > > Warning! > The goal is to share the protocol file across Mesa and other low-level > components graph

Re: [RFC PATCH xserver] xwayland: Fix non-argb cursor conversion

2017-11-16 Thread Emil Velikov
uld align after the division instead of the other way around. As width is != 32 the code will provide larger than needed stride, which seems to be exactly what the commit summary says. One might mention exactly what's happening the commit message, since it's not immediately obvious. With the

Re: [PATCH weston 01/12] shared: Add timespec_is_zero helper

2017-11-24 Thread Emil Velikov
Hi Alexandros, On 16 November 2017 at 16:20, Alexandros Frantzis wrote: > +ZUC_TEST(timespec_test, timespec_is_zero) > +{ > + struct timespec zero = { 0 }; > + struct timespec non_zero_sec = { 1, 0 }; > + struct timespec non_zero_nsec = { 0, 1 }; > + The standard (be that POSIX

Re: [PATCH weston 01/12] shared: Add timespec_is_zero helper

2017-11-27 Thread Emil Velikov
On 27 November 2017 at 08:58, Alexandros Frantzis wrote: > On Mon, Nov 27, 2017 at 10:20:35AM +0200, Pekka Paalanen wrote: >> On Fri, 24 Nov 2017 18:36:43 +0000 >> Emil Velikov wrote: >> >> > Hi Alexandros, >> > >> > On 16 Novembe

Re: [PATCH weston 1/5] gl-renderer: save OpenGL version in renderer context

2017-12-04 Thread Emil Velikov
Hi Arnaud, On 29 November 2017 at 14:25, Arnaud Vrac wrote: > From: Arnaud Vrac > Here I'd mention why we care about the version. Esp. since the helper itself looks quitie strange. > Signed-off-by: Arnaud Vrac > --- > libweston/gl-renderer.c | 26 ++ > 1 file changed,

Re: [PATCH weston 4/5] gl-renderer: fix pixel format used in texture uploads when using R/RG textures

2017-12-04 Thread Emil Velikov
this requirement, as some drivers will fail with the > current code. > AFAICT the patch is spot on. Trivial suggestion below: Reviewed-by: Emil Velikov I'd suggest using something like the following. A reference to the offending code is always nice, plus CC-ing the author gives

Re: [PATCH weston 3/5] gl-renderer: always enable unpack subimage and RG textures in ES3 contexts

2017-12-04 Thread Emil Velikov
s are supported. > Reviewed-by: Emil Velikov Out of curiosity: did you notice a ES 3.x driver that doesn't expose these in the extensions string? -Emil ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 5/5] gl-renderer: use correct pixel shader for NV12 format uploaded to RG texture

2017-12-04 Thread Emil Velikov
On 29 November 2017 at 14:25, Arnaud Vrac wrote: > Signed-off-by: Arnaud Vrac Please mention how you've spotted and/or verified this. I'm ~90% this is correct, although I would check with the author. Vincent, can you double check the patch/series [1]? Fixes: 00a03d2f724 ("gl-renderer: add supp

Re: [PATCH wayland] scanner: Add autoconf macro to check for the proper scanner

2017-12-05 Thread Emil Velikov
On 4 December 2017 at 21:47, Daniel Stone wrote: > Jussi, Tomek, Emil, > > On 18 August 2017 at 10:36, Quentin Glidic > wrote: >> On 8/18/17 11:30 AM, Quentin Glidic wrote: >>> Projects have been using various ways to check for the wayland-scanner, >>> mostly based on their developper own use cas

[PATCH weston] libweston: drop return type from ::query_dmabuf_{formats, modifiers}

2017-12-05 Thread Emil Velikov
From: Emil Velikov Nobody checks for the bool returned by these functions. At the same time: a) the functions set the respective num_foo to zero on error and b) callers honour that variable. Just drop the return type - it's useless. Note: this is an ABI break. Signed-off-by: Emil Ve

Re: [PATCH wayland-protocols 3/3] Remove autotools build system

2017-12-05 Thread Emil Velikov
On 11 October 2017 at 10:22, Jonas Ådahl wrote: >> >> Besides, wayland-protocol doesn't compile/link anything at all, I'm not >> sure what meson buys us here (other than being trendy). > > It does now, as part of the test suite. FWIW, I first opened Makefile.am > and started typing when trying to

Re: Building Wayland/weston with a LFS/BLFS minimum packagelist?

2017-12-07 Thread Emil Velikov
On 7 December 2017 at 03:20, scsijon wrote: > Sorry, but i've read a lot of pages on your site and the git repositories > and can't find an answer or hint of one anywhere. > > Does someone have a minimum packageset/packagelist needed, anywhere in their > files to build the Linux that Wayland/Westo

Re: [PATCH v2 weston 1/3] gl-renderer: save OpenGL version in renderer context

2017-12-12 Thread Emil Velikov
Hi Arnaud, On 11 December 2017 at 12:18, Arnaud Vrac wrote: > This will allow to make some assumptions in further patches when GLES3 > is available. > There's a couple of nitpicks below, but regardless if you opt for them or not the series is: Reviewed-by: Emil Velikov > Sign

Re: [PATCH v2] configure.ac: use AC_HEADER_MAJOR to detect major()/minor()

2017-12-12 Thread Emil Velikov
On 12 December 2017 at 08:28, Pekka Paalanen wrote: > On Mon, 11 Dec 2017 16:16:47 +0200 > Pekka Paalanen wrote: > >> On Wed, 31 May 2017 22:17:50 +0100 >> Sergei Trofimovich wrote: >> >> > This change slightly updates c4d7f66c12853b9575366dd9f4a7960ec5694934 >> > which added inclusion. >> > >>

Re: [PATCH v2 libinput] FreeBSD portability fixes

2017-12-12 Thread Emil Velikov
On 11 December 2017 at 04:21, Peter Hutterer wrote: >> - ptrace(PTRACE_CONT, NULL, NULL); >> + ptrace(PTRACE_CONT, ppid, NULL, 0); > > split this one out please, I'd rather not have it hidden in a bsd-suppport > patch, thanks. > Was going to ask - the PTRA

Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library

2017-12-12 Thread Emil Velikov
Hi Daniel, On 13 November 2017 at 14:06, Daniel Stone wrote: > Hi Emil, > > On 8 November 2017 at 14:06, Emil Velikov wrote: >> On 10 October 2017 at 14:43, Emil Velikov wrote: >>> In summary - we want the user facing library to live in Wayland with >>> v

Re: [PATCH v2] configure.ac: use AC_HEADER_MAJOR to detect major()/minor()

2017-12-13 Thread Emil Velikov
On 13 December 2017 at 07:58, Pekka Paalanen wrote: > On Tue, 12 Dec 2017 15:41:52 + > Emil Velikov wrote: > >> On 12 December 2017 at 08:28, Pekka Paalanen wrote: >> > On Mon, 11 Dec 2017 16:16:47 +0200 >> > Pekka Paalanen wrote: >> > >> &g

[PATCH wayland] wayland-egl: rename wl_egl_window::private to driver_private

2017-12-13 Thread Emil Velikov
From: Emil Velikov private is a reserved keyword in C++. Thus if one is to have a backend driver written in said language build will fail as below: .../wayland-egl-backend.h:56:8: expected unqualified-id before ‘private’ Rename it to driver_private and update the test. NOTE: version bump is

Re: [PATCH wayland v2 0/8] Import wayland-egl frontend library

2017-12-13 Thread Emil Velikov
On 12 December 2017 at 20:48, Arnaud Vrac wrote: > Hi Emil, > > On Tue, Oct 10, 2017 at 3:43 PM, Emil Velikov > wrote: >> Hi all, >> >> Here is a retake of the RFC as originally seen here [1]. >> >> In summary - we want the user facing library to l

Re: [PATCH weston] configure: fix sys/sysmacros.h check

2017-12-18 Thread Emil Velikov
t_rdev), > > The issue has been discussed earlier on > https://lists.gnu.org/archive/html/autoconf/2016-09/msg00013.html > > Work around the issue by causing the warning to trigger a build failure > inside AC_HEADER_MAJOR test, so that we get MAJOR_IN_SYSMACROS defined. > > Cc

Re: wlroots whitepaper available

2017-12-28 Thread Emil Velikov
On 28 December 2017 at 18:05, Drew DeVault wrote: > I represent the Sway wayland compositor. As some of you might know, > we've been working for some months on a new library for Wayland > compositor development. Today, Sway is based on the wlc libray, which > provides an abstraction on top of DRM,

Re: wlroots whitepaper available

2017-12-28 Thread Emil Velikov
On 28 December 2017 at 20:50, Drew DeVault wrote: > On 2017-12-28 8:38 PM, Emil Velikov wrote: >> On 28 December 2017 at 18:05, Drew DeVault wrote: >> Surely you are familiar that weston provides libweston with somewhat >> similar functionality, right? >> >> Sin

Re: Planning for another Wayland release

2018-01-15 Thread Emil Velikov
Hi gents, On 12 January 2018 at 22:51, Derek Foreman wrote: > Hi Daniel, > > > On 2018-01-12 04:00 AM, Daniel Stone wrote: >> >> Hi Bryce, >> >> On 12 January 2018 at 00:31, Bryce Harrington >> wrote: >>> >>> Is there interest in another release at this time? It's been about a >>> 1/2 year sinc

Re: [PATCH] linux-dmabuf: send deprecated format events

2018-01-17 Thread Emil Velikov
XT_texture_rg extension is supported, YUYV, NV12, YUV420, and > YUV444. > > Signed-off-by: Philipp Zabel > > diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c > index abf556f0..ee31a86d 100644 > --- a/libweston/gl-renderer.c > +++ b/libweston/gl-renderer.c > @@ -2088,14 +2088,23 @@ gl

Re: Planning for another Wayland release

2018-01-17 Thread Emil Velikov
On 16 January 2018 at 22:10, Daniel Stone wrote: > Hey Bryce, > > On 12 January 2018 at 22:51, Derek Foreman wrote: >> On 2018-01-12 04:00 AM, Daniel Stone wrote: >>> I did a clearout of the review queue last month, but that's not yet >>> complete, and I'd like someone to have a more structured l

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2018-01-22 Thread Emil Velikov
; >>>> On 2017-08-18 07:41 AM, Pekka Paalanen wrote: >>>>> >>>>> On Fri, 28 Jul 2017 14:06:23 +0100 >>>>> Emil Velikov wrote: >>>>> >>>>>> >>>>>> On 27 July 2017 at 14:01, Pekka Paalanen wrote: >

Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-22 Thread Emil Velikov
On 22 August 2017 at 14:02, Emil Velikov wrote: > On 18 August 2017 at 13:05, Pekka Paalanen wrote: > >>> > >>> > The exported configuration would then be: >>> > LOCAL_INTERFACE_DECL=extern >>> > EXTERN_INTERFACE_DECL=extern >>> &g

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

2018-01-22 Thread Emil Velikov
On 22 January 2018 at 15:09, Pekka Paalanen wrote: > On Mon, 22 Jan 2018 14:46:15 + > Emil Velikov wrote: > >> On 19 January 2018 at 15:49, Derek Foreman wrote: >> > On 2018-01-19 01:22 AM, Jonas Ådahl wrote: >> >> >> >> On Thu, Jan 18

Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-24 Thread Emil Velikov
On 24 January 2018 at 18:20, Derek Foreman wrote: > On 2018-01-22 09:30 AM, Emil Velikov wrote: >> >> On 22 August 2017 at 14:02, Emil Velikov wrote: >>> >>> On 18 August 2017 at 13:05, Pekka Paalanen wrote: >>> >>>>>> >>>>

Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-25 Thread Emil Velikov
On 25 January 2018 at 02:01, Jonas Ådahl wrote: > On Wed, Jan 24, 2018 at 07:15:09PM +0000, Emil Velikov wrote: >> On 24 January 2018 at 18:20, Derek Foreman wrote: >> > On 2018-01-22 09:30 AM, Emil Velikov wrote: >> >> >> >> On 22 August 2017 at 14:02

Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-26 Thread Emil Velikov
On 26 January 2018 at 02:44, Jonas Ådahl wrote: > On Thu, Jan 25, 2018 at 05:56:45PM +0000, Emil Velikov wrote: >> On 25 January 2018 at 02:01, Jonas Ådahl wrote: >> > On Wed, Jan 24, 2018 at 07:15:09PM +, Emil Velikov wrote: >> >> On 24 January 2018

Re: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

2018-02-13 Thread Emil Velikov
On 13 February 2018 at 15:11, Daniel Stone wrote: > Hi, > > On 13 February 2018 at 15:00, Pekka Paalanen wrote: >> On Thu, 8 Feb 2018 13:53:54 + >> "Ucan, Emre (ADITG/ESB)" wrote: >>> Yes I saw a similar problem when I tested previous ivi patches. >>> I run make clean & make & make check. Th

Re: [PATCH weston 1/4] ivi-shell: change layer visibility to bool

2018-02-15 Thread Emil Velikov
On 13 February 2018 at 17:46, Daniel Stone wrote: > Hi Emil, > > On 13 February 2018 at 16:37, Emil Velikov wrote: >> The following two questions come to mind: >> - app bugs - using threads? ivi-shell-user-interface.c mentions >> pthread, but haven't looked clo

[PATCH wayland 1/6] Revert "wayland-egl: rename wl_egl_window::private to driver_private"

2018-02-15 Thread Emil Velikov
This reverts commit 9fa60983b5799be62b9d88a4059f4d0038d7c80d. The commit preserves the ABI, although breaks the API. This is fine for most cases - building up-to date components, or shipping binary-only drivers. Yet it breaks when using old, released, Mesa alongside new wayland-egl. A simpler and

[PATCH wayland 3/6] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-02-15 Thread Emil Velikov
This reverts commit 85cb5ed64aa8246f4da93fc5b76dfc34096bf803. It seems like we've misread the existing code - the DSO name can be propagated via the build-system. The one available in the script was a simple fall-back. Cc: Daniel Stone --- Makefile.am | 1 - egl/wayland-egl-sy

[PATCH wayland 5/6] wayland-egl: enhance the symbol test

2018-02-15 Thread Emil Velikov
From: Emil Velikov The current test had a few fall-outs: - it was checking only for T (.text) symbols - did not consider symbol removal Fix that by fetching all the symbols and doing a bidirectional check - for added and removed symbols. Error out with informative message for each case

[PATCH wayland 6/6] wayland-egl: bump the version number to 18.1.0

2018-02-15 Thread Emil Velikov
From: Emil Velikov Seems like I was overoptimistic with my earlier assumption, namely: "... 17.3.x should be the last version that ships the library." Mesa 18.0.0 and its wayland-egl is about to be released any time soon, so bump the number since it must no be smaller. As soon a

[PATCH wayland 4/6] wayland-egl: fail the symbol check if lib is missing

2018-02-15 Thread Emil Velikov
From: Emil Velikov Based on a similar patch (in Mesa) by Eric Engestrom. Cc: Eric Engestrom Signed-off-by: Emil Velikov --- egl/wayland-egl-symbols-check | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/egl/wayland-egl-symbols-check b/egl/wayland-egl-symbols

[PATCH wayland 2/6] wayland-egl: make wayland-egl-backend.h C++ safe

2018-02-15 Thread Emil Velikov
From: Emil Velikov private is a reserved keyworkd in C++. Thus to make things work, we should use something else - wl_egl_window::driver_private. Make sure to do so only for C++ contexts, or otherwise it will break the API - leading to build failures when used alongside existing Mesa. Cc

[RFC weston] gl-renderer: make use of linux_dmabuf_buffer_get_user_data()

2018-02-15 Thread Emil Velikov
From: Emil Velikov ... to get the user_data. Like everywhere else through weston. Signed-off-by: Emil Velikov --- Some ancient patch, that I had locally. It should be fine to land as-is, although it brings an interesting question - should one keep struct linux_dmabuf_buffer private or not

Re: [PATCH wayland 2/6] wayland-egl: make wayland-egl-backend.h C++ safe

2018-02-16 Thread Emil Velikov
On 15 February 2018 at 23:12, Derek Foreman wrote: > On 2018-02-15 12:50 PM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> private is a reserved keyworkd in C++. Thus to make things work, we >> should use something else - wl_egl_window::driver_private. &g

Re: [PATCH wayland 2/6] wayland-egl: make wayland-egl-backend.h C++ safe

2018-02-16 Thread Emil Velikov
On 16 February 2018 at 10:49, Daniel Stone wrote: > Hi Emil, > > On 16 February 2018 at 10:40, Emil Velikov wrote: >> On 15 February 2018 at 23:12, Derek Foreman wrote: >>> Maybe it's just me, but having different names for the same variable for C >>> vs

Re: [PATCH wayland v2 4/4] build: remove white space in -uninstalled.pc.in files

2018-02-16 Thread Emil Velikov
On 21 February 2017 at 16:14, Emil Velikov wrote: > From: Emil Velikov > > v2: Rebase, address wayland-client-uninstalled > > Signed-off-by: Emil Velikov > Reviewed-by: Derek Foreman (v1) Doesn't seems like this patch has landed. Can anyone do the honours? https://pa

[PATCH wayland 2/4] build: use public-code when using the local wayland-scanner

2018-02-16 Thread Emil Velikov
From: Emil Velikov The core wayland interfaces are public, via the libwayland-server and libwayland-client DSOs. Hence use "public-code" cmdline option, instead of the deprecated code". As the host wayland-scanner may not know about the new option, use the legacy "code&qu

[PATCH wayland 1/4] scanner: introduce "public-code" and "private-code"

2018-02-16 Thread Emil Velikov
From: Emil Velikov The options are used to indicate how the code will be used - will it be public, as part of a DSO or private. In nearly every instance, people want to use the latter. One noticeable exception is the wayland libraries. They provide the base marshalling protocol that everyone

[PATCH wayland 3/4] scanner: make use of __has_attribute()

2018-02-16 Thread Emil Velikov
From: Emil Velikov A more generic way to evaluating various attributes, __has_attribute is available with gcc, clang, even the Oracle/Sun compiler. Signed-off-by: Emil Velikov --- src/scanner.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/scanner.c b/src

[PATCH wayland 4/4] tests: add code, public-code and private-code tests

2018-02-16 Thread Emil Velikov
From: Emil Velikov First one is deprecated in favour of the second option. The latter is newly introduced and annotates the generated symbols accordingly. Signed-off-by: Emil Velikov --- Makefile.am | 4 ++- tests/data/small-private-code.c | 71

Re: [PATCH wayland 2/6] wayland-egl: make wayland-egl-backend.h C++ safe

2018-02-16 Thread Emil Velikov
On 16 February 2018 at 14:22, Arnaud Vrac wrote: > On Fri, Feb 16, 2018 at 2:53 PM, Emil Velikov > wrote: >> On 16 February 2018 at 10:49, Daniel Stone wrote: >>> Hi Emil, >>> >>> On 16 February 2018 at 10:40, Emil Velikov wrote: >>>>

Re: [RFC wayland] wayland-server: Finally remove deprecated struct wl_buffer definition

2018-02-16 Thread Emil Velikov
On 16 February 2018 at 16:54, Derek Foreman wrote: > commit d94a8722cb29d8b897672be66ff3c9ff79eab6fe > warned this was coming, back in 2013. > > I've seen libraries that have wayland client and server using functions > in the same file. Since struct wl_buffer still exists as an opaque > entity in

Re: [RFC wayland] wayland-server: Finally remove deprecated struct wl_buffer definition

2018-02-16 Thread Emil Velikov
On 16 February 2018 at 18:24, Derek Foreman wrote: > On 2018-02-16 11:18 AM, Emil Velikov wrote: >> >> On 16 February 2018 at 16:54, Derek Foreman >> wrote: >>> >>> commit d94a8722cb29d8b897672be66ff3c9ff79eab6fe >>> warned this was coming, bac

Re: [RFC wayland] wayland-server: Finally remove deprecated struct wl_buffer definition

2018-02-16 Thread Emil Velikov
On 16 February 2018 at 20:22, Derek Foreman wrote: > On 2018-02-16 12:58 PM, Emil Velikov wrote: >> >> On 16 February 2018 at 18:24, Derek Foreman >> wrote: >>> >>> On 2018-02-16 11:18 AM, Emil Velikov wrote: >>>> >>>&g

Re: [PATCH wayland 4/4] tests: add code, public-code and private-code tests

2018-02-22 Thread Emil Velikov
Hi Pekka, Thanks for having a look! On 22 February 2018 at 10:26, Pekka Paalanen wrote: >> +# The existing "code" must produce result identical to "public-code" >> +generate_and_compare "code" "small.xml" "small-public-code.c" >> +generate_and_compare "public-code" "small.xml" "small-public-cod

[PATCH wayland v2 4/4] tests: add code, public-code and private-code tests

2018-02-22 Thread Emil Velikov
From: Emil Velikov First one is deprecated in favour of the second option. The latter is newly introduced and annotates the generated symbols accordingly. v2: Don't introduce small-public-code.c - reuse small-code.c (Pekka) Cc: Pekka Paalanen Signed-off-by: Emil Velikov --- Makefi

Re: [RFC wayland-protocols] Add contribution guidelines for desktop extensions

2018-02-22 Thread Emil Velikov
Hi Pekka, On 22 February 2018 at 08:32, Pekka Paalanen wrote: > +Once there is sufficient cross-desktop support for a proposal, the Wayland > +maintainers can accept the extension into wayland-protocols. > + Might be worth defining "sufficient" in a bullet point somewhere. Say, "more than 1 of t

[PATCH wayland] wayland-egl: use correct `nm` path when cross-compiling

2018-02-23 Thread Emil Velikov
From: Emil Velikov Inspired by Heiko Becker and Eric's work in libdrm and Mesa respectively. Cc: Eric Engestrom Signed-off-by: Emil Velikov --- configure.ac | 1 + egl/wayland-egl-symbols-check | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --

Re: [PATCH wayland] scanner: Fix broken private-code generation

2018-02-23 Thread Emil Velikov
On 23 February 2018 at 22:24, Derek Foreman wrote: > Missing a closing bracket. > Eek, that's a embarasing. Reviewed-by: Emil Velikov We might want to tweak the existing infra to check that, bonus points if we also check the headers actually safe for inclusion in C and C++ source

[PATCH weston] build: honour libinput header location

2018-02-27 Thread Emil Velikov
From: Jan Engelhardt Add the respective CFLAGS to the build, otherwise the build will error out as seen below. src/libinput-seat.c:30:22: fatal error: libinput.h: No such file or directory [Emil Velikov: polish commit message] Signed-off-by: Emil Velikov --- Jan, don't be shy to send pa

[PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-02-28 Thread Emil Velikov
This reverts commit 85cb5ed64aa8246f4da93fc5b76dfc34096bf803. It seems like we've misread the existing code - the DSO name can be propagated via the build-system. The one available in the script was a simple fall-back. v2: Rebase on top of $NM patch. Cc: Daniel Stone --- Makefile.am

[PATCH wayland v2 4/4] wayland-egl: bump the version number to 18.1.0

2018-02-28 Thread Emil Velikov
From: Emil Velikov Seems like I was overoptimistic with my earlier assumption, namely: "... 17.3.x should be the last version that ships the library." Mesa 18.0.0 and its wayland-egl is about to be released any time soon, so bump the number since it must no be smaller. As soon a

[PATCH wayland v2 3/4] wayland-egl: enhance the symbol test

2018-02-28 Thread Emil Velikov
From: Emil Velikov The current test had a few fall-outs: - it was checking only for T (.text) symbols - did not consider symbol removal Fix that by fetching all the symbols and doing a bidirectional check - for added and removed symbols. Error out with informative message for each case. v2

[PATCH wayland v2 2/4] wayland-egl: fail the symbol check if lib is missing

2018-02-28 Thread Emil Velikov
From: Emil Velikov Based on a similar patch (in Mesa) by Eric Engestrom. v2: Rebase on top of $NM patch. Reviewed-by: Eric Engestrom Signed-off-by: Emil Velikov --- egl/wayland-egl-symbols-check | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/egl/wayland-egl

Re: [PATCH] gl-renderer: Create a high priority context

2018-03-02 Thread Emil Velikov
Hi Chris, On 1 March 2018 at 08:28, Chris Wilson wrote: > EGL_IMG_context_priority allows the client to request that their > rendering be considered high priority. For ourselves, this is important > as we are interactive and any delay in our rendering causes input-output > + if (gr->has_co

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-03-08 Thread Emil Velikov
On 28 February 2018 at 16:38, Emil Velikov wrote: > This reverts commit 85cb5ed64aa8246f4da93fc5b76dfc34096bf803. > > It seems like we've misread the existing code - the DSO name can be > propagated via the build-system. The one available in the script was a > simple fall-bac

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-03-09 Thread Emil Velikov
On 9 March 2018 at 09:47, Daniel Stone wrote: > Hi Emil, > > On 8 March 2018 at 18:32, Emil Velikov wrote: >> On 28 February 2018 at 16:38, Emil Velikov wrote: >>> This reverts commit 85cb5ed64aa8246f4da93fc5b76dfc34096bf803. >>> >>> It seems like we&#

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-03-12 Thread Emil Velikov
On 9 March 2018 at 11:09, Daniel Stone wrote: > Hi Emil, > > On 9 March 2018 at 10:59, Emil Velikov wrote: >> On 9 March 2018 at 09:47, Daniel Stone wrote: >>> Patches 2-4 look fine and I'm happy to merge them with my review, but >>> could you please expl

[PATCH wayland] configure.ac: don't install the static libraries

2018-03-13 Thread Emil Velikov
From: Emil Velikov One should always be using the shared libraries. Spotted while going through the Debian packaing. Signed-off-by: Emil Velikov --- Can we have this in the 1.5 release, please? --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-03-13 Thread Emil Velikov
On 12 March 2018 at 11:25, Daniel Stone wrote: > Hi, > > On 12 March 2018 at 11:21, Emil Velikov wrote: >> On 9 March 2018 at 11:09, Daniel Stone wrote: >>> On 9 March 2018 at 10:59, Emil Velikov wrote: >>>> - above all, the internal path is a 'dum

Re: weston-launch: libEGL: no configs with appropriate attributes

2018-03-14 Thread Emil Velikov
On 14 March 2018 at 11:36, Pekka Paalanen wrote: > On Wed, 14 Mar 2018 11:55:54 +0100 > Král Gergely wrote: > >> Hi, >> >> >> On my old notebook I would like to set up a test environment by running >> weston and let clients to connect to it. I am stuck in the very >> beginning and after almost a

[PATCH weston] configure.ac: fixup systemd/systemd-login detection

2018-03-14 Thread Emil Velikov
From: Emil Velikov Current systemd/systemd-login integration requires dbus. Although that is far from clear the way current checks are handled. Be explicit and clear, effectively fixing cases where the systemd auto detection will trip when dbus is explicitly disabled. Using git show -w will

Re: [PATCH weston] build: honour libinput header location

2018-03-15 Thread Emil Velikov
On 15 March 2018 at 13:11, Jan Engelhardt wrote: > > On Thursday 2018-03-15 13:20, Pekka Paalanen wrote: >>> diff --git a/Makefile.am b/Makefile.am >>> index b5c29c04..8de40e51 100644 >>> --- a/Makefile.am >>> +++ b/Makefile.am >>> @@ -43,7 +43,8 @@ AM_CPPFLAGS =

[PATCH weston v2] build: honour libinput header location

2018-03-15 Thread Emil Velikov
From: Jan Engelhardt Add the respective CFLAGS to the build, otherwise it will error out as seen below. src/libinput-seat.c:30:22: fatal error: libinput.h: No such file or directory v2: add the CFLAGS only as needed, suggested by Pekka Cc: Pekka Paalanen Cc: Jan Engelhardt [Emil Velikov

[PATCH weston v2] configure.ac: fixup systemd/systemd-login detection

2018-03-15 Thread Emil Velikov
From: Emil Velikov Current systemd/systemd-login integration requires dbus. Although that is far from clear the way current checks are handled. Be explicit and clear, effectively fixing cases where the systemd auto detection will trip when dbus is explicitly disabled. Using git show -w will

[PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

2018-03-15 Thread Emil Velikov
From: Emil Velikov Based on a similar patch (in Mesa) by Eric Engestrom. v2: Rebase on top of $NM patch v3: Rebase Reviewed-by: Eric Engestrom (v1) Signed-off-by: Emil Velikov --- egl/wayland-egl-symbols-check | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/egl

[PATCH wayland v3 2/3] wayland-egl: enhance the symbol test

2018-03-15 Thread Emil Velikov
From: Emil Velikov The current test had a few fall-outs: - it was checking only for T (.text) symbols - did not consider symbol removal Fix that by fetching all the symbols and doing a bidirectional check - for added and removed symbols. Error out with informative message for each case. v2

[PATCH wayland v3 3/3] wayland-egl: bump the version number to 18.1.0

2018-03-15 Thread Emil Velikov
From: Emil Velikov Seems like I was overoptimistic with my earlier assumption, namely: "... 17.3.x should be the last version that ships the library." Mesa 18.0.0 and its wayland-egl is about to be released any time soon, so bump the number since it must no be smaller. As soon a

Re: [weston PATCH] simple-dmabuf-drm: support etnaviv drm as well

2018-03-15 Thread Emil Velikov
On 15 March 2018 at 13:58, Pekka Paalanen wrote: > On Mon, 12 Mar 2018 16:41:46 +0100 > Guido Günther wrote: > >> Since freedreno and etnaviv can live in parallel allow to build in >> different DRM backends. >> --- >> Makefile.am | 6 ++- >> clients/simple-dmabuf-drm.c | 122 >

Re: [PATCH wayland-protcols v2] unstable: add xdg-toplevel-decoration protocol

2018-03-15 Thread Emil Velikov
On 2 March 2018 at 15:33, Simon Ser wrote: > This adds a new protocol to negotiate server- and client-side rendering of > window decorations for xdg-toplevels. This allows compositors that want > to draw decorations themselves to send their preference to clients, and > clients that prefer server-s

Re: [PATCH wayland-protcols v2] unstable: add xdg-toplevel-decoration protocol

2018-03-16 Thread Emil Velikov
On 15 March 2018 at 15:43, Simon Ser wrote: > On March 15, 2018 4:15 PM, Emil Velikov wrote: >> On 2 March 2018 at 15:33, Simon Ser wrote: >> > This adds a new protocol to negotiate server- and client-side rendering of >> > window decorations for xdg-toplevels. This a

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

2018-03-16 Thread Emil Velikov
On 16 March 2018 at 13:52, Pekka Paalanen wrote: > On Thu, 15 Mar 2018 14:30:27 + > Emil Velikov wrote: > >> From: Emil Velikov >> >> Based on a similar patch (in Mesa) by Eric Engestrom. >> >> v2: Rebase on top of $NM patch >> v3: Rebase >

[PATCH wayland] wayland-egl: set the correct path to libwayland-egl.so

2018-03-16 Thread Emil Velikov
From: Emil Velikov Earlier commit changed to passing the binary name as env. variable introducing a typo. That went unnoticed, since we do not check if the file is present or not. Cc: Pukka Paalanen Cc: Daniel Stone Fixes: 85cb5ed64aa ("wayland-egl-symbols-check: pass the DSO name vi

Re: [PATCH weston v2] configure.ac: fixup systemd/systemd-login detection

2018-03-16 Thread Emil Velikov
On 15 March 2018 at 17:23, Michael Tretter wrote: > On Thu, 15 Mar 2018 14:20:21 +0000, Emil Velikov wrote: >> From: Emil Velikov >> >> Current systemd/systemd-login integration requires dbus. Although that >> is far from clear the way current checks are handled.

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

2018-03-19 Thread Emil Velikov
On 19 March 2018 at 09:56, Pekka Paalanen wrote: > On Fri, 16 Mar 2018 16:18:57 + > Emil Velikov wrote: > >> On 16 March 2018 at 13:52, Pekka Paalanen wrote: >> > On Thu, 15 Mar 2018 14:30:27 + >> > Emil Velikov wrote: >> > >> >> Fr

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

2018-03-19 Thread Emil Velikov
On 19 March 2018 at 13:20, Daniel Stone wrote: > Hi Quentin, > Thanks for the quick review! > > On 19 March 2018 at 13:06, Quentin Glidic > wrote: >> On 3/19/18 1:31 PM, Daniel Stone wrote: >>> diff --git a/egl/wayland-egl-symbols-check b/egl/wayland-egl-symbols-check >>> index c47026b2..d1a4a6be

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

2018-03-19 Thread Emil Velikov
On 19 March 2018 at 13:39, Daniel Stone wrote: > Hi Emil, > > On 19 March 2018 at 13:27, Emil Velikov wrote: >> On 19 March 2018 at 13:20, Daniel Stone wrote: >>> Me neither really, but it seemed best for consistency with the rest of >>> the file which used test

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

2018-03-19 Thread Emil Velikov
chaining or conditions. > > If we cannot find the binary or nm, we regard this as an error > condition, rather than test failure. > > v2: Don't test if we can execute $NM. > > Signed-off-by: Daniel Stone > Reported-by: Pekka Paalanen > Fixes: 21b1f22eb056 ("wayland-

[PATCH wayland 1/2] wayland-egl-symbols-check: add ARM specific glib entrypoints

2018-03-20 Thread Emil Velikov
From: Emil Velikov Seems like glibc on ARM (32 or 64 bit) exports a few extra symbols. Add them to the list. Quick look reveals that those are aliases of the already listed symbols, and have been added to glibc since day 1 :-\ Fixes: 21b1f22eb05 ("wayland-egl: enhance the symbol

[PATCH wayland 2/2] .gitignore: add wayland-egl-abi-check

2018-03-20 Thread Emil Velikov
From: Emil Velikov Instruct git go ignore the file, in case we've done an in-tree build. Cc: Derek Foreman Signed-off-by: Emil Velikov --- I've opted for the shortest fix - add an entry instead of renaming files, updating build rules, etc. If people really want to we can opt for

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 11:01, Daniel Stone wrote: > Rather than a hard-coded list of platform symbols, just ignore anything > prefaced with an underscore. This fixes breakage on ARM, which declares > several slightly different platform symbols to x86. > FWIW I've explicitly opted against this kind of

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 11:46, Daniel Stone wrote: > Hi Emil, > > On 20 March 2018 at 11:30, Emil Velikov wrote: >> On 20 March 2018 at 11:01, Daniel Stone wrote: >>> Rather than a hard-coded list of platform symbols, just ignore anything >>> prefaced with an under

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 12:11, Daniel Stone wrote: > On 20 March 2018 at 11:55, Emil Velikov wrote: >> On 20 March 2018 at 11:46, Daniel Stone wrote: >>> Sure. As on IRC though, we definitely need to add at least _ftext for >>> MIPS anyway: >>> https:

Re: T480s Trackpoint drifts

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 04:05, Peter Hutterer wrote: > On Mon, Mar 19, 2018 at 04:28:20PM +0800, Kai Hendry wrote: >> Hi there, >> >> I'm an Archlinux user who has a new T480s Thinkpad and unfortunately >> the Trackpoint can (not always or reproducibly) "drift". I hope that >> makes sense! > > what ex

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 14:50, Derek Foreman wrote: > On 2018-03-20 07:11 AM, Daniel Stone wrote: >> On 20 March 2018 at 11:55, Emil Velikov wrote: >>> On 20 March 2018 at 11:46, Daniel Stone wrote: >>>> Sure. As on IRC though, we definitely need to add at lea

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 15:09, Derek Foreman wrote: > On 2018-03-20 10:02 AM, Emil Velikov wrote: >> On 20 March 2018 at 14:50, Derek Foreman wrote: >>> On 2018-03-20 07:11 AM, Daniel Stone wrote: >>>> On 20 March 2018 at 11:55, Emil Velikov wrote: >>>>

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-21 Thread Emil Velikov
On 21 March 2018 at 09:28, Daniel Stone wrote: > Hi, > > On 21 March 2018 at 08:27, Pekka Paalanen wrote: >> On Tue, 20 Mar 2018 11:46:32 +, Daniel Stone >> wrote: >>> inconvenience of maintaining a list of every linker's implementation >>> detail on every platform, outweighs the risk of an

Re: [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

2018-04-24 Thread Emil Velikov
On 13 April 2018 at 11:00, Daniel Vetter wrote: > This tries to align with the X.org communities's long-standing > tradition of trying to be an inclusive community and handing out > commit rights fairly freely. > > We also tend to not revoke commit rights for people no longer > regularly active in

Re: [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

2018-04-26 Thread Emil Velikov
On 24 April 2018 at 20:14, Daniel Vetter wrote: > On Tue, Apr 24, 2018 at 7:30 PM, Emil Velikov > wrote: >> On 13 April 2018 at 11:00, Daniel Vetter wrote: >>> This tries to align with the X.org communities's long-standing >>> tradition of trying to be an

Re: [PATCH weston 2/2] Add .gitlab-ci.yml

2018-06-06 Thread Emil Velikov
Hi Dan, On 5 June 2018 at 23:06, Daniel Stone wrote: > + - apt-get -y --no-install-recommends install build-essential automake > autoconf libtool pkg-config libexpat1-dev libffi-dev libxml2-dev > libpixman-1-dev libpng-dev libjpeg-dev libcolord-dev mesa-common-dev > libglu1-mesa-dev libegl1-

Re: [PATCH weston 2/2] Add .gitlab-ci.yml

2018-06-06 Thread Emil Velikov
On 6 June 2018 at 09:56, Pekka Paalanen wrote: > On Wed, 6 Jun 2018 09:22:59 +0100 > Daniel Stone wrote: > >> On 6 June 2018 at 09:12, Daniel Stone wrote: >> > On 6 June 2018 at 09:03, Pekka Paalanen wrote: >> >> Distcheck does not --disable-xwayland-test, does it? So should we match >> >> it w

Re: [PATCH weston 2/2] Add .gitlab-ci.yml

2018-06-06 Thread Emil Velikov
On 6 June 2018 at 15:47, Simon McVittie wrote: > On Wed, 06 Jun 2018 at 15:33:13 +0100, Emil Velikov wrote: >> On 5 June 2018 at 23:06, Daniel Stone wrote: >> > + - apt-get -y --no-install-recommends install build-essential automake >> > autoconf libtool pkg-conf

  1   2   3   4   5   >