On 29 November 2017 at 14:25, Arnaud Vrac <raw...@gmail.com> wrote: > From: Arnaud Vrac <av...@freebox.fr> > > In glTexImage2D / glTexSubImage2D calls, the only pixel formats allowed > for the GL_R8 and GL_RG internal formats are respectively GL_RED and s/GL_RG/GL_RG8/ ^^
> GL_RG [1]. > > Make sure we match this requirement, as some drivers will fail with the > current code. > AFAICT the patch is spot on. Trivial suggestion below: Reviewed-by: Emil Velikov <emil.veli...@collabora.com> I'd suggest using something like the following. A reference to the offending code is always nice, plus CC-ing the author gives you an extra reviewer ;-) Fixes: 00a03d2f724 ("gl-renderer: add support of WL_SHM_FORMAT_NV12") Cc: Vincent Abriou <vincent.abr...@st.com> HTH Emil _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel