Re: NEW: devel/phantomjs

2013-12-11 Thread Stuart Henderson
On 2013/12/05 10:57, Francisco de Borja Lopez Rio wrote: > On Wed, Dec 04, 2013 at 11:37:07AM +, Stuart Henderson wrote: > > > > MESSAGE should go; if every port which installed examples under > > share/examples/portname printed a message about it, installing or > > updating ports would be exce

Re: NEW: devel/phantomjs

2013-12-10 Thread Stuart Henderson
On 2013/12/09 18:54, Francisco de Borja Lopez Rio wrote: > On Thu, Dec 05, 2013 at 10:57:32AM +0100, Francisco de Borja Lopez Rio wrote: > > > > All done, attached is the updated version of the port, which is also > > available here for download: > > > > http://codigo23.net/openbsd/ports/phantomjs.

Re: NEW: devel/phantomjs

2013-12-09 Thread Francisco de Borja Lopez Rio
On Thu, Dec 05, 2013 at 10:57:32AM +0100, Francisco de Borja Lopez Rio wrote: > > All done, attached is the updated version of the port, which is also > available here for download: > > http://codigo23.net/openbsd/ports/phantomjs.tar.gz > Ok? -- "Do nothing which is of no use." - Miyamoto Musash

Re: NEW: devel/phantomjs

2013-12-05 Thread Francisco de Borja Lopez Rio
On Wed, Dec 04, 2013 at 11:37:07AM +, Stuart Henderson wrote: > > MESSAGE should go; if every port which installed examples under > share/examples/portname printed a message about it, installing or > updating ports would be excessively noisy. > > BUILD_DEPENDS on print/freetype seems unlikely t

Re: NEW: devel/phantomjs

2013-12-04 Thread Stuart Henderson
On 2013/12/04 10:58, Francisco de Borja Lopez Rio wrote: > Ok, updated port attached. > > I've applied fixes for most of the feedback, except with some notes: > > On Wed, Nov 27, 2013 at 05:12:51PM +, Stuart Henderson wrote: > > > > ksh should work for this script, no? it also calls out to pr

Re: NEW: devel/phantomjs

2013-12-04 Thread Francisco de Borja Lopez Rio
Ok, updated port attached. I've applied fixes for most of the feedback, except with some notes: On Wed, Nov 27, 2013 at 05:12:51PM +, Stuart Henderson wrote: > > ksh should work for this script, no? it also calls out to preconfig.sh > which should also work with ksh, just patch the shebang li

Re: NEW: devel/phantomjs

2013-11-28 Thread Vadim Zhukov
27.11.2013 19:38 пользователь "Landry Breuil" написал: > > On Wed, Nov 27, 2013 at 04:19:30PM +0100, Francisco de Borja Lopez Rio wrote: > > Hi everybody (first time writing to this list) > > > > Attached is a port for PhantomJS, a headless WebKit scriptable with a > > JavaScript API. It has fast

Re: NEW: devel/phantomjs

2013-11-28 Thread Stuart Henderson
On 2013/11/28 08:50, Francisco de Borja Lopez Rio wrote: > Yeah, completely forgot that the statically built binary will contain some > GPLed stuff. Should it be PERMIT_PACKAGE_CDROM = No then? No, it's ok to package, just the license marker in the comment needs updating. > > > > MAKE_ENV =

Re: NEW: devel/phantomjs

2013-11-27 Thread Francisco de Borja Lopez Rio
Thanks a lot for the feedback Stuart. On Wed, Nov 27, 2013 at 05:12:51PM +, Stuart Henderson wrote: > > > # BSD License > > not if it bundles Qt, it isn't.. > Yeah, completely forgot that the statically built binary will contain some GPLed stuff. Should it be PERMIT_PACKAGE_CDROM = No then

Re: NEW: devel/phantomjs

2013-11-27 Thread Stuart Henderson
On 2013/11/27 11:56, Ted Unangst wrote: > On Wed, Nov 27, 2013 at 16:47, Francisco de Borja Lopez Rio wrote: > > > Ok. Probably I need to understand first what "an unsafe use" of it means, as > > mentioned in Security Recommendations in the porting page: > > > > http://www.openbsd.org/porting.htm

Re: NEW: devel/phantomjs

2013-11-27 Thread Stuart Henderson
> NAME = phantomjs > VERSION = 1.9.2 > PKGNAME = ${NAME}-${VERSION} > DISTNAME = ${PKGNAME}-source ... > WRKDIST = ${WRKDIR}/${PKGNAME} these can be replaced with: PKGNAME = phantomjs-1.9.2 EXTRACT_SUFX =

Re: NEW: devel/phantomjs

2013-11-27 Thread Ted Unangst
On Wed, Nov 27, 2013 at 16:47, Francisco de Borja Lopez Rio wrote: > Ok. Probably I need to understand first what "an unsafe use" of it means, as > mentioned in Security Recommendations in the porting page: > > http://www.openbsd.org/porting.html#Security 1. I don't think strcmp belongs in that

Re: NEW: devel/phantomjs

2013-11-27 Thread Landry Breuil
On Wed, Nov 27, 2013 at 04:32:30PM +, Stuart Henderson wrote: > On 2013/11/27 16:38, Landry Breuil wrote: > > We dont need yet another copy of qt4 and webkit in the tree > > To be fair, we have a few copies of mozilla too :) Yeah, but 4 of them should hit the attic as soon as the last use

Re: NEW: devel/phantomjs

2013-11-27 Thread Stuart Henderson
On 2013/11/27 16:38, Landry Breuil wrote: > We dont need yet another copy of qt4 and webkit in the tree To be fair, we have a few copies of mozilla too :)

Re: NEW: devel/phantomjs

2013-11-27 Thread Francisco de Borja Lopez Rio
On Wed, Nov 27, 2013 at 04:38:08PM +0100, Landry Breuil wrote: > On Wed, Nov 27, 2013 at 04:19:30PM +0100, Francisco de Borja Lopez Rio wrote: > > Hi everybody (first time writing to this list) > > > > Attached is a port for PhantomJS, a headless WebKit scriptable with a > > JavaScript API. It ha

Re: NEW: devel/phantomjs

2013-11-27 Thread Francisco de Borja Lopez Rio
On Wed, Nov 27, 2013 at 10:37:23AM -0500, Ted Unangst wrote: > On Wed, Nov 27, 2013 at 16:19, Francisco de Borja Lopez Rio wrote: > > > - Some of the .cpp source files use strcmp instead of strncmp, I'll try to > > work > > a bit more on this and send them some patches to fix it. > > Unless you'r

Re: NEW: devel/phantomjs

2013-11-27 Thread Landry Breuil
On Wed, Nov 27, 2013 at 04:19:30PM +0100, Francisco de Borja Lopez Rio wrote: > Hi everybody (first time writing to this list) > > Attached is a port for PhantomJS, a headless WebKit scriptable with a > JavaScript API. It has fast and native support for various web standards: > DOM handling, CSS

Re: NEW: devel/phantomjs

2013-11-27 Thread Ted Unangst
On Wed, Nov 27, 2013 at 16:19, Francisco de Borja Lopez Rio wrote: > - Some of the .cpp source files use strcmp instead of strncmp, I'll try to > work > a bit more on this and send them some patches to fix it. Unless you're thinking of a different string function, strcmp isn't a bad function.

NEW: devel/phantomjs

2013-11-27 Thread Francisco de Borja Lopez Rio
Hi everybody (first time writing to this list) Attached is a port for PhantomJS, a headless WebKit scriptable with a JavaScript API. It has fast and native support for various web standards: DOM handling, CSS selector, JSON, Canvas, and SVG. Home page: http://phantomjs.org This is my first att