Ok, updated port attached.

I've applied fixes for most of the feedback, except with some notes:

On Wed, Nov 27, 2013 at 05:12:51PM +0000, Stuart Henderson wrote:
>
> ksh should work for this script, no? it also calls out to preconfig.sh
> which should also work with ksh, just patch the shebang lines.
>

preconfig.sh does not run with ksh, lots of errors and I don't think it is
worth the effort to replace it with a ksh-compatible version.

Is it a big trouble to have bash as a build dependency here?

>
> I haven't tried building it yet, but I suspect it needs a NO_TEST=Yes too.
>

I've added a do-test routine, but right now if you run the tests you will get
some failures.

I've been digging a bit, trying to run the tests in other platforms (FreeBSD 9,
OSx 10.8) and tests didn't pass cleanly there neither, so... I added a
NO_TEST=Yes for now, hopefully that will change in future releases.

Regards.

--

"Do nothing which is of no use." - Miyamoto Musashi
---------------------------------------------------------------------
Francisco de Borja Lopez Rio (bo...@codigo23.net)
Soluciones Informaticas Codigo23 S.L.U.
http://www.codigo23.net

Attachment: phantomjs.tar.gz
Description: application/tar-gz

Attachment: pgp6OcWrXKhrO.pgp
Description: PGP signature

Reply via email to