> NAME =                  phantomjs
> VERSION =               1.9.2
> PKGNAME =               ${NAME}-${VERSION}
> DISTNAME =              ${PKGNAME}-source
...
> WRKDIST =               ${WRKDIR}/${PKGNAME}

these can be replaced with:

PKGNAME =               phantomjs-1.9.2
EXTRACT_SUFX =          -source.zip

using "${NAME}" all through the Makefile like you've done isn't really
done in the ports tree, and there's no value to setting VERSION separately

> HOMEPAGE =              http://phantomjs.org

trailing slash is preferable here

> # BSD License

not if it bundles Qt, it isn't..

> MAKE_ENV =              C_INCLUDE_PATH=/usr/X11R6/include/ \
>                         CPLUS_INCLUDE_PATH=/usr/X11R6/include/ \

replace /usr/X11R6 with ${X11BASE}.

add MAKEFLAGS="-j${MAKE_JOBS}" to MAKE_ENV and set PARALLEL_BUILD = No.

> do-build:
>         @cd ${WRKSRC} && env -i ${MAKE_ENV} \
>                 ${LOCALBASE}/bin/bash build.sh --confirm

ksh should work for this script, no? it also calls out to preconfig.sh
which should also work with ksh, just patch the shebang lines.

the first two of these lines should be copied to do-configure, and do-build
should be removed.

I haven't tried building it yet, but I suspect it needs a NO_TEST=Yes too.

I share Landry's distaste at adding another copy of webkit and *especially*
the extra copy of qt with all the patches that this brings... however I have
heard that CasperJS (which runs on top of PhantomJS) is particularly useful
for screenscraping some awkward sites (especially banks) so it could be a
handy thing to have...

Reply via email to