Thanks a lot for the feedback Stuart. On Wed, Nov 27, 2013 at 05:12:51PM +0000, Stuart Henderson wrote: > > > # BSD License > > not if it bundles Qt, it isn't.. >
Yeah, completely forgot that the statically built binary will contain some
GPLed stuff. Should it be PERMIT_PACKAGE_CDROM = No then?
> > MAKE_ENV = C_INCLUDE_PATH=/usr/X11R6/include/ \
> > CPLUS_INCLUDE_PATH=/usr/X11R6/include/ \
>
> replace /usr/X11R6 with ${X11BASE}.
>
> add MAKEFLAGS="-j${MAKE_JOBS}" to MAKE_ENV and set PARALLEL_BUILD = No.
>
If we use the build.sh script, it automatically sets the JOBS number based
on the OSTYPE (openbsd) and the number of cpu/cores. As I understand, adding
those MAKEFLAGS will let users decide how many JOBS will be "used", right?
What about PARALLEL_BUILD? why should we set it to No for this port?
>
> I haven't tried building it yet, but I suspect it needs a NO_TEST=Yes too.
>
It has regression tests:
https://github.com/ariya/phantomjs/wiki/Test-Suite
But maybe I have to add a custom do-test? entry in the Makefile to run them?
> I share Landry's distaste at adding another copy of webkit and *especially*
> the extra copy of qt with all the patches that this brings... however I have
> heard that CasperJS (which runs on top of PhantomJS) is particularly useful
> for screenscraping some awkward sites (especially banks) so it could be a
> handy thing to have...
Same here, as I've said, I don't like having to build against the bundled copy
of the libraries.
About phantomjs itself, this port came out of the necessity we have in a
project I'm working on, where we need it for integration tests of some webapps.
So, well, here we need it and after being able to build it I thought it would
be nice to have it in the ports collection for everybody else.
--
"Do nothing which is of no use." - Miyamoto Musashi
---------------------------------------------------------------------
Francisco de Borja Lopez Rio (bo...@codigo23.net)
Soluciones Informaticas Codigo23 S.L.U.
http://www.codigo23.net
pgp0YTvSj3U4t.pgp
Description: PGP signature
