On 2013/11/28 08:50, Francisco de Borja Lopez Rio wrote:
> Yeah, completely forgot that the statically built binary will contain some
> GPLed stuff. Should it be PERMIT_PACKAGE_CDROM = No then?
No, it's ok to package, just the license marker in the comment needs updating.
>
> > > MAKE_ENV = C_INCLUDE_PATH=/usr/X11R6/include/ \
> > > CPLUS_INCLUDE_PATH=/usr/X11R6/include/ \
> >
> > replace /usr/X11R6 with ${X11BASE}.
> >
> > add MAKEFLAGS="-j${MAKE_JOBS}" to MAKE_ENV and set PARALLEL_BUILD = No.
> >
>
> If we use the build.sh script, it automatically sets the JOBS number based
> on the OSTYPE (openbsd) and the number of cpu/cores.
Yes, and that is incorrect because it's outside of control of ports.
dpb controls the number of jobs to avoid more cores being used than are
available. If you rely on this automatic setting and have a 4-core
machine where dpb is already running 3 jobs, when it starts building
phantomjs it will be running 7 jobs in parallel, which is just going
to slow things down.
> As I understand, adding
> those MAKEFLAGS will let users decide how many JOBS will be "used", right?
Users or dpb - yes.
> What about PARALLEL_BUILD? why should we set it to No for this port?
Because it has its own mechanism rather than using "make -j"
> > I haven't tried building it yet, but I suspect it needs a NO_TEST=Yes too.
> >
>
> It has regression tests:
>
> https://github.com/ariya/phantomjs/wiki/Test-Suite
>
> But maybe I have to add a custom do-test? entry in the Makefile to run them?
Yes, please.
> > I share Landry's distaste at adding another copy of webkit and *especially*
> > the extra copy of qt with all the patches that this brings... however I have
> > heard that CasperJS (which runs on top of PhantomJS) is particularly useful
> > for screenscraping some awkward sites (especially banks) so it could be a
> > handy thing to have...
>
> Same here, as I've said, I don't like having to build against the bundled
> copy
> of the libraries.
>
> About phantomjs itself, this port came out of the necessity we have in a
> project I'm working on, where we need it for integration tests of some
> webapps.
> So, well, here we need it and after being able to build it I thought it would
> be nice to have it in the ports collection for everybody else.
>
> --
>
> "Do nothing which is of no use." - Miyamoto Musashi
> ---------------------------------------------------------------------
> Francisco de Borja Lopez Rio (bo...@codigo23.net)
> Soluciones Informaticas Codigo23 S.L.U.
> http://www.codigo23.net
>
