---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118613/#review59544
---
Ship it!
Ship It!
- David Edmundson
On June 8, 2014, 4:45
nPixmap and m_pixmapIcon
> > and what's the difference?
one exists, the other doesn't.
BShah, can you remove this commented line. It doesn't add to anything.
- David
---
This is an automatically generated e-mail. To
nPixmap and m_pixmapIcon
> > and what's the difference?
>
> David Edmundson wrote:
> one exists, the other doesn't.
>
> BShah, can you remove this commented line. It doesn't add to anything.
>
> Martin Klapetek wrote:
> No, they both do ex
tps://git.reviewboard.kde.org/r/118423/#comment41566>
QLatin1String
(or rather QStringLiteral)
- David Edmundson
On May 30, 2014, 1:38 p.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118630/#review59659
---
Ship it!
Wait for the Qt patch if relevant
- David
g/r/118461/#comment41568>
I'd rather we just renamed the file here.
It's weird and confusing to find where files come from otherwise.
- David Edmundson
On June 2, 2014, 5:41 a.m., Martin Gräßlin wrote:
>
> --
> On June 10, 2014, 10:34 a.m., David Edmundson wrote:
> > Wait for the Qt patch if relevant
>
> Sebastian Kügler wrote:
> It doesn't break any more without the Qt patch, so I'd rather ship this,
> and have it automatically fixed once Qt is updated.
My conce
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118461/#review59677
---
Ship it!
Ship It!
- David Edmundson
On June 10, 2014, 12
g/r/118636/#comment41582>
and if there is no sound the closed signal happens immediately?
ksmserver/shutdown.cpp
<https://git.reviewboard.kde.org/r/118636/#comment41583>
Why do we have this if? What other state might we be in?
- David Edmundson
On June 10, 2014, 1:05 p.m., Mar
Diff: https://git.reviewboard.kde.org/r/118428/diff/
Testing
---
Opened KCM.
Thanks,
David Edmundson
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118251/#review59724
---
Ship it!
Ship It!
- David Edmundson
On June 10, 2014, 1
> 1) Make opening the activity switcher fast. That would need to throw away the
> lazy loading that we currently have. And I'm not sure that would be a
> sufficient improvement.
Note that a debug build of Qt makes a humongous difference to the
speed of all things QtQuick related, especially parsin
tries to link
against it otherwise you get mystery compile fails.
There's 2 applets and 9 KCMs
- David Edmundson
On June 11, 2014, 8:44 a.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. T
> On June 11, 2014, 9 a.m., David Edmundson wrote:
> > If you do this we need checks around building everything that tries to link
> > against it otherwise you get mystery compile fails.
> > There's 2 applets and 9 KCMs
>
> Martin Gräßlin wrote:
> th
://git.reviewboard.kde.org/r/118678/#comment41685>
I'd make this a new static method;
availablleDomainTranslations(const QByte..)
We're using a method called availableApplicationTranslations to list things
outside the application which is going against the name of the metho
roval from one of the Windows
people first.
- David Edmundson
On June 12, 2014, 11:32 a.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
> On June 12, 2014, 11:36 a.m., David Edmundson wrote:
> > Ship it from me, but I'd like you to get approval from one of the Windows
> > people first.
>
> Martin Gräßlin wrote:
> I think we have that already:
> https://mail.kde.org/pipermail/plasma-deve
x27;ll still be
broken if you ran this from other desktops which makes the setup wrong.
- David Edmundson
On June 13, 2014, 1:01 p.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail.
e.org/r/118730/#comment41765>
you may as well make this synchronous and lose the app.exec()
you'd still get 1 event loop and it'd be easier to read.
- David Edmundson
On June 13, 2014, 1:01 p.m., Martin Gräßlin wrote:
>
> ---
> On June 13, 2014, 1:14 p.m., David Edmundson wrote:
> > I don't understand where this is useful unless you have a broken setup to
> > begin with.
> >
> > Either you have your XDG paths set up properly for all users at which point
> > you don't ne
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118636/#review60016
---
Ship it!
Ship It!
- David Edmundson
On June 10, 2014, 1
> On June 10, 2014, 1:15 p.m., David Edmundson wrote:
> > ksmserver/shutdown.cpp, line 501
> > <https://git.reviewboard.kde.org/r/118636/diff/1/?file=279977#file279977line501>
> >
> > Why do we have this if? What other state might we be in?
>
> M
access?
- David Edmundson
On June 13, 2014, 4:09 p.m., Bernd Steinhauser wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
mes
I agree with Aleix it would be better, but ideally we need to find a way to
tell SDDM where KDE has it's look and feel stuff which would be even better, so
it's not worth it for now.
- David
---
This is an automa
tps://git.reviewboard.kde.org/r/118730/#comment41792>
if we do .asyncCall() and waitForFinished()
we may as well just do .call()
- David Edmundson
On June 13, 2014, 7:36 p.m., Martin Gräßlin wrote:
>
> ---
.
Start the animation then pause + start and check it resumes from the same
place.
- David Edmundson
On June 15, 2014, 7:19 p.m., Kai Uwe Broulik wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
#include not found.
It seems it's missing kservice across all of these failures.
I just wiped all my install directory and updated frameworks,
everything still builds fine here.
I suspect Jenkins is at fault here.
David
___
Plasma-devel mailing
---
Add icon size "tiny"
See https://bugs.kde.org/show_bug.cgi?id=336326
Diffs
-
src/declarativeimports/core/units.cpp 558cafc
Diff: https://git.reviewboard.kde.org/r/118798/diff/
Testing
---
Thanks,
David Edmundson
Testing
---
Thanks,
David Edmundson
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118724/#review60305
---
Ship it!
Ship It!
- David Faure
On June 17, 2014, 4:16
tions of edges + preferred locations.
(i.e placed near left edge, showed item with location set to both left and
right)
Thanks,
David Edmundson
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118813/#review60394
---
Are you not working on a patch to test at startup?
- David
;
Lets keep this a bit more professional.
shell/shellcorona.cpp
<https://git.reviewboard.kde.org/r/118812/#comment42117>
just QCoreApplication::exit()
- David Edmundson
On June 18, 2014, 11:36 a.m., Martin Gräßlin wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118813/#review60399
---
Ship it!
Ship It!
- David Edmundson
On June 18, 2014, 12
> On June 18, 2014, 12:54 p.m., David Edmundson wrote:
> > Are you not working on a patch to test at startup?
> >
>
> Martin Gräßlin wrote:
> yes I am, but this is orthogonal as it is in the frameworks.
Good point.
I think maybe I should patch Qt too. Curr
> On June 18, 2014, 1 p.m., David Edmundson wrote:
> > shell/shellcorona.h, line 87
> > <https://git.reviewboard.kde.org/r/118812/diff/1/?file=282338#file282338line87>
> >
> > private?
>
> Martin Gräßlin wrote:
> are private slots invokabl
tps://git.reviewboard.kde.org/r/118804/#comment42165>
This doesn't make sense.
you have "if the reply is invalid, print the value in the reply"
you want to be printing the takeControlReply.error in this case which will
probably contain something useful.
- David Edmundson
On
wing
somewhere else then this check is skipped entirely.
Diffs
-
src/declarativeimports/core/tooltip.cpp 11aaaff
Diff: https://git.reviewboard.kde.org/r/118838/diff/
Testing
---
Thanks,
David Edmundson
___
Plasma-devel mailing list
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118665/#review60510
---
Ship it!
Ship It!
- David Edmundson
On June 13, 2014, 8
on is broken; if the tooltip is already showing
somewhere else then this check is skipped entirely.
Diffs (updated)
-
src/declarativeimports/core/tooltip.cpp 11aaaff
Diff: https://git.reviewboard.kde.org/r/118838/diff/
Testing
---
Than
x27;t have a subtext.
Besides the current implementation is broken; if the tooltip is already showing
somewhere else then this check is skipped entirely.
Diffs
-
src/declarativeimports/core/tooltip.cpp 11aaaff
Diff: https://git.reviewboard.kde.org/r/118838/diff/
Testing
---
Than
ler, so it would be a
regression.
However I'm not entirely sure what SectionScroller actually does, so possibly
not an important one.
- David Edmundson
On Dec. 3, 2013, 7:09 p.m., David Edmundson wrote:
>
> ---
> This is an a
crollView, and so did I.
>
> Marco Martin wrote:
> eeew, and does use a correct scrollbar?
No, it is not. It's the wrong colour and width.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git
83/diff/
Testing
---
Widget Explorer in plasma-shell looks exactly as before.
Thanks,
David Edmundson
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
icular, ScrollBar.qml was public api, so shouldn't be
> removed, even if not used by this component in partibular.
>
> apart from that is good to go.
>
> Kai Uwe Broulik wrote:
> Any news on this? Plasma-NM has recently switched over to a QtQuick
> Controls S
xtracomponents/qml/styles/ScrollViewStyle.qml
PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/114283/diff/
Testing
---
Widget Explorer in plasma-shell looks exactly as before.
Thanks,
David Edmundson
___
Plasma-devel mailing list
Plasma-d
merge.
flickableItem has now become contentItem (which is a default property)
All instances in plasma-workspace/plasma-desktop are now updated.
- David Edmundson
On June 19, 2014, 6:09 p.m., David Edmundson wrote:
>
> ---
> This is an
-framework
Description
---
Add notify to colorGroup property
Diffs
-
src/declarativeimports/core/colorscope.h b90bb61
Diff: https://git.reviewboard.kde.org/r/118841/diff/
Testing
---
Thanks,
David Edmundson
___
Plasma-devel mailing list
---
Thanks,
David Edmundson
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
pitem.h eee8189
src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp fcc66b5
Diff: https://git.reviewboard.kde.org/r/118842/diff/
Testing
---
Wrote small qml file, code had warning before, now it doesn't.
Images are still displayed if set.
Than
now it doesn't.
Images are still displayed if set.
Thanks,
David Edmundson
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
d.kde.org/r/118845/#comment42283>
Is the goal of this patch is to have it so it syncs the settings the user
just selected? If so, we don't want to be copying and saving a hardcoded
"breeze".
- David Edmundson
On June 20,
> On June 20, 2014, 12:45 p.m., David Edmundson wrote:
> > kcms/krdb/krdb.cpp, line 616
> > <https://git.reviewboard.kde.org/r/118845/diff/2/?file=282676#file282676line616>
> >
> > Is the goal of this patch is to have it so it syncs the settings the
> &
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118845/#review60610
---
Ship it!
- David Edmundson
On June 20, 2014, 3:26 p.m
sk is there to disable interactivity when only the
column with icons on the left is visible and the plasmoid contents is on the
right in popup (eg. when you open popup with clicking on Show hidden icons
arrow and then select some item).
- David
---
ems unrelated to the rest of this patch.
Because I couldn't find any use of this and thus I don't know if it should be
in ListView or in ScrollArea (that now has "hiddenView" id). I guess it was
used from C++ to get hand
t rm this file
cmake/GTKEngineConfig.cmake (line 3)
<https://git.reviewboard.kde.org/r/125811/#comment60015>
that's not distro agnostic
I think there's a cmake var for libpath
- David Edmundson
On Oct. 26,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125812/#review87440
---
Ship it!
Ship It!
- David Edmundson
On Oct. 26, 2015, 5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125809/#review87441
---
Ship it!
Ship It!
- David Edmundson
On Oct. 26, 2015, 4
all laptop with a high res external screen, when you unplug
the external screen you'll need to update the struts of a panel on the smaller
screen.
This signal wouldn't be emitted in that case. I'm not sure what the right
signal is.
- David Edmundson
On Oct. 26, 201
Use QStandardPaths to find .config
kconf_update/main.cpp (line 171)
<https://git.reviewboard.kde.org/r/125814/#comment60022>
not needed
- David Edmundson
On Oct. 26, 2015, 5:40 p.m., Jonathan Riddell wrote:
>
> -
tps://git.reviewboard.kde.org/r/125811/#comment60029>
I guess this want meant to use ${_ver}
- David Edmundson
On Oct. 26, 2015, 6:01 p.m., Jonathan Riddell wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
ems unrelated to the rest of this patch.
>
> David Rosca wrote:
> Because I couldn't find any use of this and thus I don't know if it
> should be in ListView or in ScrollArea (that now has "hiddenView" id). I
> guess it was used from C++ to get handle of
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit 7ebe57aa74cd99ff81c4d0be9f1423a47b94d64b by David
Edmundson to branch Plasma/5.4.
Repository: plasma-desktop
Description
---
Someone whilst porting had simply commented it out
This causes the install
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit a2a9d41b334db36238232be8e093deeecab03514 by David Rosca
to branch master.
Bugs: 341165
https://bugs.kde.org/show_bug.cgi?id=341165
Repository: plasma-workspace
Description
---
Show vertical
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125822/#review87476
---
Ship it!
why only CC bug?
- David Edmundson
On Oct. 26
tps://git.reviewboard.kde.org/r/125811/#comment60070>
what if I have 2.10.1 installed?
- David Edmundson
On Oct. 27, 2015, 9:22 a.m., Jonathan Riddell wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
;
or port to KWindowInfo ?
- David Edmundson
On Oct. 27, 2015, 9:25 a.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125825/#review87497
---
Ship it!
Ship It!
- David Edmundson
On Oct. 27, 2015, 9
tps://git.reviewboard.kde.org/r/125827/#comment60081>
it's better to do
if(X) {
xThing
}
rather than if (!wayland) {
xThing
}
will ease any future porting.
- David Edmundson
On Oct. 27, 2015, 10:51 a.m., Bhushan
> On Oct. 26, 2015, 5:55 p.m., David Edmundson wrote:
> > kconf_update/main.cpp, line 171
> > <https://git.reviewboard.kde.org/r/125814/diff/1/?file=412868#file412868line171>
> >
> > not needed
>
> Jonathan Riddell wrote:
> ok but th
tps://git.reviewboard.kde.org/r/125814/#comment60085>
QStandardPaths::writableLocation
kconf_update/main.cpp (line 180)
<https://git.reviewboard.kde.org/r/125814/#comment60084>
the result of setGtk2 is lost
I assume we want some sort of
result |= setGtk3
- David Edmundson
---
see summary
Diffs
-
kcms/keyboard/flags.cpp 4d3a515
kcms/keyboard/x11_helper.cpp a742318
Diff: https://git.reviewboard.kde.org/r/125826/diff/
Testing
---
Thanks,
David Rosca
___
Plasma-devel mailing list
Plasma-devel@kde.org
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125826/#review87506
---
Ship it!
Ship It!
- David Edmundson
On Oct. 27, 2015, 11
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit 1bb6fb4ebe7458f67603deb3c17b1fbbd33a9e9d by David Rosca
to branch master.
Repository: plasma-desktop
Description
---
see summary
Diffs
-
kcms/keyboard/flags.cpp 4d3a515
kcms/keyboard
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125814/#review87507
---
Ship it!
Ship It!
- David Edmundson
On Oct. 27, 2015, 11
> On Oct. 27, 2015, 9:26 a.m., David Edmundson wrote:
> > cmake/FindGTKEngine.cmake, line 17
> > <https://git.reviewboard.kde.org/r/125811/diff/3/?file=412976#file412976line17>
> >
> > what if I have 2.10.1 installed?
>
> Jonathan Riddell wrote:
>
greying out is definitely not the
> correct visualization and your patch fixes this, you can ship it.
> If the VDG comes up with a better solution, we'll propose it. Until then,
> having minimized windows look the same as non-minimized ones is definitely
> better than what we
---
Always show icon, even when launcher icon is empty.
Diffs
-
applets/quicklaunch/package/contents/ui/IconItem.qml 0e449f7
Diff: https://git.reviewboard.kde.org/r/125839/diff/
Testing
---
Thanks,
David Rosca
___
Plasma-devel
x it's easier to read.
- David Edmundson
On Oct. 28, 2015, 11:52 a.m., David Rosca wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit 43d7a16e37146b033d244eb017155950f5079843 by David Rosca
to branch master.
Repository: kdeplasma-addons
Description
---
Always show icon, even when launcher icon is empty.
Diffs
-
applets
> On Oct. 28, 2015, 12:24 p.m., David Edmundson wrote:
> > applets/quicklaunch/package/contents/ui/IconItem.qml, line 35
> > <https://git.reviewboard.kde.org/r/125839/diff/1/?file=413122#file413122line35>
> >
> > sexy QML tip for future
> >
> On Oct. 21, 2015, 9:05 p.m., David Edmundson wrote:
> > Makes sense for the default behaviours to match
>
> Martin Klapetek wrote:
> Match what? Do we have similar code elsewhere? Btw Hrvoje reported that
> this is less than ideal as it "letterboxes" th
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125837/#review87599
---
Ship it!
Ship It!
- David Edmundson
On Oct. 28, 2015, 10
embed-sni-proxy/xembedsniproxy.desktop PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/125655/diff/
Testing
---
Thanks,
David Edmundson
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
en that I
> > recommend to skip using the Xcb::atoms for it and just use the one taking
> > the name as const char*
doesn't work for some reason. Haven't properly investigated why; but it doesn't
get systrays.
- David
--
t suit our intended use case,
> because we encourage our users to mess with LC_* variables through the
> Formats KCM, which makes it prone to mixed configurations like LC_DATE=cs_CZ
> and LANG=en_US.
>
> But nevertheless a) David Edmundson has a patch in the works so let
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125858/#review87660
---
Ship it!
Ship It!
- David Edmundson
On Oct. 29, 2015, 7
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125858/#review87663
---
can you push into branch Plamsa/5.4 too
- David Edmundson
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit d1a9729d1f3b857642ff415153cdca73cb341596 by David
Edmundson to branch master.
Repository: plasma-workspace
Description
---
Expired notifications should emit a different reason in
NotificationClosed
- David Edmundson
On Oct. 26, 2015, 10:43 p.m., David Rosca wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
Update drkonqui hints for relevant information
Diffs
-
drkonqi/applicationdetailsexamples.cpp
65ceb18cf2bd9eccf666e5c95273513857f660d3
Diff: https://git.reviewboard.kde.org/r/125870/diff/
Testing
---
Thanks,
David Edmundson
> On Oct. 29, 2015, 4:44 p.m., David Edmundson wrote:
> > does this close: https://bugs.kde.org/show_bug.cgi?id=354543
Yes
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org
> On Oct. 29, 2015, 4:44 p.m., David Edmundson wrote:
> > does this close: https://bugs.kde.org/show_bug.cgi?id=354543
>
> David Rosca wrote:
> Yes
could you close it then?
You don't want me claiming your bugzilla stats
(line 158)
<https://git.reviewboard.kde.org/r/125864/#comment60163>
FYI you can leave it as anchors.margins: spacing
it means you're setting that anchorMargin you're not using, but given you
don't have a left anchor it won't do anything anyway.
- David Edmun
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit 9cce76bc4b12c18ef7796e8a62311275bd2ba419 by David
Edmundson to branch master.
Repository: plasma-workspace
Description
---
Update drkonqui hints for relevant information
Diffs
-
drkonqi
I was obviously deliberately testing who'd notice it in a review
obviously. You passed.
Fixed both.
- David
---
This is an automatically generated e-mail. To reply, visit:
https
-aa42e7eb2bf3__before.png
after
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/445009bc-a4a8-4998-8e82-996a0a4e33fb__after.png
Thanks,
David Rosca
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo
VolumeSlider).
Thanks,
David Rosca
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
pp PRE-CREATION
xembed-sni-proxy/fdoselectionmanager.h PRE-CREATION
CMakeLists.txt 50091ea8ffb01177d34e18217b929cfb9ede3d23
xembed-sni-proxy/CMakeLists.txt PRE-CREATION
xembed-sni-proxy/Readme.md PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/125655/diff/
Testing
---
701 - 800 of 9753 matches
Mail list logo
