> On June 13, 2014, 4:11 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 118 > > <https://git.reviewboard.kde.org/r/118733/diff/1/?file=280911#file280911line118> > > > > Actually, shouldn't we have a find_package sddm and install it wherever > > it's installed? > > Bernd Steinhauser wrote: > At least currently, there is no option to define the installation dir, > apart from the prefix, it will be installed to > "${CMAKE_INSTALL_FULL_DATADIR}/sddm". > (Actually, maybe the cmake file in plasma-workspace should use > CMAKE_INSTALL_FULL_DATADIR, too.) > > Therefore, I fail to see the advantage of adding a FindSDDM.cmake.
Theoretically one could install sddm into /opt/cheese/ and KDE into /opt/kde We would want to install the SDDM theme into /opt/cheese/share/sddm/themes I agree with Aleix it would be better, but ideally we need to find a way to tell SDDM where KDE has it's look and feel stuff which would be even better, so it's not worth it for now. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118733/#review60023 ----------------------------------------------------------- On June 13, 2014, 4:09 p.m., Bernd Steinhauser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118733/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 4:09 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-workspace > > > Description > ------- > > Simple thing. The default installation path changed upstream at id > d102be248237d3e4da0e1d0e8cdfe862851375f7 from > /usr/share/apps/sddm > to > /usr/share/sddm > > Hence the patch updates the path, so sddm can actually find the theme. > > > Diffs > ----- > > CMakeLists.txt 08c9084 > > Diff: https://git.reviewboard.kde.org/r/118733/diff/ > > > Testing > ------- > > > Thanks, > > Bernd Steinhauser > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
