> On Oct. 27, 2015, 9:26 a.m., David Edmundson wrote: > > cmake/FindGTKEngine.cmake, line 17 > > <https://git.reviewboard.kde.org/r/125811/diff/3/?file=412976#file412976line17> > > > > what if I have 2.10.1 installed? > > Jonathan Riddell wrote: > No such bugfix ABI bumper were made and now GTK 3 is the development > focus so I don't think they will be made.
that raises a good question - why are we checking for the GTK2 engine, but not the GTK 3 one? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/#review87493 ----------------------------------------------------------- On Oct. 27, 2015, 9:22 a.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125811/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 9:22 a.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: breeze-gtk > > > Description > ------- > > first attempt at detecting gtk 2 pixmap engine as runtime dependency > > but it doesn't work if you set cmake path to different from gtk engine > > and I don't know if it works on distros that use /usr/lib64/ rather than > /usr/lib/x86_86-linux-gnu > > > Diffs > ----- > > CMakeLists.txt 9d7b7a7 > cmake/FindGTKEngine.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125811/diff/ > > > Testing > ------- > > works for me unless I install outwith /usr/ > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
