----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118812/#review60395 -----------------------------------------------------------
So this patch uses hasOpenGLShaderPrograms which doesn't work and QCoreApplication::exit() which doesn't work? That's both the major points of this patch, no? shell/shellcorona.h <https://git.reviewboard.kde.org/r/118812/#comment42116> private? shell/shellcorona.cpp <https://git.reviewboard.kde.org/r/118812/#comment42115> Lets keep this a bit more professional. shell/shellcorona.cpp <https://git.reviewboard.kde.org/r/118812/#comment42117> just QCoreApplication::exit() - David Edmundson On June 18, 2014, 11:36 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118812/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 11:36 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > [plasmashell] Show a warning if there are no Shaders and exit > > If there are no Shaders Plasma doesn't work. If we detect this we show > a warning (without GL) and exit. > > This doesn't really work as Qt has a bug which doesn't allow to detect > whether Shaders are supported and the exit just doesn't work. > > > Diffs > ----- > > shell/shellcorona.h f500e837b5957e14e70ac4b24da0cdf7970a7171 > shell/shellcorona.cpp 4abe3432f30a8c4eb90806893f15c7c50f0e1ac2 > > Diff: https://git.reviewboard.kde.org/r/118812/diff/ > > > Testing > ------- > > With Mesa drivers: > LIBGL_ALWAYS_INDIRECT=1 plasmashell > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
