----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125814/#review87450 -----------------------------------------------------------
kconf_update/main.cpp (line 54) <https://git.reviewboard.kde.org/r/125814/#comment60025> just return a bool? kconf_update/main.cpp (line 65) <https://git.reviewboard.kde.org/r/125814/#comment60026> QStringLiteral -> QLatin1String kconf_update/main.cpp (line 140) <https://git.reviewboard.kde.org/r/125814/#comment60024> Use QStandardPaths to find .config kconf_update/main.cpp (line 171) <https://git.reviewboard.kde.org/r/125814/#comment60022> not needed - David Edmundson On Oct. 26, 2015, 5:40 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125814/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 5:40 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: breeze-gtk > > > Description > ------- > > sets gtk theme to breeze if it's not set or it's using oxygen/orion which > we've set before > > this is moving the code from breeze/misc and updating it for the new theme > > > Diffs > ----- > > CMakeLists.txt b977da8 > kconf_update/CMakeLists.txt PRE-CREATION > kconf_update/gtkbreeze5.5.upd PRE-CREATION > kconf_update/main.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125814/diff/ > > > Testing > ------- > > run the kconf_update script with no gtkrc files and with files set to orion > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
