D29056: [libtaskmanager] add stacking order data for wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c46446e65b98: [libtaskmanager] add stacking order data for wayland (authored by bport). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29056?vs=80774&am

D29056: [libtaskmanager] add stacking order data for wayland

davidedmundson added a comment. assuming others are merged of course REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29056 To: bport, broulik, davidedmundson, zzag, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampa

D29056: [libtaskmanager] add stacking order data for wayland

<https://phabricator.kde.org/D29054> REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29056 AFFECTED FILES libtaskmanager/waylandtasksmodel.cpp To: bport, broulik, davidedmundson, zzag, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbla

D28906: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d25115e4627: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28906?vs=80357&id=80372

D28906: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. beautiful REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28906 To: broulik, #plasma, hein, davidedmundson Cc: davidedmundson, plasma-deve

D28906: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob

REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28906 AFFECTED FILES libtaskmanager/CMakeLists.txt libtaskmanager/launchertasksmodel.cpp libtaskmanager/tasktools.cpp libtaskmanager/waylandtasksmodel.cpp libtaskmanager/xwindowtasksmodel.cpp To: broulik

D28146: [applets/appmenu] Use libtaskmanager for appmenus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d8d079e42e62: [applets/appmenu] Use libtaskmanager for appmenus (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28146?vs=78047&am

D28146: [applets/appmenu] Use libtaskmanager for appmenus

cblack updated this revision to Diff 78047. cblack marked 2 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28146?vs=78040&id=78047 BRANCH appmenu-use-libtm (branched from master)

D28146: [applets/appmenu] Use libtaskmanager for appmenus

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > appmenumodel.cpp:124 > +m_tasksModel->setScreenGeometry(geometry); > emit screenGeometryChanged(); > } I think you can just connect this signal to our signa

D28146: [applets/appmenu] Use libtaskmanager for appmenus

cblack added a comment. In D28146#630781 , @broulik wrote: > When filtering by screen, this now means we get appmenu only when the active window is on the same screen? Not sure if this is what we want? > (Perhaps we could do some clever "last

D28146: [applets/appmenu] Use libtaskmanager for appmenus

cblack updated this revision to Diff 78040. cblack added a comment. Remove extraneous change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28146?vs=78039&id=78040 BRANCH appmenu-use-libtm (branched from master) REVISION DETAIL https://phabri

D28146: [applets/appmenu] Use libtaskmanager for appmenus

ster) REVISION DETAIL https://phabricator.kde.org/D28146 AFFECTED FILES applets/appmenu/lib/CMakeLists.txt applets/appmenu/plugin/CMakeLists.txt applets/appmenu/plugin/appmenumodel.cpp applets/appmenu/plugin/appmenumodel.h libtaskmanager/waylandtasksmodel.cpp To: cblack, #plasm

D28146: [applets/appmenu] Use libtaskmanager for appmenus

cblack marked an inline comment as done. cblack added inline comments. INLINE COMMENTS > broulik wrote in CMakeLists.txt:15 > Unused Linkage fails without it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28146 To: cblack, #plasma Cc: broulik, plasma-devel,

D28146: [applets/appmenu] Use libtaskmanager for appmenus

have per-screen global menu? :D) INLINE COMMENTS > CMakeLists.txt:15 > + KF5::WindowSystem > + PW::LibTaskManager) > Unused > appmenumodel.cpp:69 > > -connect(this, &AppMenuModel::screenGeometryChanged, this,

D28146: [applets/appmenu] Use libtaskmanager for appmenus

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This patch ports the appmenu applet to use libtaskmanager. TEST PLAN Ensure that there aren&#

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5e7d26dc5e38: [libtaskmanager] Add ApplicationMenu{ObjectPath,ServiceName} roles to model (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 78032. cblack marked 2 inline comments as done. cblack added a comment. Address last feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77950&id=78032 BRANCH cblack/appmenu-libtaskman

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

rk, so `5.19` it is. > xwindowtasksmodel.cpp:472 > +{ > +auto info = windowInfo(window); > +return QString::fromUtf8(info->applicationMenuServiceName()); `const KWindowInfo *` to match the rest of the code REPOSITORY R120 Plasma Workspace BRANCH cblack/appmenu-libtaskm

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 77950. cblack marked 4 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77930&id=77950 BRANCH cblack/appmenu-libtaskmanager (bran

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 77930. cblack added a comment. Drop unused linkage REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77924&id=77930 BRANCH cblack/appmenu-libtaskmanager (branched from master) REVISION DETAIL h

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:60 > Qt5::X11Extras > +XCB::XCB > KF5::IconThemes) Unused REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik, plasma-devel

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. Nice job INLINE COMMENTS > abstracttasksmodel.h:99 > LastActivated,/**< The timestamp of the last time a task was the > active task. */ > +ApplicationMenuServiceName, /**< The DBus service name for the > application's menu. > +

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 77924. cblack added a comment. Use new KWindowInfo APIs REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77835&id=77924 BRANCH cblack/appmenu-libtaskmanager (branched from master) REVISION DE

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. I think if you added those properties `KWindowInfo`, you'd get change events, cache eviction, less manual X code basically for free :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik, plasma-dev

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 77835. cblack added a comment. Don't double lookup cached appmenus REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77834&id=77835 BRANCH cblack/appmenu-libtaskmanager (branched from master)

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack added a comment. In D27959#629133 , @broulik wrote: > I think you should cache the X props, otherwise every `data` access causes a round trip to the X server. Implemented a cache for appmenus, but as I don't know what to listen to

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 77834. cblack marked 5 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77681&id=77834 BRANCH cblack/appmenu-libtaskmanager (bran

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. I think you should cache the X props, otherwise every `data` access causes a round trip to the X server. INLINE COMMENTS > xwindowtasksmodel.cpp:472 > > +static const QByteArray s_x11AppMenuServiceNamePropertyName = > QByteArrayLiteral("_KDE_NET_WM_APPMENU_SERVICE

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 77681. cblack added a comment. Add X11 data to model REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77322&id=77681 BRANCH cblack/appmenu-libtaskmanager (branched from master) REVISION DE

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, leslie

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack added a comment. In D27959#625053 , @broulik wrote: > Can we make the dbus service role name more generic? GTK has a generic DBus prop on the window, too. Both the `org.gtk.Actions` and the `org.gtk.Menus` dbus interfaces exposed b

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack added a comment. In D27959#625055 , @broulik wrote: > For X check out the appmenu applet: https://cgit.kde.org/plasma-workspace.git/tree/applets/appmenu/plugin/appmenumodel.cpp#n164 > > I was wondering if we should maybe add that to `N

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. For X check out the appmenu applet: https://cgit.kde.org/plasma-workspace.git/tree/applets/appmenu/plugin/appmenumodel.cpp#n164 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik, plasma-devel, Ora

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. Can we make the dbus service role name more generic? GTK has a generic DBus prop on the window, too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

only implemented for Wayland; as I don't have a clue what to do on XOrg. TEST PLAN See that the model has more roles and see that they're wired to the application menu obiect path and service name on Wayland. REPOSITORY R120 Plasma Workspace BRANCH cblack/appmenu-libtaskmanager

D27266: [libtaskmanager] Fix shared VirtualDesktopInfo::Private tied to the 1st creator

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8b3788ba3389: [libtaskmanager] Fix shared VirtualDesktopInfo::Private tied to the 1st creator (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https

D27266: [libtaskmanager] Fix shared VirtualDesktopInfo::Private tied to the 1st creator

ter REVISION DETAIL https://phabricator.kde.org/D27266 AFFECTED FILES libtaskmanager/virtualdesktopinfo.cpp To: davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesl

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:c0acd1434147: [libtaskmanager] Track stacking order and window activation (on X11) (authored by hein).

D24268: [libtaskmanager] Port to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0d9e0bce94af: [libtaskmanager] Port to new connect syntax (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24268?vs=66962&am

D24268: [libtaskmanager] Port to new connect syntax

regardless, so it seemed superfluous. TEST PLAN Compiles Opened N dolphins They were still grouped REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24268 AFFECTED FILES libtaskmanager/taskgroupingproxymodel.cpp To: davidedmundson, #plasma Cc: plasma-devel

D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4f309328ee00: libtaskmanager: fix launch url for startup info with pathless desktop file (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23417?vs=64529&id=64665

D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. :/ good catch. INLINE COMMENTS > startuptasksmodel.cpp:178 > +// drop ".desktop" suffix > +appId.chop(8); > I quite like doing appId.chop(strlen(

D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

been checked before Seen while browsing code, no app known to me which would set a non-absolute desktop file. REPOSITORY R120 Plasma Workspace BRANCH fixsuffixchopping REVISION DETAIL https://phabricator.kde.org/D23417 AFFECTED FILES libtaskmanager/startuptasksmodel.cpp To

D23185: [libtaskmanager] Port to lighter KProcessList

This revision was automatically updated to reflect the committed changes. Closed by commit R120:83ca6de8fcd7: [libtaskmanager] Port to lighter KProcessList (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23185?vs=63814&am

D23185: [libtaskmanager] Port to lighter KProcessList

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23185 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-

D23185: [libtaskmanager] Port to lighter KProcessList

libksysguard dependency into libtaskmanager. I also checked that we don't have a space at the end of the command. That appears to be a relic from an older time. TEST PLAN Unit tests exist on KProcessList. Task manager applications appear fine, I don't know any good edge cases that

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

davidedmundson added a comment. One minor comment, and anthonyfieroni's comment, and this is good to go. INLINE COMMENTS > xwindowtasksmodel.cpp:203 > +cachedStackingOrder = KWindowSystem::stackingOrder(); > +q->dataChanged(q->index(0, 0), q->index(q->rowCount() - 1, 0

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

pino added inline comments. INLINE COMMENTS > anthonyfieroni wrote in xwindowtasksmodel.cpp:673-675 > That's double lookup in intensive called function, what about > > int idx = d->lastActivated.indexOf(window); > if (idx >= 0) >return d->lastActivated.at(idx); @anthonyfieroni `d->l

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

anthonyfieroni added inline comments. INLINE COMMENTS > xwindowtasksmodel.cpp:673-675 > +if (d->lastActivated.contains(window)) { > +return d->lastActivated.value(window); > +} That's double lookup in intensive called function, what about int idx = d->lastActivated

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

then implement the new API in here. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D22053 AFFECTED FILES libtaskmanager/abstracttasksmodel.h libtaskmanager/taskgroupingproxymodel.cpp libtaskmanager/xwindowtasksmodel.cpp To: hein, #plasma Cc: ng

D18727: [Icon Applet] Use libTaskManager for startup feedback

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4c211cbf885a: [Icon Applet] Use libTaskManager for startup feedback (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18727?vs=50857&id=50880#toc REPOSITORY R120 Pl

D18727: [Icon Applet] Use libTaskManager for startup feedback

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in iconapplet.cpp:404 > should this be index(i, 0) ? Good spot, indeed REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18727 To: broulik, #plasma, hein Cc: davidedmundson, plasma-devel, jr

D18727: [Icon Applet] Use libTaskManager for startup feedback

davidedmundson added inline comments. INLINE COMMENTS > iconapplet.cpp:404 > +for (int i = first; i <= last; ++i) { > +const QModelIndex idx = m_startupTasksModel->index(first, 0); > +if > (idx.data(TaskManager::AbstractTasksModel::LauncherUrlWithoutIc

D18727: [Icon Applet] Use libTaskManager for startup feedback

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. ❤ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18727 To: broulik, #plasma, hein Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali

D18727: [Icon Applet] Use libTaskManager for startup feedback

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it future-proof for Wayland TEST PLAN (and Eike happy) - still works the same

D18375: Adjust Latte Dock to libtaskmanager API changes for Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R878:f6ce06f6ae83: Adjust Latte Dock to libtaskmanager API changes for Wayland (authored by scoenen, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https

D18375: Adjust Latte Dock to libtaskmanager API changes for Wayland

mvourlakos added a comment. looks ok, do you think that VirtualDesktop changes should go to another commit? based on https://github.com/KDE/plasma-desktop/commit/b0d6eab4a698809ff9f5b7244a975ac467222508 ? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D1837

D18375: Adjust Latte Dock to libtaskmanager API changes for Wayland

scoenen created this revision. scoenen added a reviewer: mvourlakos. scoenen added a project: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. scoenen requested review of this revision. REVISION SUMMARY Changes in libtaskmanager in Plasma 5.15 currently break

D15599: Port the "Switch Desktop" containment action to libtaskmanager

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6e41b8d98e06: Port the "Switch Desktop" containment action to libtaskmanager (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c64fc46955f2: Port "Switch Window" containment action to updated libtaskmanager API and away… (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDA

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c92b97fe9390: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13748?vs=38112&id=47753

D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b0d6eab4a698: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop… (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 44096. hein added a comment. Fix off-by-one. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=43811&id=44096 BRANCH arcpatch-D15599 REVISION DETAIL https://phabricator.kde.org/D15599 AFFECTED FILES

D15599: Port the "Switch Desktop" containment action to libtaskmanager

zzag added inline comments. INLINE COMMENTS > desktop.cpp:58 > } else if (m_actions.count() > numDesktops) { > -for (int i = numDesktops +1; i <= m_actions.count(); ++i) { > -delete m_actions[i]; > -m_actions.remove(i); > +for (int i = m_actions.count(

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein added a comment. Ping? INLINE COMMENTS > davidedmundson wrote in desktop.cpp:59 > Use of the & is weird. I know the containers are implicitly shared, but I consider it better coding style to do the correct C++ thing out of habit rather than rely on that. REPOSITORY R120 Plasma Works

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 43811. hein added a comment. Remove two arg() fixes in the diff that should be in the other containment action diff REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=43810&id=43811 BRANCH arcpatch-D15599

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 43810. hein added a comment. - Fix another arg() call - Do delete+remove in one step with take() - Fix loop condition Addressing other review comments: - More change tracking is not needed because of the later loop that indiscriminately calls se

D15599: Port the "Switch Desktop" containment action to libtaskmanager

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > zzag wrote in desktop.cpp:73 > I didn't test it, but I think this one would be better: > > qDeleteAll(m_actions.begin() + numDesktops, m_act

D15599: Port the "Switch Desktop" containment action to libtaskmanager

zzag added inline comments. INLINE COMMENTS > zzag wrote in desktop.cpp:73 > Could someone please explain why this part is fine? I didn't test it, but I think this one would be better: qDeleteAll(m_actions.begin() + numDesktops, m_actions.end()); m_actions.resize(numDesktops); REPOSITORY

D15599: Port the "Switch Desktop" containment action to libtaskmanager

zzag added inline comments. INLINE COMMENTS > zzag wrote in desktop.cpp:73 > Will this loop ever be executed? > > Also, why not `delete m_actions.take(i - 1);`? Could someone please explain why this part is fine? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D15599 REVISION DETAIL h

D15599: Port the "Switch Desktop" containment action to libtaskmanager

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > to make d_ed happy It worked REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D15599 REVISION DETAIL https://phabricator.kde.org/D15599 To: hein, mart, davide

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 43754. hein added a comment. Don't keep VirtualDesktopInfo as a static member to make d_ed happy REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=43753&id=43754 BRANCH arcpatch-D15599 REVISION DETAIL

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 43753. hein added a comment. Fix two more uses of arg() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=42600&id=43753 BRANCH arcpatch-D15599 REVISION DETAIL https://phabricator.kde.org/D15599 AFFEC

D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem

hein updated this revision to Diff 43752. hein added a comment. - Make `doSwitch` wrap again - Don't keep the VirtualDesktopsInfo as a static member to make d_ed happy - Use the multi-argument arg() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > switch.cpp:203 > +if (desktops.contains(desktop)) { > +const QString &name = QStringLiteral("%1: > %2").ar

D15599: Port the "Switch Desktop" containment action to libtaskmanager

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > davidedmundson wrote in desktop.cpp:46 > In the other patch VirtualDesktopInfo has a shared d ptr across all instances. > > There's no point m

D15599: Port the "Switch Desktop" containment action to libtaskmanager

zzag added inline comments. INLINE COMMENTS > desktop.cpp:73 > } else if (m_actions.count() > numDesktops) { > -for (int i = numDesktops +1; i <= m_actions.count(); ++i) { > -delete m_actions[i]; > -m_actions.remove(i); > +for (int i = m_actions.count(

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 42600. hein added a comment. Fix calculating next/prev desktop index REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=42597&id=42600 BRANCH switchdesktop REVISION DETAIL https://phabricator.kde.org/D1

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 42597. hein added a comment. Fix list access out of bounds REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=41997&id=42597 BRANCH switchdesktop REVISION DETAIL https://phabricator.kde.org/D15599 AFFE

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pagermodel.cpp:444 > for (auto windowModel : d->windowModels) { > -windowModel->setVirtualDesktop(0); > +windowModel->setVirtualDesktop(); >

D15599: Port the "Switch Desktop" containment action to libtaskmanager

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > desktop.cpp:59 > +const QVariantList &desktopIds = s_virtualDesktopInfo->desktopIds(); > +const QStringList &desktopNames = s_virtualDe

D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem

hein created this revision. hein added reviewers: mart, davidedmundson. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This makes it work on Wayland. And probably fixes bugs, the code, especially the next/prev window stuff, was pretty wonky. Also

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 41997. hein added a comment. Fix wrong conditional. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=41932&id=41997 BRANCH arcpatch-D13745 REVISION DETAIL https://phabricator.kde.org/D15599 AFFECTED

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein added inline comments. INLINE COMMENTS > broulik wrote in desktop.cpp:65 > This codes doesn't take into account when the virtual desktop names change > etc. I think it should re-create the actions every time, and not try to be > "smart" by only changing the ones that are "superfluous" or "

D15599: Port the "Switch Desktop" containment action to libtaskmanager

broulik added inline comments. INLINE COMMENTS > desktop.cpp:46 > + > +if (!s_virtualDesktopInfo) { > +delete s_virtualDesktopInfo; `!s_instanceCount` > desktop.cpp:65 > > -//Is it either the first time or the desktop number changed? > if (m_actions.count() < numDesktops)

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 41932. hein added a comment. Kill more unused stuff. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=41931&id=41932 BRANCH arcpatch-D13745 REVISION DETAIL https://phabricator.kde.org/D15599 AFFECTED

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 41931. hein added a comment. Remove another unused include. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=41930&id=41931 BRANCH arcpatch-D13745 REVISION DETAIL https://phabricator.kde.org/D15599 A

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein created this revision. hein added reviewers: mart, davidedmundson. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This: - Makes it work on Wayland. Depends on D13745 . - Cleans up includes and linkage. -

D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support

hein updated this revision to Diff 38113. hein added a comment. Code cleanup in MouseHandler REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13746?vs=37208&id=38113 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13746 AFFECTED FILES

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

hein updated this revision to Diff 38112. hein added a comment. Various window DND Fixes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13748?vs=37207&id=38112 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13748 AFFECTED FILES a

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

hein added a comment. The change would have to be in the libtm patch. But the filter model hasn't changed, all I've done in the libtm patch is that initial population loop thing in VirtualDesktopInfo. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13748 To:

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

mart added a comment. with latest version (don't know if depends from this or libtaskmanager) i get desktops only on a single pager cell REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13748 To: hein, mart Cc: plasma-devel, ragreen, Pitel, Zr

D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support

hein updated this revision to Diff 37208. hein edited the summary of this revision. hein added a comment. Make "New Desktop" task context menu action work on Wayland. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13746?vs=36726&id=37208 BRANCH ma

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

hein updated this revision to Diff 37207. hein edited the summary of this revision. hein added a comment. - Update message. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13748?vs=37204&id=37207 BRANCH master REVISION DETAIL https://phabricator

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

hein updated this revision to Diff 37204. hein added a comment. - Enable Add/Remove Desktop actions on Wayland using new libtm API. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13748?vs=36727&id=37204 BRANCH master REVISION DETAIL https://pha

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

hein created this revision. hein added a reviewer: mart. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Missing: - The KWayland API has no way to add/remove desktops yet - The KWayland API has no way to move windows yet Depend

D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support

hein updated this revision to Diff 36726. hein added a comment. Remove accidental CMakeLists.txt change. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13746?vs=36725&id=36726 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13746 AF

D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support

hein updated this revision to Diff 36725. hein retitled this revision from "Adjust to libtaskmanager API changes for Wayland virtual desktop support" to "Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support". hein added a comment. Unamb

D13746: Adjust to libtaskmanager API changes for Wayland virtual desktop support

hein created this revision. hein added a reviewer: mart. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Missing: - The Move to -> New Desktop action is not supported by the protocol yet and currently hidden on Wayland. Depends

D13070: [libtaskmanager] Add missing QUrlQuery includes

TAIL https://phabricator.kde.org/D13070 AFFECTED FILES libtaskmanager/launchertasksmodel.cpp libtaskmanager/tasktools.cpp libtaskmanager/xwindowtasksmodel.cpp To: cfeck, #plasma, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

  1   2   3   4   >