broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> appmenumodel.cpp:124
> + m_tasksModel->setScreenGeometry(geometry);
> emit screenGeometryChanged();
> }
I think you can just connect this signal to our signal in the constructor and
then remove the if check here
> appmenumodel.cpp:150
>
> - if (!id) {
> - setMenuAvailable(false);
> + if ((!objectPath.isEmpty()) && (!serviceName.isEmpty())) {
> + setMenuAvailable(true);
No need for parentheses
REPOSITORY
R120 Plasma Workspace
BRANCH
appmenu-use-libtm (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28146
To: cblack, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
