davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > switch.cpp:203 > + if (desktops.contains(desktop)) { > + const QString &name = QStringLiteral("%1: > %2").arg(i).arg(desktopNames.at(i)); > QMenu *subMenu = new QMenu(name); .arg(i, desktopNames.at(i) in case the id contains the string "%1" (and above) > switch.cpp:264 > + if (up) { > + const QModelIndex &next = activeTask.sibling(activeTask.row() + 1, > 0); > The old code wrapped (albeit in a weirdly coded way) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15642 To: hein, mart, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart