mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> pagermodel.cpp:444
> for (auto windowModel : d->windowModels) {
> - windowModel->setVirtualDesktop(0);
> + windowModel->setVirtualDesktop();
>
would it be possible to avoid default arguments?
> pagermodel.cpp:642
> + if (!winIds.isEmpty() && winIds.at(0).toUInt() == id) {
> + tasksModel->requestVirtualDesktops(idx,
> QVariantList() << itemId.toString());
> + break;
{} initializer?
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13748
To: hein, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
