hein added inline comments.

INLINE COMMENTS

> broulik wrote in desktop.cpp:65
> This codes doesn't take into account when the virtual desktop names change 
> etc. I think it should re-create the actions every time, and not try to be 
> "smart" by only changing the ones that are "superfluous" or "missing" as the 
> names and order inbetween could have changed

You misread the diff. This was indeed a bug the old code has, but the new code 
sets the text and data on all actions every time (below).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15599

To: hein, mart, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to