Re: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.12 - Build # 95 - Failure!

Ben Cooksley , 25 Mar 2020 Çar, 07:48 tarihinde şunu yazdı: > The Dependency Build says plasma-desktop is broken. > > Ideas anyone? > > Hello ben, It looks like this will solve that problem : https://phabricator.kde.org/D28232 Could you apply that patch and try if it fixes the problem? And the pr

Fwd: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.12 - Build # 95 - Failure!

The Dependency Build says plasma-desktop is broken. Ideas anyone? Cheers, Ben -- Forwarded message - From: CI System Date: Wed, Mar 25, 2020 at 4:24 PM Subject: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.12 - Build # 95 - Failure! To: *BUILD FAILURE* Bui

D28154: Add users KCM

ngraham added a comment. FWIW deleting a user doesn't work for me. When I click the Delete User button, in the console I see: file:///home/nate/kde/usr/share/kpackage/kcms/user_manager/contents/ui/UserDetailsPage.qml:177: TypeError: Cannot read property 'uid' of undefined Also I

Re: KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Failing!

On Wed, Mar 25, 2020 at 12:05 PM David Edmundson wrote: > > Briefly investigated, it seems another false positive of frameworks being out > of sync which will resolve itself. This means that Plasma has introduced API into Frameworks and then rapidly proceeded with making use of it - so it is a v

Re: KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Failing!

Briefly investigated, it seems another false positive of frameworks being out of sync which will resolve itself. David

D28262: [applets/analog-clock] Optional minute hand

kossebau resigned from this revision. kossebau added a comment. Resigning, due to currently not having time for Plasma development. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28262 To: aloiseau, #vdg, #plasma Cc: ngraham, aloiseau, plasma-devel, Orage,

D28262: [applets/analog-clock] Optional minute hand

ngraham edited reviewers, added: VDG, Plasma; removed: Plasma: Workspaces. ngraham added a comment. Thanks for the patch, Anthony! Technical comment: you need to update the kcfg file too, to add a definition of the new option. Conceptual/UI comment: do you think you could explain the

D28262: [applets/analog-clock] Optional minute hand

aloiseau created this revision. aloiseau added reviewers: Plasma: Workspaces, kossebau. aloiseau added a project: Plasma: Workspaces. Herald edited projects, added Plasma; removed Plasma: Workspaces. Herald added a subscriber: plasma-devel. aloiseau requested review of this revision. REVISION SUMM

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. > Some of the icons are not rendering now, for example: > Discord - iconName: chrome_app_indicator2_83406baa15c6e4f2766a6e3714fbee20 > Skype1 - iconName: chrome_app_indicator2_01cdeaaa54803d9c9c158a5cdcb1fbfb > I'm pretty sure I saw a workaround for that somew

D28259: [applets/systemtray] Default value for ItemLoader.source

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5b99315f75f9: [applets/systemtray] Default value for ItemLoader.source (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28259?vs=7840

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. Two problems: After running `plasmashell --replace &` I have these messages in the console output: > file:///home/konrad/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/items/StatusNotifierItem.qml:57:5: QML IconItem: Cannot an

D28259: [applets/systemtray] Default value for ItemLoader.source

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma. Herald added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY When none of the valid conditions are met, function should return default value for ItemLoader source. If not, error

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 805 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/805/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Mar 2020 20:40:08 + Build duration: 4 min 36 sec and counting CONSOLE OUTPUT [...truncate

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 24 Mar 2020 20:40:08 + Build duration: 1 min 25 sec and counting CONSOLE OUTPUT [...trun

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7498b41a1979: [Baloo KCM] Complete overhaul of the include/exclude folder list (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=7

D28154: Add users KCM

cblack updated this revision to Diff 78394. cblack added a comment. Add boilerplate code for a KAuth helper to prepare for adding groups support REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=78387&id=78394 BRANCH cblack/userkcm-ng (branc

D28154: Add users KCM

cblack updated this revision to Diff 78387. cblack marked 6 inline comments as done. cblack added a comment. Address feedback and fix issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=78364&id=78387 BRANCH cblack/userkcm-ng (branched

D28109: [applets/systemtray] Simplify icon size logic

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a9d941b38e05: [applets/systemtray] Simplify icon size logic (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28109?vs=78185&id=78386

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 78384. davidre marked 6 inline comments as done. davidre added a comment. Use Math.floor REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78298&id=78384 BRANCH sni (branched from master) REVISION DET

KDE CI: Plasma » kdeplasma-addons » kf5-qt5 SUSEQt5.12 - Build # 198 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/kf5-qt5%20SUSEQt5.12/198/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Mar 2020 17:02:36 + Build duration: 15 min and counting BUILD ARTIFACTS acc/PlasmaPotdP

KDE CI: Plasma » kdeplasma-addons » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 24 Mar 2020 17:02:36 + Build duration: 1 min 19 sec and counting JUnit Tests Name: pro

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

davidedmundson added a comment. My fault, I'll fix it REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma, ngraham, broulik, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbam

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex added a comment. Sh**t, should I make a new patch to fix this? And sorry ... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma, ngraham, broulik, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

ngraham added a comment. This broke the CI: [2020-03-24T15:59:18.523Z] [ 66%] Linking CXX shared module ../../bin/krunner_datetime.so [2020-03-24T15:59:18.523Z] /usr/home/jenkins/workspace/Plasma/kdeplasma-addons/kf5-qt5 FreeBSDQt5.14/runners/spellchecker/spellcheck.cpp:198:30: er

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 78372. ahiemstra added a comment. - Add some documentation to classes - Properly install the export header - Don't use PUBLIC_HEADERS, it's not well supported on earlier CMake - Rebase, update SensorInfo and Daemon XML to new versions REPOSITORY

KDE CI: Plasma » kdeplasma-addons » kf5-qt5 SUSEQt5.12 - Build # 197 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/kf5-qt5%20SUSEQt5.12/197/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Mar 2020 15:57:31 + Build duration: 2 min 14 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Plasma » kdeplasma-addons » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 24 Mar 2020 15:57:31 + Build duration: 1 min 52 sec and counting CONSOLE OUTPUT [...tr

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

This revision was automatically updated to reflect the committed changes. Closed by commit R114:5e760a0586bb: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call (authored by davidedmundson, committed by alex). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex added a comment. Thanks! REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma, ngraham, broulik, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouka

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

davidedmundson updated this revision to Diff 78368. davidedmundson added a comment. Rebase REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=78336&id=78368 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D28172: [applets/digital-clock] Fix date sizing in vertical panel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:01691632b523: [applets/digital-clock] Fix date sizing in vertical panel (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28172?vs=7836

D28172: [applets/digital-clock] Fix date sizing in vertical panel

ngraham updated this revision to Diff 78366. ngraham added a comment. Restore elision property REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28172?vs=78126&id=78366 BRANCH fix-vertical-panel-date-text-sizing (branched from Plasma/5.18) REVISIO

D28172: [applets/digital-clock] Fix date sizing in vertical panel

davidedmundson accepted this revision. davidedmundson added a comment. You probably still want the elide. We have a word wrap on, so you'll only hit this elide option when the alternative is paint outside the area and just leak over other items in the system tray. That always looks rubbi

D28154: Add users KCM

cblack updated this revision to Diff 78364. cblack added a comment. Use better icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=78135&id=78364 BRANCH cblack/userkcm-ng (branched from master) REVISION DETAIL https://phabricator.kde.o

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex added a comment. Small issue: Currently this patch can't be applied (from the master branch) because in R114:47381a65debe01a0a015e1aa423cbb78af649648 the line: `QStringList terms = query.split(QLatin1Char(' '

D28238: Stop multiplying duration values

ngraham added a comment. In D28238#633505 , @cblack wrote: > I'm not sure where you can see the changes to `ActionButton.qml` and `UserDelegate.qml`. the lock, logout, and login screens REPOSITORY R120 Plasma Workspace BRANCH use-st

D28140: Add a declarative plugin to ProcessCore

ahiemstra updated this revision to Diff 78360. ahiemstra added a comment. - Rebase, Expose ProcessDataModel and ProcessAttributeModel as well REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28140?vs=78013&id=78360 BRANCH processcore_declarative

D28238: Stop multiplying duration values

cblack accepted this revision as: Plasma, cblack. cblack added a comment. This revision is now accepted and ready to land. Code looks good to me, but I haven't looked at how these changes look visually. These are where these changes will be visible, right? - Clicking a device in the sys

D28238: Stop multiplying duration values

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY After D28144 , some animations are now too long because t

D28239: Stop multiplying duration values

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY After D28144 , some animations are now too long because t

D28236: [applet/taskmanager] Remove unnecessary icon size values set on PC3 toolbuttons

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY `units.iconSizes.smallMedium` is the default size, so setting the icon size to this has no e

D28135: Port away from deprecated QSet/QList methods in some places

ahmadsamir updated this revision to Diff 78355. ahmadsamir added a comment. QStringList has a sort() method REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28135?vs=77979&id=78355 BRANCH l-qset-fromlist (branched from master) REVISION DETAIL h

D28234: Use SyntaxHighlighter for highlighting

apol added a comment. F8196700: Screenshot_20200324_145906.png REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D28234 To: apol, #plasma, sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fba

D28234: Use SyntaxHighlighter for highlighting

apol created this revision. apol added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The code is especially fiddly and complex. Using this we can on the other hand leverage other part

D27972: [NightColor] fix for plasmoid status and tooltip subtext

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In D27972#633289 , @zzag wrote: > > in "Always on" manual mode: when active (not inhibited) > > I still don't understand why we

[systemsettings] [Bug 418949] plymouth-theme-breeze should have a background/wallpaper option

https://bugs.kde.org/show_bug.cgi?id=418949 Harald Sitter changed: What|Removed |Added Component|Plymouth|kcm_plymouth Product|Breeze

D28215: [RFC]: WIP: Make mobile broadband actually functional

broulik added inline comments. INLINE COMMENTS > mobileproviders.h:31 > > -class MobileProviders > +class MobileProviders : public QObject > { Needs `Q_OBJECT` macro > mobileproviders.h:38 > > -MobileProviders(); > +MobileProviders(QObject* parent = 0); > ~MobileProviders();

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

ahmadsamir added a comment. Should be fixed by D28232 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27503 To: bport, #plasma, meven, crossi, ervin Cc: usta, ahmadsamir, ngraham, plasma-devel, Orage, LeGast00n, The-Feren

D28232: [SpellChecking KCM] Fix the build

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, bport, meven, crossi, ervin. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY QList/QSet iterator-based ctors are available since Qt 5.14, so we could make the code conditional b

D27509: Introduce ProcessDataModel

This revision was automatically updated to reflect the committed changes. Closed by commit R111:834de9a585c6: Introduce ProcessDataModel (authored by davidedmundson). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27509?vs=78091&id=78346 REVISION DE

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

This revision was automatically updated to reflect the committed changes. Closed by commit R120:dceb791c0779: WebShortcuts Runner: Refactor foreach, remove unnecessary method (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27566?vs=

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

alex updated this revision to Diff 78338. alex added a comment. Coding style: put space before { REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27566?vs=76144&id=78338 BRANCH arcpatch-D27566 REVISION DETAIL https://phabricator.kde.org/D27566

D28216: [VirtualDesktopInfo] Connect to rowsChanged singal

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf28d5d2b4f4: [VirtualDesktopInfo] Connect to rowsChanged singal (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28216?vs=78273&id=78

D27972: [NightColor] fix for plasmoid status and tooltip subtext

zzag added a comment. > in "Always on" manual mode: when active (not inhibited) I still don't understand why we should hide the applet. If VDG is okay with such behavior, then feel free to push this change, I won't object or anything. INLINE COMMENTS > main.qml:26 > > +import org.kde.

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

broulik accepted this revision. broulik added inline comments. INLINE COMMENTS > webshortcutrunner.cpp:79 > const int delimIndex = term.indexOf(m_delimiter); > -if (delimIndex == term.length() - 1) > +if (delimIndex == -1 || delimIndex == term.length() - 1){ > return; Codin

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

alex added a comment. Ping @broulik :-) REPOSITORY R120 Plasma Workspace BRANCH webshortcuts_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27566 To: alex, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D26799: Apply KDE coding style, minor optimizations

alex abandoned this revision. alex added a comment. Abandoning this, because there have been a few patches to the same kcm and this is mostly formatting. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26799 To: alex, ngraham, meven, davidedmundson Cc: davide

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 78336. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=78335&id=78336 REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES runners/spellchecker/spellcheck.cpp runners/spellchecker/spellcheck.

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 78335. alex added a comment. Minor improvements I had another look at the project and changed some other things: - optimize some overloads with QStringLiteral/QLatin1String - rename loaddata to loadData - remove the unnecessary check for the acti