ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, bport, meven, crossi, ervin. Herald added a project: Plasma. ahmadsamir requested review of this revision.
REVISION SUMMARY QList/QSet iterator-based ctors are available since Qt 5.14, so we could make the code conditional based on that to keep it building against older Qt versions. However I think the reason behind converting from QStringList to QSet was to remove duplicates, so use QStringList::removeDuplicates() and sort() instead. Bump KF5 min. required version to 5.69.0 because of Sonnet/ConfigView which first appeared in that version. TEST PLAN make && ctest REPOSITORY R119 Plasma Desktop BRANCH l-fix-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D28232 AFFECTED FILES CMakeLists.txt kcms/spellchecking/spellchecking.cpp To: ahmadsamir, #plasma, bport, meven, crossi, ervin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart