broulik added inline comments.
INLINE COMMENTS
> mobileproviders.h:31
>
> -class MobileProviders
> +class MobileProviders : public QObject
> {
Needs `Q_OBJECT` macro
> mobileproviders.h:38
>
> - MobileProviders();
> + MobileProviders(QObject* parent = 0);
> ~MobileProviders();
`explicit MobileProviders(QObject *parent = nullptr);`
> mobilebroadbandsettings.cpp:109
> + // no modem detected
> + return "";
> + }
`return QString();`
> mobilebroadbandsettings.h:39
> void setupMobileNetwork();
> - Q_INVOKABLE QString getAPN();
> + Q_INVOKABLE QString getProvider();
>
`const`
> main.qml:70
> + }*/
> + Repeater {
> + enabled: mobileDataCheckbox.enabled
You sure you want to use a `Repeater` for this? Or how large can that list
become?
> main.qml:76
> + text: modelData
> + checked: false
> + onCheckedChanged: {
Doesn't this have to be bound to something?
> main.qml:77
> + checked: false
> + onCheckedChanged: {
> + if (checked) {
Use `onToggled`
> main.qml:79
> + if (checked) {
> + qDebug() << "Activating " << modelData;
> + // activating this provider then:
> kcm.setupMobileNetwork(model)
This is QML, not C++ :)
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D28215
To: bshah, jgrulich
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
