ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
In D27972#633289 <https://phabricator.kde.org/D27972#633289>, @zzag wrote: > > in "Always on" manual mode: when active (not inhibited) > > I still don't understand why we should hide the applet. If VDG is okay with such behavior, then feel free to push this change, I won't object or anything. Actually yeah, I agree with this. I didn't notice that change, sorry. If the user has deliberately turned it always on, then having the tray icon always active by default makes it into a quick on/off toggle, which I think is handy. Sorry for missing this with my earlier review. REVISION DETAIL https://phabricator.kde.org/D27972 To: pdabrowski, #plasma, zzag, ngraham, #vdg Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart