alex updated this revision to Diff 78335. alex added a comment.
Minor improvements I had another look at the project and changed some other things: - optimize some overloads with QStringLiteral/QLatin1String - rename loaddata to loadData - remove the unnecessary check for the action in the run method - reuse the result of config() - make sure that the trigger word can only be required if it is not empty REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74848&id=78335 BRANCH arcpatch-D27070 REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES CMakeLists.txt runners/converter/CMakeLists.txt runners/converter/autotests/CMakeLists.txt runners/converter/autotests/converterrunnertest.cpp runners/converter/converterrunner.cpp runners/converter/converterrunner.h runners/spellchecker/spellcheck.cpp runners/spellchecker/spellcheck.h runners/spellchecker/spellcheck_config.cpp To: alex, #plasma, ngraham, broulik, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
