D18890: Add button to reset index database and repair Baloo crashing

bruns added a comment. In D18890#410137 , @davidedmundson wrote: > If we know the DB is corrupted, and it's just a cache, why do we need a user facing button? There are many possible ways of corruption: - non-decodable values - en

D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode

hein updated this revision to Diff 52695. hein added a comment. This revision is now accepted and ready to land. SortDesktop needs to fall through to alphabetic sorting within a desktop. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19259?vs=52390

D19370: [sddm-theme] Add circles behind action buttons

rooty added a comment. 1 and 0.9 are too dark imo, we should aim for lower values REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19370 To: filipf, #vdg, ngraham, rooty, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D19379: [sddm-theme] Add a bottom panel

rooty added a comment. Hey can you please rename the footer background to footerBackground because footer's used elsewhere id: footer to id: footerBackground And rename footerLayout back to footer, because it's used in sddm (Connections, line 355). Also, you might wa

D19379: [sddm-theme] Add a bottom panel

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY As a dependent revision of D19369 , this patch adds a panel to the bottom in order to make sure t

D19364: [sddm-theme/lock screen] Add shadows to action buttons

filipf accepted this revision as: filipf. filipf added a comment. This revision is now accepted and ready to land. Will let Nate verify that the outline patch has been done well here, but otherwise looks good. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19364 REVISION DETAIL htt

D19372: [sddm-theme] Enlarge user avatar in focus

rooty added a comment. Also, if I use the scale effect, they don't seem to anchor as well: F6641617: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19372 To: rooty, #vdg, ngraham Cc: abetts, filipf, plas

Re: Plasma Sprint 2019 in València

On Wed, Feb 20, 2019 at 4:14 PM Aleix Pol wrote: > > Hi, > In the meeting yesterday we discussed having a sprint this spring. > Alejandro (CC) offered having it in Slimbook premises in València and > suggested few dates. I included the Sundays, but we could configure > the days before and after as

D19372: [sddm-theme] Enlarge user avatar in focus

rooty added a comment. In D19372#420779 , @ngraham wrote: > Perfect functionality! Now we need some more bling. :) I'd like for the size to animate as well. > > A sane way to do this might be with a `ScaleAnimator` (https://doc.qt.io/qt-5/qm

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham resigned from this revision. ngraham added a comment. Cleaned the build dir and rebuilt everything from scratch, and now it works again, at least as good as it did before. I still don't see images removed from the right pane when their folder is removed, but seeing as how it works for

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

rooty added a comment. In D19373#420786 , @filipf wrote: > ^ let's discuss it in a separate task (here's one technical caveat: people with different sddm themes having to select the breeze theme to change their splash screen), I agree that imple

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

filipf added a comment. ^ let's discuss it in a separate task (here's one technical caveat: people with different sddm themes having to select the breeze theme to change their splash screen), I agree that implementing it here would be rushing things REPOSITORY R120 Plasma Workspace BRANCH

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. I copied the newer one (the one with the patch applied) over the older one and it works again. I guess plasmashell loaded the old library? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To: davidre, #vdg, ngraham, davidedmund

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

rooty added a comment. I don't know... if we made the splash screen use the same image as the login screen, it would become an extension of the login screen. Because otherwise, for a user that's using a third party wallpaper for the breeze sddm theme, you've got (1) one wallpaper for t

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. I only see one on my home machine, too: nate@Spectre:/usr$ find -name libplasma_wallpaper_imageplugin.so ./lib/qt/qml/org/kde/plasma/wallpapers/image/libplasma_wallpaper_imageplugin.so REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricat

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. I find two: 268756140 -rw-r--r-- 1 root root 139576 Feb 12 13:18 ./lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/wallpapers/image/libplasma_wallpaper_imageplugin.so 536558340 -rw-r--r-- 1 root root 347704 Feb 26 20:27 ./lib/x86

D19372: [sddm-theme] Enlarge user avatar in focus

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Perfect functionality! Now we need some more bling. :) I'd like for the size to animate as well. A sane way to do this might be with a `ScaleAnimator` (https://doc.qt.io/qt

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

ngraham added a comment. In D19373#420768 , @rooty wrote: > Hold on, could we? > If we created a symlink, say Background.png, in /usr/share/sddm/themes/breeze > Could we make the sddm theme and this splash screen use that same file?

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

filipf added a comment. Finally! Now let's just get it to work. INLINE COMMENTS > Splash.qml:28 > +// ${CMAKE_INSTALL_PREFIX}/${WALLPAPER_INSTALL_DIR > +source: "/usr/share/wallpapers/Next/contents/images/3200x2000.png" > +fillMode: Image.PreserveAspectCrop This will get removed

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

rooty added a comment. Hold on, could we? If we created a symlink, say Background.png, in /usr/share/sddm/themes/breeze Could we make the sddm theme and this splashscreen use that same file? REPOSITORY R120 Plasma Workspace BRANCH splash-screen-uses-next-wallpaper (branched from mas

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

rooty accepted this revision as: rooty. rooty added a comment. This revision is now accepted and ready to land. Wow that's fancy. +1 I only wish we could also change the Splash Screen background the same way we can change the sddm theme background. Or better yet, have matching backgroun

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The current Breeze splash screen is rather visually incongruous with what comes immediately

D19369: [sddm-theme] Remove login screen blur effect

rooty updated this revision to Diff 52684. rooty edited the test plan for this revision. rooty added a comment. Clean up some more REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19369?vs=52680&id=52684 BRANCH no-more-blur (branched from master)

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19185 To: ngraham, #vdg, #plasma, filipf Cc: abetts, filipf, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, ap

D19372: [sddm-theme] Enlarge user avatar in focus

filipf added a comment. In D19372#420739 , @rooty wrote: > In D19372#420737 , @filipf wrote: > > > As this is meant to be a replacement for `opacity: isCurrent ? 1.0 : 0.5` I would suggest to remove

D19372: [sddm-theme] Enlarge user avatar in focus

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19372 To: rooty, #vdg, ngraham Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

rooty added a comment. In D19372#420737 , @filipf wrote: > As this is meant to be a replacement for `opacity: isCurrent ? 1.0 : 0.5` I would suggest to remove it in this patch. Are the circles supposed to be this dark though? F664118

D19372: [sddm-theme] Enlarge user avatar in focus

filipf added a comment. As this is meant to be a replacement for `opacity: isCurrent ? 1.0 : 0.5` I would suggest to remove it in this patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19372 To: rooty, #vdg, ngraham Cc: filipf, plasma-devel, jraleigh,

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. Nope, just one: dev@dev-pc:/usr$ find -name libplasma_wallpaper_imageplugin.so ./lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/wallpapers/image/libplasma_wallpaper_imageplugin.so REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D19372: [sddm-theme] Enlarge user avatar in focus

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch makes the user avatar that is selected (in focus) larger than the other unselected/deselected avatars around it (provided th

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidedmundson added a comment. @ngraham Run find -name libplasma_wallpaper_imageplugin.so in /usr and see if you get two results. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To: davidre, #vdg, ngraham, davidedmundson Cc: mart, alexde, davidedmu

D19369: [sddm-theme] Remove login screen blur effect

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In addition to just the WallpaperFader, you'll also need to remove all the multi-state plumbing too: the mouseArea, the animated transitions, the `uiVisible` variable, etc. You'

D19370: [sddm-theme] Add circles behind action buttons

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY As a dependent revision of D19369 , this patch adds a circle behind action button icons in order

D17249: Preserve screen colour doesn't work as expected

jsalatas added a comment. ping? :) REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D17249 To: jsalatas, #plasma, martinkostolny Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19369: [sddm-theme] Remove login screen blur effect

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH no-more-blur (branched from master) REVISION DETAIL https://phabricator.kde.org/D19369 AFFECTED FILES sd

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty updated this revision to Diff 52678. rooty added a comment. Remove hardcoded Noto Sans blunder REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19364?vs=52677&id=52678 BRANCH arcpatch-D19364 REVISION DETAIL https://phabricator.kde.org/D19

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty updated this revision to Diff 52677. rooty added a comment. Maybe this'll work REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19364?vs=52676&id=52677 BRANCH arcpatch-D19364 REVISION DETAIL https://phabricator.kde.org/D19364 AFFECTED FI

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty updated this revision to Diff 52676. rooty added a comment. Revert REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19364?vs=52673&id=52676 BRANCH arcpatch-D19364 REVISION DETAIL https://phabricator.kde.org/D19364 AFFECTED FILES CMakeL

D19325: [sddm-theme/lock screen] Tighten clock and username shadows

rooty updated this revision to Diff 52674. rooty added a comment. Better comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52666&id=52674 BRANCH arcpatch-D19325 REVISION DETAIL https://phabricator.kde.org/D19325 AFFECTED FILES

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty updated this revision to Diff 52673. rooty added a comment. Resolve conflicts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19364?vs=52670&id=52673 BRANCH username-action-shadows (branched from master) REVISION DETAIL https://phabricat

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty updated this revision to Diff 52670. rooty added a comment. Reset REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19364?vs=52668&id=52670 BRANCH username-action-shadows (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D19325: [sddm-theme/lock screen] Tighten clock and username shadows

ngraham added a comment. +1 visually! Just one little thing... INLINE COMMENTS > Clock.qml:45 > spread: 0.3 > -color: ColorScope.backgroundColor > +color: "black" // new Breeze shadow color > } "New" isn't going to be accurate for very long. :) We should also e

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty updated this revision to Diff 52668. rooty added a comment. Let's try this again REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19364?vs=52667&id=52668 BRANCH username-action-shadows (branched from master) REVISION DETAIL https://phabri

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty updated this revision to Diff 52667. rooty added a comment. Remove UserDelegate changes, rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19364?vs=52655&id=52667 BRANCH username-action-shadows (branched from master) REVISION DETAIL

D19325: [sddm-theme/lock screen] Tighten clock and username shadows

rooty updated this revision to Diff 52666. rooty added a comment. Round clock shadow spread to a single decimal place REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52665&id=52666 BRANCH arcpatch-D19325 REVISION DETAIL https://phabri

D19325: [sddm-theme/lock screen] Tighten clock and username shadows

rooty updated this revision to Diff 52665. rooty added a comment. Remove >>>HEAD REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52664&id=52665 BRANCH arcpatch-D19325 REVISION DETAIL https://phabricator.kde.org/D19325 AFFECTED FILES

D19325: [sddm-theme/lock screen] Tighten clock shadows

rooty updated this revision to Diff 52664. rooty added a comment. Add UserDelegate shadows REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52663&id=52664 BRANCH arcpatch-D19325 REVISION DETAIL https://phabricator.kde.org/D19325 AFFEC

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. In D18809#420509 , @davidedmundson wrote: > > I've found out the difference in why it works for me and not for @ngraham. He installs to /usr and I tested from a folder in my home directory. Has anyone any hints how to f

D19325: [sddm-theme/lock screen] Tighten clock shadows

rooty updated this revision to Diff 52663. rooty added a comment. Use DropShadow REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52662&id=52663 BRANCH arcpatch-D19325_1 REVISION DETAIL https://phabricator.kde.org/D19325 AFFECTED FILE

D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend"

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R119 Plasma Desktop BRANCH use-the-word-sleep (branched from master) REVISION DETAIL https://phabricator.kde.org/D19184 To: ngraham, #vdg, #plasma, filipf Cc: filipf,

D19325: [sddm-theme/lock screen] Tighten clock shadows

rooty updated this revision to Diff 52662. rooty added a comment. Use new master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52656&id=52662 BRANCH arcpatch-D19325 REVISION DETAIL https://phabricator.kde.org/D19325 AFFECTED FILES

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

filipf accepted this revision. filipf added a comment. +1 from a usability and visuals POV REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19185 To: ngraham, #vdg, #plasma, filipf Cc: filipf, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zre

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 for the reasons listed in the commit message REPOSITORY R122 Powerdevil BRANCH use-the-word-sleep (branched from master) REVISION DETAIL https://phabricator.kde.org/D19186 To: ng

D19366: [sddm-theme/lock screen] Render shadows before (and below) labels

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3bdbf2ff87d4: [sddm-theme/lock screen] Render shadows before (and below) labels (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19366?v

D19366: [sddm-theme/lock screen] Render shadows before (and below) labels

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH shadows-before-labels (branched from master) REVISION DETAIL https://phabricator.kde.org/D19366 AFFECTED F

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. In D18890#419886 , @mart wrote: > In D18890#410144 , @guoyunhe wrote: > > > In D18890#410137 , @davidedmundson wrote: > > > >

D19325: [sddm-theme/lock screen] Tighten clock shadows

rooty updated this revision to Diff 52656. rooty added a comment. Use layer syntax instead REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52650&id=52656 BRANCH tighten-clock-shadow (branched from master) REVISION DETAIL https://phabr

D19364: [sddm-theme/lock screen] WIP, Add shadows to action buttons and redo username/prompt message shadow

rooty updated this revision to Diff 52655. rooty added a comment. Resolve "GraphicsInfo is not defined" error by bumping up QtQuick version REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19364?vs=52654&id=52655 BRANCH username-action-shadows (br

D19364: [sddm-theme/lock screen] WIP, Add shadows to action buttons and redo username/prompt message shadow

rooty added a comment. P.S. I haven't yet resolved this error: [19:14:33.680] (WW) GREETER: file:///home/rooty/kde/temp/sddm-theme/components/ActionButton.qml:30: ReferenceError: GraphicsInfo is not defined REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.or

D19364: [sddm-theme/lock screen] WIP, Add shadows to action buttons and redo username/prompt message shadow

rooty updated this revision to Diff 52654. rooty added a comment. Remove extra line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19364?vs=52653&id=52654 BRANCH username-action-shadows (branched from master) REVISION DETAIL https://phabricat

D19364: [sddm-theme/lock screen] WIP, Add shadows to action buttons and redo username/prompt message shadow

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH username-action-shadows (branched from master) REVISION DETAIL https://phabricator.kde.org/D19364 AFFECTED

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidedmundson added a comment. > I've found out the difference in why it works for me and not for @ngraham. He installs to /usr and I tested from a folder in my home directory. Has anyone any hints how to fix this? Why would that make a difference? REPOSITORY R120 Plasma Workspace R

D19280: [TaskManager] Modernize and reorganize configuration settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5e905afb07e8: [TaskManager] Modernize and reorganize configuration settings (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=526

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. I've found out the difference in why it works for me and not for @ngraham. He installs to /usr and I tested from a folder in my home directory. Has anyone any hints how to fix this? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

ngraham updated this revision to Diff 52651. ngraham added a comment. Add appropriate captions/subtexts for the Sleep and Hibernate items for KRunner REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19185?vs=52155&id=52651 BRANCH use-the-word-sle

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

rooty updated this revision to Diff 52650. rooty marked an inline comment as done. rooty added a comment. Use filipf's settings REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52580&id=52650 BRANCH tighten-clock-shadow (branched from mas

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

ngraham added a comment. In D19325#420490 , @filipf wrote: > +1, here's what it would look like with: > > horizontalOffset: 1 > verticalOffset: 1 > radius: 6 > samples: 14 > spread: 0.30 > color: "black" > > > F6

D19280: [TaskManager] Modernize and reorganize configuration settings

GB_2 added a comment. Now just update the screenshots. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19280 To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliez

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

filipf added a comment. In D19325#420487 , @ngraham wrote: > OK, if 0.35 spread is too much, how about increasing the radius a bit instead? The thing that I don't like so much about this new style is how hard-edged the shadows look in comparison

D19280: [TaskManager] Modernize and reorganize configuration settings

ngraham accepted this revision. ngraham added a comment. Indentation looks good! Looks great and works great for both regular and icons-only task managers, in both horizontal and vertical orientations. Shipit! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://p

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

ngraham added a comment. OK, if 0.35 spread is too much, how about increasing the radius a bit instead? The thing that I don't like so much about this new style is how hard-edged the shadows look in comparison to the folder view icons' text shadows REPOSITORY R120 Plasma Workspace REVISIO

D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham added a comment. Sounds good to me! REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19014 To: vpilo, #plasma, broulik, drosca, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added a comment. In D19014#417976 , @ngraham wrote: > In D19014#417906 , @vpilo wrote: > > > @ngraham If a new icon should be made, who could do it and how does the request process go? > >

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

filipf added a comment. I think we should also be a little big careful with trying to apply the same shadow settings everywhere. The DesktopContainment settings work great for 10pt and 11pt text (meaning they will be great for most of the labels in the sddm theme), but the clock is rather bi

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

rooty marked an inline comment as done. rooty added a comment. In D19325#420388 , @ngraham wrote: > Ah, I see now! I even implemented that, touché. :) > > Also, why did you change the shadow from a layer effect to a separate item? If that's n

D19280: [TaskManager] Modernize and reorganize configuration settings

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. I'm OK with this, but I'd like @ngraham to verify consistency on the indent issue. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19280 To: f

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. Hmm, with this version, the right panel never gets populated at all, and the Open Folder button no longer works. Also the buttons are too far apart and too far from the right edge of the SwipeListItem, but that may be a Kirigami issue for @mart. Here's a scr

D19280: [TaskManager] Modernize and reorganize configuration settings

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in ConfigAppearance.qml:21 > Yes it is, there's a RowLayout in here. I meant the QQC1 import, but it was removed just before I posted this comment :P REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1928

D19280: [TaskManager] Modernize and reorganize configuration settings

ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in ConfigAppearance.qml:21 > Import is not needed anymore. Yes it is, there's a RowLayout in here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19280 To: filipf, #plasma, #vdg, ngraham, rooty, GB_2,

D19280: [TaskManager] Modernize and reorganize configuration settings

GB_2 added inline comments. INLINE COMMENTS > ConfigAppearance.qml:21 > +import QtQuick 2.0 > +import QtQuick.Controls 1.0 as QQC1 > +import QtQuick.Controls 2.5 Import is not needed anymore. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19280 To: filipf, #pl

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52647. filipf added a comment. Don't import QQC1 for ConfigAppearance.qml REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52646&id=52647 BRANCH master REVISION DETAIL https://phabricator.kde.org/D192

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf added a comment. In D19280#420401 , @filipf wrote: > rename "vertical" property to "plasmoidVertical" because it was interfering with QQC2's slider > "vertical" variable; use QQC2 slider Shoutout to @GB_2 for figuring out why t

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52646. filipf added a comment. rename "vertical" property to "plasmoidVertical" because it was interfering with QQC2's slider "vertical" variable; use QQC2 slider REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

ngraham added a comment. Ah, I see now! I even implemented that, touché. :) Also, why did you change the shadow from a layer effect to a separate item? If that's necessary, it would seem to be appropriate material for another patch since it's not a visual change (unless I'm not noticing

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. In D19011#420361 , @abetts wrote: > Can the text to the right of the list, "Trusted" be a different color and maybe a smaller font? When using the same font, color and size as the device name, it seems that they are the

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

filipf added a comment. In D19325#420378 , @ngraham wrote: > However, the Request Changes is for two reasons: > > 1. Shouldn't we do this for the shadows under the usernames too? > 2. I'm not sold on the visual appearance. No other shadow in

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52644. filipf added a comment. use units.largeSpacing for indentation; remove redunant visible: vertical properties for children of RowLayout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52565&id=52

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I expected to hate this, but it turns out I don't. :) It looks legible enough with all the backgrounds I typically test against except for the most challenging ones of all for w

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

filipf added a comment. I've been advocating this before (D16031#372706 ) so obviously I'm in favor of the change. One thing that's been bothering me though is the blue offset that shows up to the left of the text: F6639680: image.png

D19280: [TaskManager] Modernize and reorganize configuration settings

GB_2 added inline comments. INLINE COMMENTS > filipf wrote in ConfigBehavior.qml:69 > I tried `units.largeSpacing` first then realized it's not aligned with the > top text (not even with 1.0 scaling) so I did something like > `(units.largeSpacing - units.smallSpacing * 2)` which worked ok with

D19011: Thunderbolt KCM and KDED module

abetts added a comment. Can the text to the right of the list, "Trusted" be a different color and maybe a smaller font? When using the same font, color and size as the device name, it seems that they are the same thing. One is device name and the other is device status. I am just wondering i

D19340: Search new knsrc locations

apol added inline comments. INLINE COMMENTS > KNSBackend.cpp:69 > +#if KNEWSTUFFCORE_VERSION_MAJOR==5 && KNEWSTUFFCORE_VERSION_MAJOR>=56 > +QStringList locations = > KNSCore::Engine::configSearchLocations(true); > +#else Discover should probably not fallback, i.e. pass false as an a

D19029: Guard virtualDesktopManagement being accessed before fetched

This revision was automatically updated to reflect the committed changes. Closed by commit R120:895aee564fae: Guard virtualDesktopManagement being accessed before fetched (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D190

D18922: [shell] Show kactivies warning only on error

This revision was automatically updated to reflect the committed changes. Closed by commit R120:70ef0829982e: [shell] Show kactivies warning only on error (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18922?vs=51400&id=5

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf added inline comments. INLINE COMMENTS > GB_2 wrote in ConfigBehavior.qml:69 > Should be `units.largeSpacing` I tried `units.largeSpacing` first then realized it's not aligned with the top text (not even with 1.0 scaling) so I did something like `(units.largeSpacing - units.smallSpacing

D19280: [TaskManager] Modernize and reorganize configuration settings

GB_2 added inline comments. INLINE COMMENTS > hein wrote in ConfigBehavior.qml:69 > Wait, 10x the checkbox width? Should be `units.largeSpacing` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19280 To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein Cc: hein

D19340: Search new knsrc locations

leinir created this revision. leinir added reviewers: Discover Software Store, apol, ngraham. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Using the search loca

D19337: Fixed some undefined properties runtime errors.

malteveerman created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. malteveerman requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D19337 AFFECTED FILES src/controls/Page.qml

D19044: [InlineMessage] Do not draw shadows around the message

filipf added a comment. In D19044#416559 , @mart wrote: > - whole InlineMessage should be moved into templates Im not home right now but I ran into an issuse with this step because that file I should move to templates already imports temp

D19314: Fix bug (check null didn't work)

This revision was automatically updated to reflect the committed changes. Closed by commit R169:938b79be2421: Fix bug (check null didn't work) (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19314?vs=52552&id=52600 REVISION DETAIL http

  1   2   >