rooty marked an inline comment as done. rooty added a comment.
In D19325#420388 <https://phabricator.kde.org/D19325#420388>, @ngraham wrote: > Ah, I see now! I even implemented that, touché. :) > > Also, why did you change the shadow from a layer effect to a separate item? If that's necessary, it would seem to be appropriate material for another patch since it's not a visual change (unless I'm not noticing it). Because it says "Cannot assign to non-existent property "layers"" I don't know what I'm doing wrong > However, the Request Changes is for two reasons: > > 1. Shouldn't we do this for the shadows under the usernames too? > 2. I'm not sold on the visual appearance. No other shadow in KDE Software that I'm familiar with looks like this, with a low spread, a hard edge, and the light source shining from the top left. It's not that it looks bad, but it doesn't look like it really fits in with anything else. Thoughts? 1. Separate patch (I've written it but I haven't committed it yet). The action buttons too. 2. DesktopContainment does, that's where I got the idea (@flipwise's mockups too) INLINE COMMENTS > ngraham wrote in Clock.qml:44 > If we're emulating the shadows in D16968 > <https://phabricator.kde.org/D16968>, shouldn't this be 0.35? Yes, but doesn't it look too jagged when it's 0.35? 0.35: F6639986: image.png <https://phabricator.kde.org/F6639986> 0.25: F6639988: image.png <https://phabricator.kde.org/F6639988> REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19325 To: rooty, #vdg, ngraham, filipf, mart Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
