guoyunhe added a comment.
In D18890#419886 <https://phabricator.kde.org/D18890#419886>, @mart wrote: > In D18890#410144 <https://phabricator.kde.org/D18890#410144>, @guoyunhe wrote: > > > In D18890#410137 <https://phabricator.kde.org/D18890#410137>, @davidedmundson wrote: > > > > > If we know the DB is corrupted, and it's just a cache, why do we need a user facing button? > > > > > > It is also possible to move this function to database corruption handler. One thing I worry about is: if the database corruption is caused by software reason, it will repeat the corrupt-rebuild-corrupt dead loop... > > > maybe also add an heuristic that if has been automatically rebuilt more than x times in the last y time, stop doing it? Should work. I will make a patch for Baloo and then update this patch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890 To: guoyunhe, #plasma, #baloo Cc: mart, davidedmundson, bruns, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, domson, ashaposhnikov, astippich, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol
