GB_2 added inline comments.

INLINE COMMENTS

> filipf wrote in ConfigBehavior.qml:69
> I tried `units.largeSpacing` first then realized it's not aligned with the 
> top text (not even with 1.0 scaling) so I did something like 
> `(units.largeSpacing - units.smallSpacing * 2)` which worked ok with 1.0 
> scaling but the higher the scaling factor the more the text shifted to the 
> right = it stopped being aligned with the top text. This bad code that's 
> present now worked well with all scaling preferences. I can just do 
> `units.largeSpacing` though if everyone is fine with that.

`units.largeSpacing` is correct and used in other places too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to