bruns added a comment.

  In D18890#410137 <https://phabricator.kde.org/D18890#410137>, @davidedmundson 
wrote:
  
  > If we know the DB is corrupted, and it's just a cache, why do we need a 
user facing button?
  
  
  There are many possible ways of corruption:
  
  - non-decodable values
  - entries with dangling parent IDs
  - IDs of no longer existing documents
  - ....
  
  These have different reasons, not all reasons are known and understood, not 
all corruptions are critical.
  
  There are issues with races in the file system, where items are 
deleted/created/modified while these are added to the DB. Unfortunately, Qt 
offers no way to handle it, the only save method is to use the 
openat/fstatat/... functions. This is possible to fix, but until then, rinse 
and repeat.
  
  The non-decodable values are hard to handle, this would at least require 
scrubbing the whole DB or building it from scratch. But until it is known what 
causes this corruption, we end up in doing it again and again.
  
  Some of these are quite safe to just ignore, but some parts a lacking sanity 
checks. On the other hand, D12336 <https://phabricator.kde.org/D12336> is 
waiting for review for 10 months ...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18890

To: guoyunhe, #plasma, #baloo
Cc: mart, davidedmundson, bruns, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, domson, ashaposhnikov, astippich, spoorun, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol

Reply via email to