D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 41997. hein added a comment. Fix wrong conditional. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=41932&id=41997 BRANCH arcpatch-D13745 REVISION DETAIL https://phabricator.kde.org/D15599 AFFECTED

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein added inline comments. INLINE COMMENTS > broulik wrote in desktop.cpp:65 > This codes doesn't take into account when the virtual desktop names change > etc. I think it should re-create the actions every time, and not try to be > "smart" by only changing the ones that are "superfluous" or "

D15598: Sort icon and cursor themes case-insensitively

ngraham added a comment. Darn, looks like arc didn't notice my rebase on 5.14. Oh well, I guess this'll go into 5.15. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D15598 To: ngraham, apol, #plasma Cc: wbauer, cfeck, broulik, plasma-devel, ragreen

D15598: Sort icon and cursor themes case-insensitively

This revision was automatically updated to reflect the committed changes. Closed by commit R99:b943d4ac6e2c: Sort icon and cursor themes case-insensitively (authored by ngraham). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15598?vs=41983&i

D15598: Sort icon and cursor themes case-insensitively

ngraham added a comment. I'll keep `setSortRole(Qt::DisplayRole)` for explicitness if nobody objects. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH sort-icon-and-cursor-themes-case-insensitively (branched from master) REVISION DETAIL https://phabricator.kde.org/D15598 To: ngraham,

D15598: Sort icon and cursor themes case-insensitively

ngraham added a comment. @wbauer, thanks for the hint. I've tested this with `xcursor-themes` and verified that it works for me too. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH sort-icon-and-cursor-themes-case-insensitively (branched from master) REVISION DETAIL https://phabricat

D15613: [Hotplug Engine] Update actions at runtime and listen for added/removed

apol added a comment. +1 INLINE COMMENTS > broulik wrote in hotplugengine.cpp:152 > I don't think so, the icon and emblem don't depend on the predicate but the > device's state. > > Granted, we currently don't update them *at all* in this dataengine but > that's a separate issue. Device No

D15598: Sort icon and cursor themes case-insensitively

wbauer added a comment. Works (and looks) fine for me now. Btw, it wouldn't really be necessary to call `setSortRole(Qt::DisplayRole)`, as the default value is `Qt::DisplayRole` anyway. (but of course doing it is not wrong either...) REPOSITORY R99 KDE Gtk Configuration Tool BRANCH

D15598: Sort icon and cursor themes case-insensitively

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM, not sure why sort() doesn't work though. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH sort-icon-and-cursor-themes-case-insensitively (branched from master) REVISION DETAIL http

D15598: Sort icon and cursor themes case-insensitively

ngraham added a comment. In D15598#328774 , @wbauer wrote: > Maybe it would be better to derive CursorThemesModel and IconThemesModel from QSortFilterProxyModel instead of QStandardItemModel, and keep the previous fix? I had that idea to

D15598: Sort icon and cursor themes case-insensitively

ngraham updated this revision to Diff 41983. ngraham added a comment. Address review comments REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15598?vs=41956&id=41983 BRANCH sort-icon-and-cursor-themes-case-insensitively (branched from ma

D15598: Sort icon and cursor themes case-insensitively

wbauer added a comment. In D15598#328791 , @broulik wrote: > > Although, I think that would need to be done every time the data changes. > > `QSortFilterProxyModel` does that automatically You mean it will keep the data sorted after ch

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 41977. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=41976&id=41977 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES applets/comic/comic.cpp applets/comic/comic.h dataengine

D15616: [Comic] Handle error state correctly

anthonyfieroni created this revision. anthonyfieroni added reviewers: davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY This happen really rare, i've used comic applet on my desktop

D15598: Sort icon and cursor themes case-insensitively

broulik added a comment. > Although, I think that would need to be done every time the data changes. `QSortFilterProxyModel` does that automatically REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D15598 To: ngraham, apol, #plasma Cc: wbauer, cf

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

davidedmundson added a comment. In principle, sure. My previous review comments remain to be done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12040 To: Zren, #plasma Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot,

D15598: Sort icon and cursor themes case-insensitively

wbauer added a comment. In D15598#328747 , @wbauer wrote: > I suppose that's because, according to the QSortFilterProxyModel docs, `At this point, neither sorting nor filtering is enabled; the original data is displayed in the view.` > Appare

D15613: [Hotplug Engine] Update actions at runtime and listen for added/removed

broulik added inline comments. INLINE COMMENTS > apol wrote in hotplugengine.cpp:152 > Don't we need to pass the icon and emblems here too? I don't think so, the icon and emblem don't depend on the predicate but the device's state. Granted, we currently don't update them *at all* in this datae

D15613: [Hotplug Engine] Update actions at runtime and listen for added/removed

apol added a comment. Sorry, very naif review. INLINE COMMENTS > hotplugengine.cpp:152 > Plasma::DataEngine::Data data; > data.insert(QStringLiteral("predicateFiles"), predicates); > +data.insert(QStringLiteral("actions"), > actionsForPredica

D15598: Sort icon and cursor themes case-insensitively

wbauer added a comment. Well, I tried this patch (applied upon 4.13.90a) and it doesn't seem to change anything. I still get icon and cursor themes starting with a lower-case character sorted after all those with an upper-case character. I suppose that's because, according to the QSort

D15613: [Hotplug Engine] Update actions at runtime and listen for added/removed

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It would only detect changes to existing device actions but not adding or removing them. Moreov

D15233: Add a tooltip for the appentry in the kicker

alexeymin added a comment. Why isn't repository for this review set? Which repo it should be? REVISION DETAIL https://phabricator.kde.org/D15233 To: underwit, #plasma Cc: alexeymin, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15233: Add a tooltip for the appentry in the kicker

underwit added a comment. Hello! There is a chance that my patch will be apply? REVISION DETAIL https://phabricator.kde.org/D15233 To: underwit, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart