apol added a comment.

  +1

INLINE COMMENTS

> broulik wrote in hotplugengine.cpp:152
> I don't think so, the icon and emblem don't depend on the predicate but the 
> device's state.
> 
> Granted, we currently don't update them *at all* in this dataengine but 
> that's a separate issue. Device Notifier actually queries those from the 
> Solid Device data engine which does seem to update everything correctly.

Ok, makes sense to me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15613

To: broulik, #plasma
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

Reply via email to