broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY It would only detect changes to existing device actions but not adding or removing them. Moreover, the list of actions was never updated at runtime, only the list of predicates for the device. This causes Device Notifier to pick up added, removed, or modified device actions only on startup. TEST PLAN - Added a device action, would show up in device notifier right away - Renamed a device action, change would be reflected in device notifier right away - Removed a device action, would disappear in device notifier right away - Changed the predicate of an action to no longer match storage devices, it disappeared right away - Invoking actions like "Open in file manager" still works REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15613 AFFECTED FILES dataengines/hotplug/hotplugengine.cpp dataengines/hotplug/hotplugengine.h To: broulik, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
