broulik added inline comments. INLINE COMMENTS
> apol wrote in hotplugengine.cpp:152 > Don't we need to pass the icon and emblems here too? I don't think so, the icon and emblem don't depend on the predicate but the device's state. Granted, we currently don't update them *at all* in this dataengine but that's a separate issue. Device Notifier actually queries those from the Solid Device data engine which does seem to update everything correctly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15613 To: broulik, #plasma Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
