Hi,
The QtCurve style fails to build against Qt 5.9.0: it triggers a compile-time
assert in the QFlags class on the function below.
Am I right that the argument `QFlags state` should simply be `State
state`?
It seems logical given that the `State` type is already a `QFlags`
but I find it hard
Hi,
Please allow a question that apparently requires intimate knowledge of
implementation details:
All of a sudden my Plasma4 session is being restored to a single desktop
instead of to the desktops on which windows were open when I saved the session.
What's more, the windows of my standard t
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/109/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 14 Apr 2017 03:02:22 +
Build duration: 10 min
CHANGE SET
Revision d9937c535aa8c6f7eaf381c
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/120/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 14 Apr 2017 03:02:07 +
Build duration: 9 min 44 sec
CHANGE SET
Revision 7ff13bc0f73964e6374
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/852/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 14 Apr 2017 02:01:15 +
Build duration: 22 min
CHANGE SET
Revision 36e1172a98515ed690e45ec1d143bae068
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/715/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 14 Apr 2017 02:01:00 +
Build duration: 6 min 50 sec
CHANGE SET
Revision 49ba7c57d6952c11c948459ae923a1
https://bugs.kde.org/show_bug.cgi?id=378498
Christoph Feck changed:
What|Removed |Added
CC||hans.ullr...@loop.de
--- Comment #1 from Chris
davidedmundson added a comment.
You cannot repurpose useHoverEffects.
The documentation says that is for disabling hoverEnabled on a bunch of items
- so they don't even get hover events.
(albeit only in QtQuickControls2 ...for now) because it has a high
performance cost.
Despite i
davidedmundson added inline comments.
INLINE COMMENTS
> config.qml:40
> function saveConfig() {
> -root.restoreIndex(imageWallpaper.wallpaperModel.count)
> +root.restoreIndex()
> imageWallpaper.commitDeletion();
Why even do anything?
You're selecting the currently
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/119/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 13 Apr 2017 21:12:39 +
Build duration: 21 min
CHANGE SET
Revision 59528fdc731afe5603bbca9f1
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Currently the selected wallpaper is deselected when the "Apply"
button is clicked, as if no wallpaper is selected. This patch
fixes that. I didn't understand what the original restoreIndex
thing wa
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/714/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 13 Apr 2017 21:13:49 +
Build duration: 5 min 50 sec
CHANGE SET
Revision 1bc257a04048a8e3efa49db9582946
dvogel updated this revision to Diff 13395.
dvogel marked 6 inline comments as done.
dvogel added a comment.
Applied changes suggested by reviewers.
The only issue remaining is brightness restoration when waking up the monitor
after shutting it down: we try to set brightness before the monit
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
With the TabBox I observed the following issue:
1: trigger TabBox through screen edge
2: exit TabBox
3: trigger TabBox again thro
graesslin updated this revision to Diff 13410.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Fixing arc mess
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5421?vs=13409&id=13410
BRANCH
screenedge-touch-check
graesslin updated this revision to Diff 13409.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- [plugins/qpa] Do not replace a valid FBO with an invalid one
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5421?vs=
mart added a comment.
In https://phabricator.kde.org/D5428#101932, @hein wrote:
> To go one further, we could add a mechanism to allow downstreams to set the
style hint via the LnF package, then we (maybe) don't even need the checkbox.
+1
breeze should follow the hint then
REPO
hein added a comment.
To go one further, we could add a mechanism to allow downstreams to set the
style hint via the LnF package, then we (maybe) don't even need the checkbox.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: bro
broulik added a comment.
In the Plasma QPT, yes, we already have something similar for whether to use
animations iirc in widget style advanced settings
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: broulik, colomar, plasma-de
hein added a comment.
Then we'd need to adapt Breeze to follow the style hint, and put a global
option into the Style KCM to set through the QPA?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: broulik, colomar, plasma-devel, p
broulik added a comment.
http://doc.qt.io/qt-5/qstylehints.html#useHoverEffects-prop
I think that's exactly what we want (added in Qt 5.8)
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: broulik, colomar, plasma-devel, prog
hein added a comment.
Can you tell us more about QStyleHints useHoverEffects? Is this a real thing
that's coming, or a proposal?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: broulik, colomar, plasma-devel, progwolff, lesliez
broulik added a comment.
I'd prefer postponing this until we can use `QStyleHints useHoverEffects` at
which point we can make it global for Plasma and all other places.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: broulik, c
hpereiradacosta added a comment.
For comboxes at least, once focused (mouse or keyboard), when you press up
and down arrows, they change selection. So focus should be there I think
For buttons, same thing. You have a button group, focus on one button (mouse
or keyboard), then press the arro
hein added a comment.
Why do buttons and comboboxes need the focus indicator on click (vs.
keyboard) more than checkboxes and tabs, though?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5429
To: mart, #plasma, hpereiradacosta
Cc: hein, colomar, plasma-devel, progwol
mart added a comment.
In https://phabricator.kde.org/D5429#101848, @hpereiradacosta wrote:
> In https://phabricator.kde.org/D5429#101847, @colomar wrote:
>
> > It definitely should not be an option. Either it's better, then it goes
in, or it isn't, then it doesn't.
>
>
> Agreed.
hpereiradacosta added a comment.
In https://phabricator.kde.org/D5429#101847, @colomar wrote:
> It definitely should not be an option. Either it's better, then it goes in,
or it isn't, then it doesn't.
Agreed.
If indeed it fixes bugs and inconsistencies (rather than introduces
colomar added a comment.
It definitely should not be an option. Either it's better, then it goes in,
or it isn't, then it doesn't.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5429
To: mart, #plasma, hpereiradacosta
Cc: hein, colomar, plasma-devel, progwolff, lesli
hein added a comment.
There's no tickets. This change is the result of a QA session over at
Netrunner where we noticed the following behavior pattern for the tab bar
widget:
1. If you just click a tab, there is usually no focus indicator line shown
2. If you use the Tab key to reach a
hpereiradacosta added a comment.
@Marco,
could you detail which widgets have their mouse focus disabled ?
as there some bug reports wishlist about the issue you mention ?
Honestly I would argue that the disabled feature are all design choices and
should not be worth an option for disab
colomar added a comment.
Who has complained about this? Can we see the reports?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5429
To: mart, #plasma, hpereiradacosta
Cc: colomar, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
hein added a comment.
No, inappropriate is stuff like "which is out of topic and not very pleasant"
in a rational discussion over contribution and maintance workflows in the KDE
community (which you started). It's even more inappropriate to resort to ad
hominems suggesting I act out of frust
hpereiradacosta added a comment.
Colomar: could you also comment on "https://phabricator.kde.org/D5429"; ?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: colomar, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg
hpereiradacosta added a comment.
At least we could explain there to our user why we would prefer not to
implement the said feature
(as I have done politely multiple times already, without ending up being
accused of not trying to satisfy the needs for our dowstreams)
REPOSITORY
R31 Breeze
hpereiradacosta added a comment.
ps: is there a bug (= wish) report somewhere about this so importantly needed
feature ?
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: colomar, plasma-devel, progwolff, lesliezhai, ali-mohamed,
hpereiradacosta added a comment.
"I think it's regrettable that the current Plasma default theme isn't
interested in satisfying the needs of our downstreams and do wonder if that
situation will have to be addressed somehow,"
I think this is a completely overstated and innapropriate statemen
Il 13/04/2017 18:41, Martin Gräßlin ha scritto:
> Am 2017-04-13 17:19, schrieb Germano Massullo:
>> Il 13/04/2017 16:49, Martin Gräßlin ha scritto:
>>> Am 2017-04-13 16:08, schrieb Germano Massullo:
Il 13/04/2017 13:12, David Edmundson ha scritto:
> "echo 0 | sudo tee /proc/sys/kernel/yam
hein added a comment.
I think it's regrettable that the current Plasma default theme isn't
interested in satisfying the needs of our downstreams and do wonder if that
situation will have to be addressed somehow, but thanks for your input.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://ph
hein abandoned this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: colomar, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
hpereiradacosta added a comment.
"This is also why there's engines like the highly configurable QtCurve (and a
big aftermarket of 500+ QtCurve themes/config on the KDE Store), instead of 500
different style engines."
That is out of topic
Breeze is not QtCurve, and possibly, it is because
hein added a comment.
> If it's most likely to be decided only on the distribution level, we don't
necessarily need a GUI for switching it, do we? We could also just have it as
an unexposed parameter in the config file.
Yes, although options being hidden tends to excercabate maintenance
colomar added a comment.
If it's most likely to be decided only on the distribution level, we don't
necessarily need a GUI for switching it, do we? We could also just have it as
an unexposed parameter in the config file.
I think Breeze (like Oxygen) already has too many user-visible conf
hein added a comment.
Aye. I've pinged Jens, Ken and Thomas with the link.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
Am 2017-04-13 17:19, schrieb Germano Massullo:
Il 13/04/2017 16:49, Martin Gräßlin ha scritto:
Am 2017-04-13 16:08, schrieb Germano Massullo:
Il 13/04/2017 13:12, David Edmundson ha scritto:
"echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope" (or run GDB
as root)
David
As root in tty3 I
hpereiradacosta added a comment.
... VDG also gives oppinions about what should be an option and what should
not
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5428
To: hein, mart, hpereiradacosta
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
drosca updated this revision to Diff 13394.
drosca added a comment.
Use correct form (not standalone) of day/month names
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5346?vs=13345&id=13394
BRANCH
master
REVISION DETAIL
https://phabricator.k
hein added a comment.
I don't see VDG/UX input helping on this issue. We know there are working
systems that behave in this way and are usability-tested. The VDG could only
give an opinion on what it wants to see in Plasma by default, and this patch
doesn't aim to change a default. It's an o
hpereiradacosta added a comment.
I'm not so much talking about the value of having the code upstream (of
course everybody wants their code upstream, to get relieved from the
maintenance burden), but on the feature itself, which in my opinion is too
little to be upstreamed.
as for the offer
hein added a comment.
Regarding the general topic of "to hover effect or not to hover effect", I
personally see the utility of hover effects and am fine with them being on by
default. However, it's also true that other systems seem to do fine without
them and I can see how some might prefer
hein added a comment.
BTW I'll add this is a very common predicament in FOSS and it's the reason
why kernel.org has a "code should be upstream" and "if real systems ship it, we
should merge it" policy. History/experience has shown again and again that
downstream deltas end up being a problem
hein added a comment.
The added value for users is getting regular bugfixes from upstream Breeze.
After extensive experience with Oxygen and Breeze forks by distros over five
years, they basically always got outdated. I'd much rather maintain this option
upstream (which I can offer to do for
hpereiradacosta added a comment.
(for me at least, hover effect is something very useful to identify that an
item is clickable. Admittedly, this is not very necessary for buttons, but for
things like expander and scrollbar arrows, which otherwise appear just like
text, it certainly helps).
hpereiradacosta added a comment.
Should add Usability and design experts to reviewers.
As far as I am concern, I don't see much use of adding an option (and the
code complexity that goes along), in order to disable a rather core (and very
usefull, usability wise, in my humble oppinion) fe
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Due some complaints about visual clutterness of things like
buttons changing color when clicked, or checkboxes getting their
label underlined,
Il 13/04/2017 16:49, Martin Gräßlin ha scritto:
> Am 2017-04-13 16:08, schrieb Germano Massullo:
>> Il 13/04/2017 13:12, David Edmundson ha scritto:
>>> "echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope" (or run GDB
>>> as root)
>>>
>>> David
>> As root in tty3 I attached GDB to kwin_wayland
Am 2017-04-13 16:08, schrieb Germano Massullo:
Il 13/04/2017 13:12, David Edmundson ha scritto:
"echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope" (or run GDB
as root)
David
As root in tty3 I attached GDB to kwin_wayland and as soon I got back
to
the graphical session, the system got st
hein updated this revision to Diff 13391.
hein added a comment.
Further disable hover effects for:
- Checkable group boxes.
- Checkboxes embedded into list items.
- Tree branch expander arrows.
I can now no longer find any occurences of hover effects in
oxygen-demo5 or System Se
ivanthekdefan updated this revision to Diff 13390.
ivanthekdefan added a comment.
Applied Lueck's suggestions, thanks!
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5189?vs=12843&id=13390
REVISION DETAIL
https://phabricator.kde.org/D5189
AFFEC
arichardson added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kdeplatformfiledialoghelper.cpp:365-370
> http://doc.qt.io/qt-5/qversionnumber.html
I don't think we can depend on that yet, can we? Also I'm not sure we really
need that runtime check. How likely is it that someone co
hein updated this revision to Diff 13389.
hein added a comment.
Also disable hover effect on selected view items.
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5428?vs=13388&id=13389
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5428
AFFE
anthonyfieroni added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in kdeplatformfiledialoghelper.cpp:365-370
> Sorry but I didn't think about Qt 5.10.x which would break this check. So
> please ignore my suggestion here.
http://doc.qt.io/qt-5/qversionnumber.html
REPOSITORY
R135 I
Il 13/04/2017 13:12, David Edmundson ha scritto:
> "echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope" (or run GDB
> as root)
>
> David
As root in tty3 I attached GDB to kwin_wayland and as soon I got back to
the graphical session, the system got stuck and I could not neither
return back to tt
hein created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The Plasma distribution I work would prefer to disable most UI hover
effects and have the system behave more similar to systems such as
Mac OS
elvisangelaccio added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in kdeplatformfiledialoghelper.cpp:365-370
> What about `if (qVersion() < QStringLiteral("5.7.1")) {}`? It doesn't work in
> the general case but it should work for this specific check.
Sorry but I didn't think about
leinir updated this revision to Diff 13386.
leinir marked an inline comment as done.
leinir added a comment.
Changed the KNS backend's main queued connection to somewhere a tiny bit more
central. This causes us to require KNewStuff master, but we already require a
bunch of master stuff elsewh
leinir marked an inline comment as done.
leinir added inline comments.
INLINE COMMENTS
> apol wrote in KNSBackend.cpp:330
> Then maybe it's KNS that should be syncing?
> i.e. `connect(m_engine, &KNSCore::Engine::signalEntriesLoaded, this,
> &KNSBackend::receivedEntries);`
>
> Or even have KNSCo
arichardson updated this revision to Diff 13383.
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4193?vs=10338&id=13383
BRANCH
arcpatch-D4193
REVISION DETAIL
https://phabricator.kde.org/D4193
AFFECTED FILES
src/platform
arichardson marked an inline comment as done.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D4193
To: arichardson, #plasma
Cc: elvisangelaccio, graesslin, plasma-devel, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas,
Il 13/04/2017 13:12, David Edmundson ha scritto:
> "echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope" (or run GDB
> as root)
>
> David
# cat /proc/sys/kernel/yama/ptrace_scope
0
so it seems that ptrace_scope is already setted to 0
"echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope" (or run GDB as
root)
David
Hi there, I am testing Plasma 5.9.4 on Wayland (on Fedora 25) and I am
filling various bugreports.
If I run plasmashell from bash, when it crashes I obtain message
so I started trying to attach gdb to kwin_wayland process. I followed
https://community.kde.org/KWin/Debugging
and I tried to run
$ gd
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1387b5efe31e: Guard against Applet not loading
AppletInterface (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5423?
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:f5a43877a9ea: Sort the themes in decoration KCM (authored
by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5407?vs=13348&id=13380
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:3709996f8a88: Fix KWin decoration KCM showing correct
index at startup (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5401?vs=13330&id=13
stikonas added a comment.
> ! In https://phabricator.kde.org/D5405#101683, @graesslin wrote:
> My comment was not meant as a stop-this-effort comment. If we can improve
here to do more sane things I'm all for it.
No, it's not your comment. We were discussing this on #kde-devel and it l
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
origin-master (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D5423
To: davidedmundson, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8a5efae3d165: Polish ItemViewHeader, solve binding loops
(authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5416?vs=13363&id=13378
REVISION DETAIL
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/851/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 13 Apr 2017 10:07:24 +
Build duration: 14 min
CHANGE SET
Revision 0377d6a992725e0b0b469b87d17343fa37
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5416
To: apol, #kirigami, leinir, mart
Cc: plasma-devel, apol
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We've been having the configure button on notifications for a long time but
so far it would only ever invoke KNotification configuration UI wi
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This can happen if an applet has invalid metadata, it doesn't have a
script engine set (X-Plasma-API) so it won'
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We can get into a state where we have applets with broken metadata.
(which is a different bug)
Someone clearly wrote this code to
leinir added a comment.
In https://phabricator.kde.org/D5408#101657, @apol wrote:
> Add `BUG: 378339`
That's not how i've been triggering it (i've been using the arrow keys for
list navigation, which also causes it), but yup, that's the backtrace :)
REPOSITORY
R169 Kirigami
RE
leinir updated this revision to Diff 13374.
leinir added a comment.
Add the missing check identified by Aleix. Thanks :)
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5408?vs=13349&id=13374
REVISION DETAIL
https://phabricator.kde.org/D5408
AFFECTED FI
jgrulich added a comment.
In https://phabricator.kde.org/D5382#101684, @fabianr wrote:
> It looks like the spacing between the 4 content sections (title,
description, passwords, buttons) is not always the same. To me it the spacing
between title - description and password - buttons looks
fabianr added a comment.
It looks like the spacing between the 4 content sections (title, description,
passwords, buttons) is not always the same. To me it the spacing between title
- description and password - buttons looks equal, but description - password
seems to be smaller. I would sugg
86 matches
Mail list logo
