arichardson added inline comments. INLINE COMMENTS
> anthonyfieroni wrote in kdeplatformfiledialoghelper.cpp:365-370 > http://doc.qt.io/qt-5/qversionnumber.html I don't think we can depend on that yet, can we? Also I'm not sure we really need that runtime check. How likely is it that someone compiles plasma integration against Qt 5.7 and runs it with 5.8? Is that even supported? Aren't we using private APIs? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 To: arichardson, #plasma Cc: anthonyfieroni, elvisangelaccio, graesslin, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
