elvisangelaccio added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in kdeplatformfiledialoghelper.cpp:365-370
> What about `if (qVersion() < QStringLiteral("5.7.1")) {}`? It doesn't work in 
> the general case but it should work for this specific check.

Sorry but I didn't think about Qt 5.10.x which would break this check. So 
please ignore my suggestion here.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D4193

To: arichardson, #plasma
Cc: elvisangelaccio, graesslin, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Reply via email to