leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS
> apol wrote in KNSBackend.cpp:330 > Then maybe it's KNS that should be syncing? > i.e. `connect(m_engine, &KNSCore::Engine::signalEntriesLoaded, this, > &KNSBackend::receivedEntries);` > > Or even have KNSCore emit from the object's thread: > http://doc.qt.io/qt-5/threads-qobject.html#signals-and-slots-across-threads This requires a fix in KNS, which has been pushed to master. We now require (current) master of KNS, so i'll update that for the cmake package find bit as well :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5409 To: leinir, #discover_software_store, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
