Re: Review Request 125618: Fixes to KameraConfigDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125618/#review87484 --- Are any changes needed? - Christian Butcher On Oct. 13, 201

[Plasma Workspace Wallpapers] [Bug 354379] Wallpaper fails to rotate 90 on dual screen with external scr. on left. Stays horiz. and spills over onto right scr.

https://bugs.kde.org/show_bug.cgi?id=354379 --- Comment #6 from PhillB --- I have discovered that the background can be made to go portrait again by using xrandr from the commandline. Unplug the screen. Run xrandr (no parameters). This gets back to single screen mode. Then plug the monitor back

[Plasma Workspace Wallpapers] [Bug 354379] Wallpaper fails to rotate 90 on dual screen with external scr. on left. Stays horiz. and spills over onto right scr.

https://bugs.kde.org/show_bug.cgi?id=354379 --- Comment #5 from PhillB --- It's back again. Don't know what I did. Background always landscape always now. To get it back to portrait I have to unplug the screen. Do all the deletes then reboot. Then I plug the screen back in and run KScreen which

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 6:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a window

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 11:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a window

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 26, 2015, 11:05 p.m., Daniel Vrátil wrote: > > src/declarativeimports/calendar/daysmodel.cpp, line 150 > > > > > > Is this iteration necessary just to print debug output? > > > > Once we have a

[Plasma Workspace Wallpapers] [Bug 354379] Wallpaper fails to rotate 90 on dual screen with external scr. on left. Stays horiz. and spills over onto right scr.

https://bugs.kde.org/show_bug.cgi?id=354379 --- Comment #4 from PhillB --- I also deleted everything in ~/.kde/share/apps/kscreen/*. Everything appears to be going OK for now. My backgrounds are portrait again :-) -- You are receiving this mail because: You are the assignee for the bug. __

[Plasma Workspace Wallpapers] [Bug 354379] Wallpaper fails to rotate 90 on dual screen with external scr. on left. Stays horiz. and spills over onto right scr.

https://bugs.kde.org/show_bug.cgi?id=354379 --- Comment #3 from PhillB --- This is only thing I've managed to find so far. https://www.reddit.com/r/kde/comments/3cc570/displaymonitor_settings_reset_on_every_reboot/ I'm about to try the work around suggested in the last post which is: On Fedora

Re: Review Request 125822: [Kickoff] Support mouse back button in ApplicationsView

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125822/ --- (Updated Oct. 26, 2015, 10:48 p.m.) Status -- This change has been m

Re: Review Request 125822: [Kickoff] Support mouse back button in ApplicationsView

> On Okt. 26, 2015, 10:43 nachm., David Edmundson wrote: > > why only CC bug? Dunno, that guy mentioned something about going forward which this patch doesn't. But I'm fine with closing the bug nonetheless. - Kai Uwe --- This is an aut

Re: Review Request 125822: [Kickoff] Support mouse back button in ApplicationsView

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125822/#review87476 --- Ship it! why only CC bug? - David Edmundson On Oct. 26, 20

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125775/ --- (Updated Oct. 26, 2015, 10:43 p.m.) Status -- This change has been m

Review Request 125822: [Kickoff] Support mouse back button in ApplicationsView

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125822/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

> On Oct. 26, 2015, 2:22 a.m., Andrew Lake wrote: > > Proper close button is welcome. Generally looks good to me, though I do > > think the close button works better with the consistency of the normal > > background rather than the randomness of the thumbnail as a background. > > Other than th

Re: Review Request 125555: Port KAuth return code error checking in fontinst

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated Oct. 26, 2015, 10:32 p.m.) Status -- This change has been m

Re: Review Request 125820: [Desktop Toolbox] Keep hovered state while menu is open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125820/ --- (Updated Oct. 26, 2015, 10:31 p.m.) Status -- This change has been m

Review Request 125821: [Kickerdash] Close when opening applet settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125821/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87470 --- src/declarativeimports/calendar/daysmodel.cpp (line 102)

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a window

Re: Review Request 125820: [Desktop Toolbox] Keep hovered state while menu is open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125820/#review87472 --- Ship it! Ship It! - Sebastian Kügler On Oct. 26, 2015, 9:1

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a window

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a window

Review Request 125820: [Desktop Toolbox] Keep hovered state while menu is open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125820/ --- Review request for Plasma and Andrew Lake. Repository: plasma-desktop D

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

> On Oct. 26, 2015, 10:13 a.m., Sebastian Kügler wrote: > > applets/systemtray/package/contents/ui/ExpandedRepresentation.qml, line 81 > > > > > > Why are you removing this? It seems unrelated to the rest of this

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

> On Oct. 26, 2015, 10:13 a.m., Sebastian Kügler wrote: > > applets/systemtray/package/contents/ui/ExpandedRepresentation.qml, line 81 > > > > > > Why are you removing this? It seems unrelated to the rest of this

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

> On Oct. 26, 2015, 10:13 a.m., Sebastian Kügler wrote: > > applets/systemtray/package/contents/ui/ExpandedRepresentation.qml, line 81 > > > > > > Why are you removing this? It seems unrelated to the rest of this

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/#review87465 --- Some remarks, but otherwise, thanks for taking care of this.

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

> On Oct. 26, 2015, 5:26 p.m., Kai Uwe Broulik wrote: > > applets/analog-clock/metadata.desktop, line 170 > > > > > > Why not "not specified = everywhere"? > > Marco Martin wrote: > yeah, in some of those ar

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87462 --- src/declarativeimports/calendar/plasmacalendarintegration/cal

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/ --- (Updated Oct. 26, 2015, 9:22 p.m.) Review request for Plasma and Daniel V

Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/ --- Review request for Plasma and Daniel Vrátil. Repository: plasma-framework

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a window

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a window

Re: Review Request 125811: detect gtk engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/#review87458 --- cmake/FindGTKEngine.cmake (line 17)

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

> On Oct. 26, 2015, 6:46 p.m., David Edmundson wrote: > > shell/panelview.cpp, line 723 > > > > > > Why is this connect in showEvent? Because we don't want to change stuff while the panel is still being set up.

Re: Review Request 125811: detect gtk engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/ --- (Updated Oct. 26, 2015, 6:01 p.m.) Review request for Plasma and David Ed

Re: Review Request 125814: add kconf script to set gtk theme to breeze

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125814/#review87450 --- kconf_update/main.cpp (line 54)

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review87448 --- shell/panelview.cpp (line 718)

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/ --- (Updated Oct. 26, 2015, 6:39 p.m.) Review request for Plasma. Changes -

Review Request 125814: add kconf script to set gtk theme to breeze

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125814/ --- Review request for Plasma and David Edmundson. Repository: breeze-gtk D

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

> On Oct. 26, 2015, 5:26 p.m., Kai Uwe Broulik wrote: > > applets/analog-clock/metadata.desktop, line 170 > > > > > > Why not "not specified = everywhere"? yeah, in some of those are probably redundant - Marco

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/#review87443 --- applets/analog-clock/metadata.desktop (line 170)

Re: Review Request 125809: Fix logic (and warnings) in ModelContextMenu.qml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125809/ --- (Updated Oct. 26, 2015, 5:22 p.m.) Status -- This change has been ma

Re: Review Request 125812: Fix icon-based status notifier icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125812/ --- (Updated Oct. 26, 2015, 5:22 p.m.) Status -- This change has been ma

Re: Review Request 125809: Fix logic (and warnings) in ModelContextMenu.qml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125809/#review87441 --- Ship it! Ship It! - David Edmundson On Oct. 26, 2015, 4:07

Re: Review Request 125812: Fix icon-based status notifier icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125812/#review87440 --- Ship it! Ship It! - David Edmundson On Oct. 26, 2015, 5:03

Review Request 125812: Fix icon-based status notifier icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125812/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 125811: detect gtk engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/#review87436 --- CMakeLists.txt (line 14)

Review Request 125811: detect gtk engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/ --- Review request for Plasma and David Edmundson. Repository: breeze-gtk D

Review Request 125810: Add some formfactor info to plasma-workspace applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

> On Oct. 26, 2015, 10:13 a.m., Sebastian Kügler wrote: > > applets/systemtray/package/contents/ui/ExpandedRepresentation.qml, line 81 > > > > > > Why are you removing this? It seems unrelated to the rest of this

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

> On Oct. 26, 2015, 9:12 a.m., Marco Martin wrote: > > applets/systemtray/package/contents/ui/ExpandedRepresentation.qml, line 129 > > > > > > this shouldn't be necessary, as hiddenView should still be just hidde

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

> On Oct. 26, 2015, 9:12 a.m., Marco Martin wrote: > > applets/systemtray/package/contents/ui/ExpandedRepresentation.qml, line 129 > > > > > > this shouldn't be necessary, as hiddenView should still be just hidde

Review Request 125809: Fix logic (and warnings) in ModelContextMenu.qml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125809/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 231 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/231/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 26 Oct 2015 13:43:21 + Build duration: 9 min 10 sec CHANGE SET Revision 8da1255654e844a93e387f3f80bf3

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 231 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/231/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 26 Oct 2015 13:43:21 + Build duration: 9 min 10 sec CHANGE SET Revision 8da1255654e844a93e387f3f80bf3

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Oct. 23, 2015, 10:15 p.m., David Edmundson wrote: > > Bump? We have a "no huge merges freeze" on the 5th of November for 5.5 Thanks for the bump, I will have some time next weekend, will go over the reviews again and then push this if all is good. (Due to moving, I have no internet right

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 230 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/230/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 26 Oct 2015 13:37:11 + Build duration: 4 min 15 sec CHANGE SET Revision 5a0ab38613763ab50a0e131561516

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/ --- (Updated Oct. 26, 2015, 1:36 p.m.) Status -- This change has been ma

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

> On Oct. 26, 2015, 5:32 p.m., David Edmundson wrote: > > ksmserver/screenlocker/abstractlocker.h, line 68 > > > > > > I don't like this set. > > > > It means if you use globalAccel() from X11Locker's con

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/#review87422 --- Ship it! ship it! I include a grumble about something that e

Minutes Monday Plasma Hangout

Present: Martin G, bhushan, david, jonathan, Kai Uwe, Marco, sebas today protocol from me as sebas had kdenlive running causing weirdness. If something is missing, please add Date: 2015-10-26 Bhushan: - screen locker for Wayland https://git.reviewboard.kde.org/r/125802/ David: - missing icons

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. Thomas, all this does is not grey out the text in Task Manager button labels when a window is minimized. See also the l

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

> On Oct. 25, 2015, 11:08 p.m., Uri Herrera wrote: > > I agree with Thomas that having the button inside the thumbnail is > > confusing. > > > >  > > > > On this image I moved the button outside the thumbnail, used the actual > > window-close icon in the ico

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125775/#review87414 --- applets/systemtray/package/contents/ui/ExpandedRepresentation

Re: RFC: Put notifications in sidepanel like widget explorer

On Tuesday, October 20, 2015 15:54:01 Martin Klapetek wrote: > today I was thinking a bit about our notification system. I believe > that the constraints the tiny popup give us are just too limiting. > Currently it fits about two notifications and for everything else > one has to scroll, plus the s

Re: Review Request 125805: Improve lockwindow test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125805/ --- (Updated Oct. 26, 2015, 9:57 a.m.) Status -- This change has been ma

Re: Review Request 125805: Improve lockwindow test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125805/#review87413 --- Ship it! Ship It! - Martin Gräßlin On Oct. 26, 2015, 10:43

Re: Review Request 125805: Improve lockwindow test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125805/ --- (Updated Oct. 26, 2015, 3:13 p.m.) Review request for Plasma and Martin G

Re: Review Request 125805: Improve lockwindow test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125805/#review87412 --- please verify that the background is colored at the expected p

Review Request 125805: Improve lockwindow test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125805/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-workspac

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

> On Oct. 26, 2015, 2:22 a.m., Andrew Lake wrote: > > Proper close button is welcome. Generally looks good to me, though I do > > think the close button works better with the consistency of the normal > > background rather than the randomness of the thumbnail as a background. > > Other than th

Re: Review Request 125775: System Tray: Add ScrollArea to hidden items view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125775/#review87410 --- Ship it! i like it, almost good to go applets/systemtray/pa

Re: Review Request 125771: Use ecm to allow configuring the install location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125771/ --- (Updated Oct. 26, 2015, 8:56 a.m.) Status -- This change has been ma

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/#review87404 --- +1, looks good to me. Let's give it some time for other devs t

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/ --- (Updated Oct. 26, 2015, 1:41 p.m.) Review request for Plasma and Martin G

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/#review87402 --- ksmserver/screenlocker/abstractlocker.h (line 66)

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

> On Okt. 26, 2015, 2:22 vorm., Andrew Lake wrote: > > Proper close button is welcome. Generally looks good to me, though I do > > think the close button works better with the consistency of the normal > > background rather than the randomness of the thumbnail as a background. > > Other than t

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/ --- (Updated Oct. 26, 2015, 1:02 p.m.) Review request for Plasma and Martin G

Re: Review Request 125802: Split generic parts from X11Locker into AbstractLocker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/#review87400 --- Difficult to read on reviewboard. Overall it looks good to me,

Review Request 125802: Split generic parts from X11Locker into AbstractLocker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-workspac