----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125802/ -----------------------------------------------------------
(Updated Oct. 26, 2015, 1:02 p.m.) Review request for Plasma and Martin Gräßlin. Changes ------- Fix issues - Add previous copyrights - Don't change position of initialize() I hope this revision is readable, done with different options. Repository: plasma-workspace Description ------- Advantage of this split is some parts such as showLockWindow and hideLockWindow needs platform specific code. So instead of doing complex if/else branching we can have seperate X11Locker and WaylandLocker. Diffs (updated) ----- ksmserver/screenlocker/abstractlocker.cpp PRE-CREATION ksmserver/screenlocker/CMakeLists.txt 24a89f6 ksmserver/screenlocker/abstractlocker.h PRE-CREATION ksmserver/screenlocker/autotests/CMakeLists.txt ab901ca ksmserver/screenlocker/autotests/lockwindowtest.cpp 444c44f ksmserver/screenlocker/autotests/x11lockertest.cpp PRE-CREATION ksmserver/screenlocker/ksldapp.h b281ab6 ksmserver/screenlocker/ksldapp.cpp 68ebfc2 ksmserver/screenlocker/lockwindow.h c4013be ksmserver/screenlocker/lockwindow.cpp e46733e ksmserver/screenlocker/x11locker.h PRE-CREATION ksmserver/screenlocker/x11locker.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125802/diff/ Testing ------- builds, installs, autotests and kscreenlocker_test passes, normal lockscreen also works. Thanks, Bhushan Shah
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
