> On Oct. 25, 2015, 11:08 p.m., Uri Herrera wrote: > > I agree with Thomas that having the button inside the thumbnail is > > confusing. > > > >  > > > > On this image I moved the button outside the thumbnail, used the actual > > window-close icon in the icon theme and removed the round button background. > > > >  > > > > On this the button is inside and there's no button background. > > Uri Herrera wrote: > I also made the button bigger, currently the button looks really tiny for > me.
The button is mostly on the thumbnail because there could be multiple windows in the tooltip. - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87385 ----------------------------------------------------------- On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2015, 9:42 p.m.) > > > Review request for Plasma, KDE Usability and Andrew Lake. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > ------- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > ----- > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > ------- > > Works. > > > File Attachments > ---------------- > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
