Re: Review Request 123299: Kickoff - Watch changes in the recent documents directory

On Thursday, April 16, 2015 21:10:02 Anthony Vital wrote: > > On avr. 16, 2015, 8:46 après-midi, Sebastian Kügler wrote: > > > applets/kickoff/core/recentlyusedmodel.cpp, line 113 > > > > > line113>> > > > > Why this cha

Build failed in Jenkins: plasma-desktop_stable_qt5 #113

See Changes: [lasse.liehu] Fix i18n in desktop containment -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILD

Re: Review Request 123299: Kickoff - Watch changes in the recent documents directory

> On avr. 16, 2015, 8:46 après-midi, Sebastian Kügler wrote: > > applets/kickoff/core/recentlyusedmodel.cpp, line 113 > > > > > > Why this change? Because documentUrl doesn't exist anymore, so I didn't want to l

Re: Review Request 123299: Kickoff - Watch changes in the recent documents directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123299/#review79079 --- Ship it! Minor changes needed, otherwise it's good to go in.

Re: Review Request 123387: Fix i18n in desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123387/#review79077 --- Ship it! Ship It! - Sebastian Kügler On April 16, 2015, 8:

Re: Review Request 123387: Fix i18n in desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123387/ --- (Updated April 16, 2015, 8:41 p.m.) Status -- This change has been m

Re: Review Request 123387: Fix i18n in desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123387/#review79076 --- Ship it! Ship It! - Lukáš Tinkl On Dub. 16, 2015, 8:58 odp

Review Request 123387: Fix i18n in desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123387/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 123299: Kickoff - Watch changes in the recent documents directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123299/#review79071 --- Ship it! Ship It! - David Edmundson On April 8, 2015, 3:43

Build failed in Jenkins: plasma-desktop_stable_qt5 #112

See Changes: [lasse.liehu] Fix i18n catalog connection of a string in Shortcuts config -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on Linux

Re: Review Request 123386: Fix i18n catalog connection of a string in shortcuts config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123386/ --- (Updated April 16, 2015, 5:26 p.m.) Status -- This change has been m

Re: Review Request 123386: Fix i18n catalog connection of a string in shortcuts config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123386/#review79067 --- Ship it! I don't think there's another way - David Edmundson

Review Request 123386: Fix i18n catalog connection of a string in shortcuts config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123386/ --- Review request for Plasma. Repository: plasma-desktop Description -

Build failed in Jenkins: plasma-desktop_stable_qt5 #111

See Changes: [anthony.vital] Kickoff - Properly register recent applications right after startup -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remote

Re: Review Request 123280: Kickoff - Properly register recent applications right after startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123280/ --- (Updated avr. 16, 2015, 4:26 après-midi) Status -- This change has b

Re: Review Request 123280: Kickoff - Properly register recent applications right after startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123280/#review79062 --- Ship it! Ship It! - David Edmundson On April 16, 2015, 1:0

Re: Review Request 123375: give quickshare the SLC capability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123375/ --- (Updated April 16, 2015, 4 p.m.) Status -- This change has been mark

Re: Review Request 123375: give quickshare the SLC capability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123375/#review79061 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 16, 2015,

Re: Review Request 123377: Fix i18n catalog connections in comic applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123377/ --- (Updated April 16, 2015, 3:54 p.m.) Status -- This change has been m

Re: Review Request 123375: give quickshare the SLC capability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123375/ --- (Updated April 16, 2015, 3:52 p.m.) Review request for Plasma and Aleix P

Re: Review Request 123375: give quickshare the SLC capability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123375/ --- (Updated April 16, 2015, 3:42 p.m.) Review request for Plasma and Aleix P

Build failed in Jenkins: plasma-workspace_stable_qt5 #106

See Changes: [mklapetek] [notifications] Make sure the timer is restarted after the popup moves -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remot

Re: Review Request 123351: Display sddm loginprompt only on the primary monitor

> On April 15, 2015, 10:53 p.m., David Kahles wrote: > > I just noticed another issue: when pressing the shutdown/reboot button, the > > login bar is shifted to the left and the shutdown/reboot bar comes in from > > the right. If you have a monitor left of the primary monitor, the loginbar > >

Re: Review Request 123351: Display sddm loginprompt only on the primary monitor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123351/ --- (Updated April 16, 2015, 3:59 p.m.) Review request for Plasma and David E

Re: Review Request 123280: Kickoff - Properly register recent applications right after startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123280/ --- (Updated avr. 16, 2015, 1:09 après-midi) Review request for Plasma. Cha

Re: Review Request 123382: System tray: Show more than 8 entries.

> On April 16, 2015, 1:42 p.m., Kai Uwe Broulik wrote: > > What about just wrapping it in a ScrollView rather than plain flickable so > > you get scrollbars that make it obvious there's more? > > Marco Martin wrote: > i would be fine with that as well > > Sebastian Kügler wrote: > +1 f

Re: Review Request 123382: System tray: Show more than 8 entries.

> On April 16, 2015, 11:42 a.m., Kai Uwe Broulik wrote: > > What about just wrapping it in a ScrollView rather than plain flickable so > > you get scrollbars that make it obvious there's more? > > Marco Martin wrote: > i would be fine with that as well +1 for scrollview. - Sebastian --

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

> On April 16, 2015, 1:43 p.m., Kai Uwe Broulik wrote: > > I think we should always pulse, and if available, use the needs attention > > icon (but don't cycle between normal and attention icon) > > Martin Klapetek wrote: > If you don't cycle it's quite easy to miss, so I think there'd be ve

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

> On April 16, 2015, 1:43 p.m., Kai Uwe Broulik wrote: > > I think we should always pulse, and if available, use the needs attention > > icon (but don't cycle between normal and attention icon) If you don't cycle it's quite easy to miss, so I think there'd be very little point in just switchin

Re: Review Request 123382: System tray: Show more than 8 entries.

> On April 16, 2015, 11:42 a.m., Kai Uwe Broulik wrote: > > What about just wrapping it in a ScrollView rather than plain flickable so > > you get scrollbars that make it obvious there's more? i would be fine with that as well - Marco

Re: Review Request 123382: System tray: Show more than 8 entries.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123382/#review79044 --- What about just wrapping it in a ScrollView rather than plain

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123381/#review79045 --- I think we should always pulse, and if available, use the need

[Breeze] [Bug 340137] Implement support for window groups (window tabs) in Breeze

https://bugs.kde.org/show_bug.cgi?id=340137 --- Comment #4 from Martin Gräßlin --- I'm sorry to say, but window tabbing is not yet implemented for kdecoration2 :-( -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-de

Re: Review Request 123382: System tray: Show more than 8 entries.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123382/#review79043 --- applets/systemtray/package/contents/ui/main.qml (line 70)

Review Request 123382: System tray: Show more than 8 entries.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123382/ --- Review request for Plasma. Bugs: 341165 https://bugs.kde.org/show_bug

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123381/ --- (Updated April 16, 2015, 1:23 p.m.) Review request for Plasma. Changes

Re: Review Request 123375: give quickshare the SLC capability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123375/ --- (Updated April 16, 2015, 11:19 a.m.) Review request for Plasma and Aleix

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123381/ --- (Updated April 16, 2015, 1:12 p.m.) Review request for Plasma. Changes

Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123381/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 123375: give quickshare the SLC capability

> On April 16, 2015, 10:19 a.m., Aleix Pol Gonzalez wrote: > > applets/quickshare/plasmoid/contents/ui/main.qml, line 228 > > > > > > I'm wondering whether we should just always show the document-share > > icon.

Re: Review Request 123375: give quickshare the SLC capability

> On April 16, 2015, 10:13 a.m., David Edmundson wrote: > > applets/quickshare/plasmoid/contents/ui/main.qml, line 98 > > > > > > content tracker has a mime type property sent over DBus, use that? yeah, seems it'

Re: Review Request 123375: give quickshare the SLC capability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123375/#review79036 --- applets/quickshare/plasmoid/contents/ui/main.qml (line 228) <

Re: Review Request 123375: give quickshare the SLC capability

> On April 16, 2015, 12:13 p.m., David Edmundson wrote: > > applets/quickshare/plugin/contenttracker.cpp, line 84 > > > > > > normalise the signatures, const shouldn't be there. > > > > https://marcmutz.wordp

[Breeze] [Bug 340137] Implement support for window groups (window tabs) in Breeze

https://bugs.kde.org/show_bug.cgi?id=340137 Rodrigo Fernandes changed: What|Removed |Added Version|5.1.0 |5.2.95 --- Comment #3 from Rodrigo Fernande

Re: Review Request 123375: give quickshare the SLC capability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123375/#review78990 --- applets/quickshare/plasmoid/contents/ui/main.qml (line 98)

[Breeze] [Bug 340137] Implement support for window groups (window tabs) in Breeze

https://bugs.kde.org/show_bug.cgi?id=340137 Phil Schaf changed: What|Removed |Added CC||flying-sh...@web.de Ever confirmed|0

Build failed in Jenkins: plasma-workspace_stable_qt5 #105

See Changes: [mklapetek] Update the date in the calendar/tooltip when user changes clock timezone -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building rem

Re: Review Request 123372: Update the date in the calendar/tooltip when user changes clock timezone

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123372/ --- (Updated April 16, 2015, 9:59 a.m.) Status -- This change has been m

[Plasma Workspace Wallpapers] [Bug 346252] Default wallpaper has jagged edges

https://bugs.kde.org/show_bug.cgi?id=346252 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk Resolution|

[Plasma Workspace Wallpapers] [Bug 346252] Default wallpaper has jagged edges

https://bugs.kde.org/show_bug.cgi?id=346252 Marco Martin changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|UNCONFIRMED

[Plasma Workspace Wallpapers] [Bug 346251] Default wallpaper cannot be found in desktop settings

https://bugs.kde.org/show_bug.cgi?id=346251 Marco Martin changed: What|Removed |Added CC||notm...@gmail.com --- Comment #2 from Marco Mart

Re: Review Request 123375: give quickshare the SLC capability

> On April 15, 2015, 11:03 p.m., Aleix Pol Gonzalez wrote: > > Interesting. Do you have any screenshot about what this share button looks > > like? > > > > Also I'm unsure about what it should look like, QuickShare overrides the > > value in the clipboard, is that what you want as well? Or sho

[Plasma Workspace Wallpapers] [Bug 346251] Default wallpaper cannot be found in desktop settings

https://bugs.kde.org/show_bug.cgi?id=346251 Jonathan Riddell changed: What|Removed |Added CC||j...@jriddell.org --- Comment #1 from Jonath

[Plasma Workspace Wallpapers] [Bug 346252] New: Default wallpaper has jagged edges

https://bugs.kde.org/show_bug.cgi?id=346252 Bug ID: 346252 Summary: Default wallpaper has jagged edges Product: Plasma Workspace Wallpapers Version: 5.2.95 Platform: openSUSE RPMs OS: Linux Status: UNCONFIRMED

[Plasma Workspace Wallpapers] [Bug 346251] New: Default wallpaper cannot be found in desktop settings

https://bugs.kde.org/show_bug.cgi?id=346251 Bug ID: 346251 Summary: Default wallpaper cannot be found in desktop settings Product: Plasma Workspace Wallpapers Version: 5.2.95 Platform: Other OS: Linux Status: UNCONF