> On April 16, 2015, 10:13 a.m., David Edmundson wrote: > > applets/quickshare/plasmoid/contents/ui/main.qml, line 98 > > <https://git.reviewboard.kde.org/r/123375/diff/1/?file=361198#file361198line98> > > > > content tracker has a mime type property sent over DBus, use that?
yeah, seems it's not always sent.. besides apps being fixed, it should probably try to use that first then fallback to mimetypeforurl, that seems quite reliable anyways - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123375/#review78990 ----------------------------------------------------------- On April 15, 2015, 6:27 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123375/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 6:27 p.m.) > > > Review request for Plasma and Aleix Pol Gonzalez. > > > Repository: kdeplasma-addons > > > Description > ------- > > Since as feature/ui-wise the purpose dialog is almost identical to the ui SLC > for kde4 had, it makes it quite adapt. > when an application providing the slc url is open, clicking on it opens the > purpose menu for sharing the url > > > Diffs > ----- > > applets/quickshare/plasmoid/contents/ui/ShareDialog.qml 0a5f717 > applets/quickshare/plasmoid/contents/ui/main.qml 075434b > applets/quickshare/plugin/CMakeLists.txt 2073c23 > applets/quickshare/plugin/contenttracker.h PRE-CREATION > applets/quickshare/plugin/contenttracker.cpp PRE-CREATION > applets/quickshare/plugin/org.kde.ActivityManager.SLC.xml PRE-CREATION > applets/quickshare/plugin/purposeplugin.cpp 23242ee > > Diff: https://git.reviewboard.kde.org/r/123375/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
