----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123299/#review79079 -----------------------------------------------------------
Ship it! Minor changes needed, otherwise it's good to go in. Thanks! applets/kickoff/core/recentlyusedmodel.cpp (line 109) <https://git.reviewboard.kde.org/r/123299/#comment54044> Why this change? applets/kickoff/core/recentlyusedmodel.cpp (line 174) <https://git.reviewboard.kde.org/r/123299/#comment54043> For new code, I'd prefer compile-time signal/slot syntax - Sebastian Kügler On April 8, 2015, 3:43 p.m., Anthony Vital wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123299/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 3:43 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Watch changes in the recent documents directory > > Fixes a bug when you opened a document already present in the recent docs > list, the document wasn't moved at the top of the list. > > > Diffs > ----- > > applets/kickoff/core/recentlyusedmodel.h > 44bcc9f091832a15524b17211739b3b1da0a27fa > applets/kickoff/core/recentlyusedmodel.cpp > a5a19ca8cac09e2fb2dca64b1dbfcc7085322ebf > > Diff: https://git.reviewboard.kde.org/r/123299/diff/ > > > Testing > ------- > > Opened documents already in the recent documents list, they now appear at the > top. > > > Thanks, > > Anthony Vital > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel