> On April 15, 2015, 11:03 p.m., Aleix Pol Gonzalez wrote: > > Interesting. Do you have any screenshot about what this share button looks > > like? > > > > Also I'm unsure about what it should look like, QuickShare overrides the > > value in the clipboard, is that what you want as well? Or should we move > > some UI like in Kamoso as well?
http://i.imgur.com/SOGAI7S.png and http://i.imgur.com/brKJv00.png the behavior of the plasmoidis not affected in other ways. and yes, i think putting the url in the clipboard is what i would expect - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123375/#review79009 ----------------------------------------------------------- On April 15, 2015, 6:27 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123375/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 6:27 p.m.) > > > Review request for Plasma and Aleix Pol Gonzalez. > > > Repository: kdeplasma-addons > > > Description > ------- > > Since as feature/ui-wise the purpose dialog is almost identical to the ui SLC > for kde4 had, it makes it quite adapt. > when an application providing the slc url is open, clicking on it opens the > purpose menu for sharing the url > > > Diffs > ----- > > applets/quickshare/plasmoid/contents/ui/ShareDialog.qml 0a5f717 > applets/quickshare/plasmoid/contents/ui/main.qml 075434b > applets/quickshare/plugin/CMakeLists.txt 2073c23 > applets/quickshare/plugin/contenttracker.h PRE-CREATION > applets/quickshare/plugin/contenttracker.cpp PRE-CREATION > applets/quickshare/plugin/org.kde.ActivityManager.SLC.xml PRE-CREATION > applets/quickshare/plugin/purposeplugin.cpp 23242ee > > Diff: https://git.reviewboard.kde.org/r/123375/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
